fix(pipelines): cannot configure actionName for all sources (#24027)

Add the ability for GitHub, CodeStar Connections, CodeCommit source types to configure the Action Name that is added to the pipeline.

This is necessary to add the same GitHub repository to the same pipeline twice with a different branch each time. By default, it would pick the same default name for each, which would then conflict.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: rix0rrr

packages/@aws-cdk/pipelines/lib/codepipeline/codepipeline-source.ts

@@ -236,6 +236,12 @@ export interface GitHubSourceOptions {
    */
   readonly trigger?: GitHubTrigger;
 
+  /**
+   * The action name used for this source in the CodePipeline
+   *
+   * @default - The repository string
+   */
+  readonly actionName?: string;
 }
 
 /**
@@ -262,7 +268,7 @@ class GitHubSource extends CodePipelineSource {
   protected getAction(output: Artifact, actionName: string, runOrder: number, variablesNamespace?: string) {
     return new cp_actions.GitHubSourceAction({
       output,
-      actionName,
+      actionName: this.props.actionName ?? actionName,
       runOrder,
       oauthToken: this.authentication,
       owner: this.owner,
@@ -379,7 +385,6 @@ export interface ConnectionSourceOptions {
    */
   readonly connectionArn: string;
 
-
   // long URL in @see
   /**
    * If this is set, the next CodeBuild job clones the repository (instead of CodePipeline downloading the files).
@@ -403,6 +408,13 @@ export interface ConnectionSourceOptions {
    * @see https://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-CodestarConnectionSource.html
    */
   readonly triggerOnPush?: boolean;
+
+  /**
+   * The action name used for this source in the CodePipeline
+   *
+   * @default - The repository string
+   */
+  readonly actionName?: string;
 }
 
 class CodeStarConnectionSource extends CodePipelineSource {
@@ -424,7 +436,7 @@ class CodeStarConnectionSource extends CodePipelineSource {
   protected getAction(output: Artifact, actionName: string, runOrder: number, variablesNamespace?: string) {
     return new cp_actions.CodeStarConnectionsSourceAction({
       output,
-      actionName,
+      actionName: this.props.actionName ?? actionName,
       runOrder,
       connectionArn: this.props.connectionArn,
       owner: this.owner,
@@ -468,6 +480,13 @@ export interface CodeCommitSourceOptions {
    * @see https://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-CodeCommit.html
    */
   readonly codeBuildCloneOutput?: boolean;
+
+  /**
+   * The action name used for this source in the CodePipeline
+   *
+   * @default - The repository name
+   */
+  readonly actionName?: string;
 }
 
 class CodeCommitSource extends CodePipelineSource {
@@ -483,7 +502,7 @@ class CodeCommitSource extends CodePipelineSource {
     return new cp_actions.CodeCommitSourceAction({
       output,
       // Guaranteed to be okay as action name
-      actionName: this.repository.repositoryName,
+      actionName: this.props.actionName ?? this.repository.repositoryName,
       runOrder,
       branch: this.branch,
       trigger: this.props.trigger,

packages/@aws-cdk/pipelines/test/codepipeline/codepipeline-sources.test.ts

@@ -288,3 +288,54 @@ test('pass role to s3 codepipeline source', () => {
     }]),
   });
 });
+
+type SourceFactory = (stack: Stack) => cdkp.CodePipelineSource;
+
+test.each([
+  ['CodeCommit', (stack) => {
+    const repo = new ccommit.Repository(stack, 'Repo', {
+      repositoryName: 'MyRepo',
+    });
+    return cdkp.CodePipelineSource.codeCommit(repo, 'main', {
+      actionName: 'ConfiguredName',
+    });
+  }],
+  ['S3', (stack) => {
+    const bucket = new s3.Bucket(stack, 'Bucket');
+    return cdkp.CodePipelineSource.s3(bucket, 'thefile.zip', {
+      actionName: 'ConfiguredName',
+    });
+  }],
+  ['ECR', (stack) => {
+    const repository = new ecr.Repository(stack, 'Repository', { repositoryName: 'namespace/repo' });
+    return cdkp.CodePipelineSource.ecr(repository, {
+      actionName: 'ConfiguredName',
+    });
+  }],
+  ['GitHub', () => {
+    return cdkp.CodePipelineSource.gitHub('owner/repo', 'main', {
+      actionName: 'ConfiguredName',
+    });
+  }],
+  ['CodeStar', () => {
+    return cdkp.CodePipelineSource.connection('owner/repo', 'main', {
+      connectionArn: 'arn:aws:codestar-connections:us-west-2:123456789012:connection/39e4c34d-e13a-4e94-a886',
+      actionName: 'ConfiguredName',
+    });
+  }],
+] as Array<[string, SourceFactory]>)('can configure actionName for %s', (_name: string, fac: SourceFactory) => {
+  new ModernTestGitHubNpmPipeline(pipelineStack, 'Pipeline', {
+    input: fac(pipelineStack),
+  });
+
+  Template.fromStack(pipelineStack).hasResourceProperties('AWS::CodePipeline::Pipeline', {
+    Stages: Match.arrayWith([{
+      Name: 'Source',
+      Actions: [
+        Match.objectLike({
+          Name: 'ConfiguredName',
+        }),
+      ],
+    }]),
+  });
+});