Skip to content

Commit 693afea

Browse files
authored
feat(eks): update nodegroup gpu check (#32715)
### Issue # (if applicable) Closes #31347. ### Reason for this change The motivating bug is that you cannot add a combo of g5 and a g6 as instance classes onto the same node group or else the following error will be thrown: `instanceTypes of different architectures is not allowed`. ### Description of changes * (eks) Fixes the `isGpuInstanceType` check * G6/G6E instance classes will now be recognized as GPU instance types so those different types can be used together for a multi instance type managed node group ### Description of how you validated changes Wrote unit tests for the `isGpuInstanceType` function ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- Duplicate of #31445, originally authored by @ [AlexKaracaoglu](https://github.com/AlexKaracaoglu) Co-authored-by: Alex Karacaoglu AlexKaracaoglu@users.noreply.github.com *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent f809b94 commit 693afea

File tree

33 files changed

+719
-384
lines changed

33 files changed

+719
-384
lines changed
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/asset.1eaf141d4012ab0977a33bdf864ebbc6aa869a607e97fab6cd231fe6ef503aec/index.js

Lines changed: 0 additions & 55 deletions
This file was deleted.

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/asset.46fb886516825167db3571f1ed91110fc6163ce20ee26fdb097c2c983f25fcd6/framework.js

Lines changed: 0 additions & 184 deletions
This file was deleted.

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/asset.46fb886516825167db3571f1ed91110fc6163ce20ee26fdb097c2c983f25fcd6/util.js

Lines changed: 0 additions & 54 deletions
This file was deleted.
Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/asset.9ebfbf95d93057cd65617a9d6f72a0e7dd31520f28cf423c3afd3cbaf0662e6b/framework.js

Lines changed: 185 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)