feat(location): throw ValidationError instead of untyped errors (#34174)

### Issue # (if applicable)

`aws-location-alpha` for #32569


### Description of changes

ValidationErrors everywhere




### Describe any new or updated permissions being added
n/a



### Description of how you validated changes
Existing tests. Exemptions granted as this is basically a refactor of existing code.




### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: mazyu36

packages/@aws-cdk/aws-location-alpha/.eslintrc.js

@@ -4,5 +4,12 @@ baseConfig.parserOptions.project = __dirname + '/tsconfig.json';
 baseConfig.rules['import/no-extraneous-dependencies'] = ['error', { devDependencies: true, peerDependencies: true } ];
 baseConfig.rules['import/order'] = 'off';
 baseConfig.rules['@aws-cdk/invalid-cfn-imports'] = 'off';
+baseConfig.rules['@cdklabs/no-throw-default-error'] = ['error'];
+baseConfig.overrides.push({
+  files: ["./test/**"],
+  rules: {
+    "@cdklabs/no-throw-default-error": "off",
+  },
+});
 
 module.exports = baseConfig;

packages/@aws-cdk/aws-location-alpha/lib/geofence-collection.ts

@@ -1,6 +1,6 @@
 import * as iam from 'aws-cdk-lib/aws-iam';
 import * as kms from 'aws-cdk-lib/aws-kms';
-import { ArnFormat, IResource, Lazy, Resource, Stack, Token } from 'aws-cdk-lib/core';
+import { ArnFormat, IResource, Lazy, Resource, Stack, Token, UnscopedValidationError, ValidationError } from 'aws-cdk-lib/core';
 import { Construct } from 'constructs';
 import { CfnGeofenceCollection } from 'aws-cdk-lib/aws-location';
 import { generateUniqueId } from './util';
@@ -81,7 +81,7 @@ export class GeofenceCollection extends Resource implements IGeofenceCollection
     const parsedArn = Stack.of(scope).splitArn(geofenceCollectionArn, ArnFormat.SLASH_RESOURCE_NAME);
 
     if (!parsedArn.resourceName) {
-      throw new Error(`Geofence Collection Arn ${geofenceCollectionArn} does not have a resource name.`);
+      throw new UnscopedValidationError(`Geofence Collection Arn ${geofenceCollectionArn} does not have a resource name.`);
     }
 
     class Import extends Resource implements IGeofenceCollection {
@@ -114,26 +114,25 @@ export class GeofenceCollection extends Resource implements IGeofenceCollection
   public readonly geofenceCollectionUpdateTime: string;
 
   constructor(scope: Construct, id: string, props: GeofenceCollectionProps = {}) {
+    super(scope, id, {
+      physicalName: props.geofenceCollectionName ?? Lazy.string({ produce: () => generateUniqueId(this) }),
+    });
+    // Enhanced CDK Analytics Telemetry
+    addConstructMetadata(this, props);
+
     if (props.description && !Token.isUnresolved(props.description) && props.description.length > 1000) {
-      throw new Error(`\`description\` must be between 0 and 1000 characters. Received: ${props.description.length} characters`);
+      throw new ValidationError(`\`description\` must be between 0 and 1000 characters. Received: ${props.description.length} characters`, this);
     }
 
     if (props.geofenceCollectionName !== undefined && !Token.isUnresolved(props.geofenceCollectionName)) {
       if (props.geofenceCollectionName.length < 1 || props.geofenceCollectionName.length > 100) {
-        throw new Error(`\`geofenceCollectionName\` must be between 1 and 100 characters, got: ${props.geofenceCollectionName.length} characters.`);
+        throw new ValidationError(`\`geofenceCollectionName\` must be between 1 and 100 characters, got: ${props.geofenceCollectionName.length} characters.`, this);
       }
 
       if (!/^[-._\w]+$/.test(props.geofenceCollectionName)) {
-        throw new Error(`\`geofenceCollectionName\` must contain only alphanumeric characters, hyphens, periods and underscores, got: ${props.geofenceCollectionName}.`);
+        throw new ValidationError(`\`geofenceCollectionName\` must contain only alphanumeric characters, hyphens, periods and underscores, got: ${props.geofenceCollectionName}.`, this);
       }
     }
-
-    super(scope, id, {
-      physicalName: props.geofenceCollectionName ?? Lazy.string({ produce: () => generateUniqueId(this) }),
-    });
-    // Enhanced CDK Analytics Telemetry
-    addConstructMetadata(this, props);
-
     const geofenceCollection = new CfnGeofenceCollection(this, 'Resource', {
       collectionName: this.physicalName,
       description: props.description,

packages/@aws-cdk/aws-location-alpha/lib/map.ts

@@ -1,5 +1,5 @@
 import * as iam from 'aws-cdk-lib/aws-iam';
-import { ArnFormat, IResource, Lazy, Resource, Stack, Token } from 'aws-cdk-lib/core';
+import { ArnFormat, IResource, Lazy, Resource, Stack, Token, UnscopedValidationError, ValidationError } from 'aws-cdk-lib/core';
 import { Construct } from 'constructs';
 import { CfnMap } from 'aws-cdk-lib/aws-location';
 import { generateUniqueId } from './util';
@@ -241,7 +241,7 @@ export class Map extends Resource implements IMap {
     const parsedArn = Stack.of(scope).splitArn(mapArn, ArnFormat.SLASH_RESOURCE_NAME);
 
     if (!parsedArn.resourceName) {
-      throw new Error(`Map Arn ${mapArn} does not have a resource name.`);
+      throw new UnscopedValidationError(`Map Arn ${mapArn} does not have a resource name.`);
     }
 
     class Import extends Resource implements IMap {
@@ -274,26 +274,26 @@ export class Map extends Resource implements IMap {
   public readonly mapUpdateTime: string;
 
   constructor(scope: Construct, id: string, props: MapProps) {
+    super(scope, id, {
+      physicalName: props.mapName ?? Lazy.string({ produce: () => generateUniqueId(this) }),
+    });
+    // Enhanced CDK Analytics Telemetry
+    addConstructMetadata(this, props);
+
     if (props.description && !Token.isUnresolved(props.description) && props.description.length > 1000) {
-      throw new Error(`\`description\` must be between 0 and 1000 characters, got: ${props.description.length} characters.`);
+      throw new ValidationError(`\`description\` must be between 0 and 1000 characters, got: ${props.description.length} characters.`, this);
     }
 
     if (props.mapName !== undefined && !Token.isUnresolved(props.mapName)) {
       if (props.mapName.length < 1 || props.mapName.length > 100) {
-        throw new Error(`\`mapName\` must be between 1 and 100 characters, got: ${props.mapName.length} characters.`);
+        throw new ValidationError(`\`mapName\` must be between 1 and 100 characters, got: ${props.mapName.length} characters.`, this);
       }
 
       if (!/^[-._\w]+$/.test(props.mapName)) {
-        throw new Error(`\`mapName\` must contain only alphanumeric characters, hyphens, periods and underscores, got: ${props.mapName}.`);
+        throw new ValidationError(`\`mapName\` must contain only alphanumeric characters, hyphens, periods and underscores, got: ${props.mapName}.`, this);
       }
     }
 
-    super(scope, id, {
-      physicalName: props.mapName ?? Lazy.string({ produce: () => generateUniqueId(this) }),
-    });
-    // Enhanced CDK Analytics Telemetry
-    addConstructMetadata(this, props);
-
     const map = new CfnMap(this, 'Resource', {
       configuration: {
         style: props.style,

packages/@aws-cdk/aws-location-alpha/lib/place-index.ts

@@ -1,5 +1,5 @@
 import * as iam from 'aws-cdk-lib/aws-iam';
-import { ArnFormat, IResource, Lazy, Resource, Stack, Token } from 'aws-cdk-lib/core';
+import { ArnFormat, IResource, Lazy, Resource, Stack, Token, UnscopedValidationError, ValidationError } from 'aws-cdk-lib/core';
 import { Construct } from 'constructs';
 import { CfnPlaceIndex } from 'aws-cdk-lib/aws-location';
 import { DataSource, generateUniqueId } from './util';
@@ -101,7 +101,7 @@ export class PlaceIndex extends Resource implements IPlaceIndex {
     const parsedArn = Stack.of(scope).splitArn(placeIndexArn, ArnFormat.SLASH_RESOURCE_NAME);
 
     if (!parsedArn.resourceName) {
-      throw new Error(`Place Index Arn ${placeIndexArn} does not have a resource name.`);
+      throw new UnscopedValidationError(`Place Index Arn ${placeIndexArn} does not have a resource name.`);
     }
 
     class Import extends Resource implements IPlaceIndex {
@@ -134,26 +134,26 @@ export class PlaceIndex extends Resource implements IPlaceIndex {
   public readonly placeIndexUpdateTime: string;
 
   constructor(scope: Construct, id: string, props: PlaceIndexProps = {}) {
+    super(scope, id, {
+      physicalName: props.placeIndexName ?? Lazy.string({ produce: () => generateUniqueId(this) }),
+    });
+    // Enhanced CDK Analytics Telemetry
+    addConstructMetadata(this, props);
+
     if (props.description && !Token.isUnresolved(props.description) && props.description.length > 1000) {
-      throw new Error(`\`description\` must be between 0 and 1000 characters. Received: ${props.description.length} characters`);
+      throw new ValidationError(`\`description\` must be between 0 and 1000 characters. Received: ${props.description.length} characters`, this);
     }
 
     if (props.placeIndexName !== undefined && !Token.isUnresolved(props.placeIndexName)) {
       if (props.placeIndexName.length < 1 || props.placeIndexName.length > 100) {
-        throw new Error(`\`placeIndexName\` must be between 1 and 100 characters, got: ${props.placeIndexName.length} characters.`);
+        throw new ValidationError(`\`placeIndexName\` must be between 1 and 100 characters, got: ${props.placeIndexName.length} characters.`, this);
       }
 
       if (!/^[-._\w]+$/.test(props.placeIndexName)) {
-        throw new Error(`\`placeIndexName\` must contain only alphanumeric characters, hyphens, periods and underscores, got: ${props.placeIndexName}.`);
+        throw new ValidationError(`\`placeIndexName\` must contain only alphanumeric characters, hyphens, periods and underscores, got: ${props.placeIndexName}.`, this);
       }
     }
 
-    super(scope, id, {
-      physicalName: props.placeIndexName ?? Lazy.string({ produce: () => generateUniqueId(this) }),
-    });
-    // Enhanced CDK Analytics Telemetry
-    addConstructMetadata(this, props);
-
     const placeIndex = new CfnPlaceIndex(this, 'Resource', {
       indexName: this.physicalName,
       dataSource: props.dataSource ?? DataSource.ESRI,

packages/@aws-cdk/aws-location-alpha/lib/route-calculator.ts

@@ -1,5 +1,5 @@
 import * as iam from 'aws-cdk-lib/aws-iam';
-import { ArnFormat, IResource, Lazy, Resource, Stack, Token } from 'aws-cdk-lib/core';
+import { ArnFormat, IResource, Lazy, Resource, Stack, Token, UnscopedValidationError, ValidationError } from 'aws-cdk-lib/core';
 import { Construct } from 'constructs';
 import { CfnRouteCalculator } from 'aws-cdk-lib/aws-location';
 import { generateUniqueId, DataSource } from './util';
@@ -77,7 +77,7 @@ export class RouteCalculator extends Resource implements IRouteCalculator {
     const parsedArn = Stack.of(scope).splitArn(routeCalculatorArn, ArnFormat.SLASH_RESOURCE_NAME);
 
     if (!parsedArn.resourceName) {
-      throw new Error(`Route Calculator Arn ${routeCalculatorArn} does not have a resource name.`);
+      throw new UnscopedValidationError(`Route Calculator Arn ${routeCalculatorArn} does not have a resource name.`);
     }
 
     class Import extends Resource implements IRouteCalculator {
@@ -110,26 +110,26 @@ export class RouteCalculator extends Resource implements IRouteCalculator {
   public readonly routeCalculatorUpdateTime: string;
 
   constructor(scope: Construct, id: string, props: RouteCalculatorProps) {
+    super(scope, id, {
+      physicalName: props.routeCalculatorName ?? Lazy.string({ produce: () => generateUniqueId(this) }),
+    });
+    // Enhanced CDK Analytics Telemetry
+    addConstructMetadata(this, props);
+
     if (props.description && !Token.isUnresolved(props.description) && props.description.length > 1000) {
-      throw new Error(`\`description\` must be between 0 and 1000 characters. Received: ${props.description.length} characters`);
+      throw new ValidationError(`\`description\` must be between 0 and 1000 characters. Received: ${props.description.length} characters`, this);
     }
 
     if (props.routeCalculatorName !== undefined && !Token.isUnresolved(props.routeCalculatorName)) {
       if (props.routeCalculatorName.length < 1 || props.routeCalculatorName.length > 100) {
-        throw new Error(`\`routeCalculatorName\` must be between 1 and 100 characters, got: ${props.routeCalculatorName.length} characters.`);
+        throw new ValidationError(`\`routeCalculatorName\` must be between 1 and 100 characters, got: ${props.routeCalculatorName.length} characters.`, this);
       }
 
       if (!/^[-._\w]+$/.test(props.routeCalculatorName)) {
-        throw new Error(`\`routeCalculatorName\` must contain only alphanumeric characters, hyphens, periods and underscores, got: ${props.routeCalculatorName}.`);
+        throw new ValidationError(`\`routeCalculatorName\` must contain only alphanumeric characters, hyphens, periods and underscores, got: ${props.routeCalculatorName}.`, this);
       }
     }
 
-    super(scope, id, {
-      physicalName: props.routeCalculatorName ?? Lazy.string({ produce: () => generateUniqueId(this) }),
-    });
-    // Enhanced CDK Analytics Telemetry
-    addConstructMetadata(this, props);
-
     const routeCalculator = new CfnRouteCalculator(this, 'Resource', {
       calculatorName: this.physicalName,
       dataSource: props.dataSource ?? DataSource.ESRI,

packages/@aws-cdk/aws-location-alpha/lib/tracker.ts

@@ -1,6 +1,6 @@
 import * as iam from 'aws-cdk-lib/aws-iam';
 import * as kms from 'aws-cdk-lib/aws-kms';
-import { ArnFormat, IResource, Lazy, Resource, Stack, Token } from 'aws-cdk-lib/core';
+import { ArnFormat, IResource, Lazy, Resource, Stack, Token, UnscopedValidationError, ValidationError } from 'aws-cdk-lib/core';
 import { Construct } from 'constructs';
 import { CfnTracker, CfnTrackerConsumer } from 'aws-cdk-lib/aws-location';
 import { generateUniqueId } from './util';
@@ -140,7 +140,7 @@ export class Tracker extends Resource implements ITracker {
     const parsedArn = Stack.of(scope).splitArn(trackerArn, ArnFormat.SLASH_RESOURCE_NAME);
 
     if (!parsedArn.resourceName) {
-      throw new Error(`Tracker Arn ${trackerArn} does not have a resource name.`);
+      throw new UnscopedValidationError(`Tracker Arn ${trackerArn} does not have a resource name.`);
     }
 
     class Import extends Resource implements ITracker {
@@ -173,33 +173,33 @@ export class Tracker extends Resource implements ITracker {
   public readonly trackerUpdateTime: string;
 
   constructor(scope: Construct, id: string, props: TrackerProps = {}) {
+    super(scope, id, {
+      physicalName: props.trackerName ?? Lazy.string({ produce: () => generateUniqueId(this) }),
+    });
+    // Enhanced CDK Analytics Telemetry
+    addConstructMetadata(this, props);
+
     if (props.description && !Token.isUnresolved(props.description) && props.description.length > 1000) {
-      throw new Error(`\`description\` must be between 0 and 1000 characters. Received: ${props.description.length} characters`);
+      throw new ValidationError(`\`description\` must be between 0 and 1000 characters. Received: ${props.description.length} characters`, this);
     }
 
     if (props.trackerName !== undefined && !Token.isUnresolved(props.trackerName)) {
       if (props.trackerName.length < 1 || props.trackerName.length > 100) {
-        throw new Error(`\`trackerName\` must be between 1 and 100 characters, got: ${props.trackerName.length} characters.`);
+        throw new ValidationError(`\`trackerName\` must be between 1 and 100 characters, got: ${props.trackerName.length} characters.`, this);
       }
 
       if (!/^[-._\w]+$/.test(props.trackerName)) {
-        throw new Error(`\`trackerName\` must contain only alphanumeric characters, hyphens, periods and underscores, got: ${props.trackerName}.`);
+        throw new ValidationError(`\`trackerName\` must contain only alphanumeric characters, hyphens, periods and underscores, got: ${props.trackerName}.`, this);
       }
     }
 
     if (!Token.isUnresolved(props.kmsKey)
       && !props.kmsKey
       && props.kmsKeyEnableGeospatialQueries
     ) {
-      throw new Error('`kmsKeyEnableGeospatialQueries` can only be enabled that are configured to use an AWS KMS customer managed key');
+      throw new ValidationError('`kmsKeyEnableGeospatialQueries` can only be enabled that are configured to use an AWS KMS customer managed key', this);
     }
 
-    super(scope, id, {
-      physicalName: props.trackerName ?? Lazy.string({ produce: () => generateUniqueId(this) }),
-    });
-    // Enhanced CDK Analytics Telemetry
-    addConstructMetadata(this, props);
-
     const tracker = new CfnTracker(this, 'Resource', {
       trackerName: this.physicalName,
       description: props.description,