Skip to content

Commit a8ee8d1

Browse files
committed
docs: review comments
1 parent 87dd2bb commit a8ee8d1

28 files changed

+118
-60
lines changed

docs/snippets/parameters/adjustingCacheTTL.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@ import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm';
22

33
const parametersProvider = new SSMProvider();
44

5-
export const handler = async (_event, _context): Promise<void> => {
5+
export const handler = async (): Promise<void> => {
66
// Retrieve a single parameter
77
const parameter = await parametersProvider.get('/my/parameter', { maxAge: 60 }); // 1 minute
88
console.log(parameter);
99

1010
// Retrieve multiple parameters from a path prefix
1111
const parameters = await parametersProvider.getMultiple('/my/path/prefix', { maxAge: 120 }); // 2 minutes
12-
for (const [ key, value ] of Object.entries(parameters)) {
12+
for (const [ key, value ] of Object.entries(parameters || {})) {
1313
console.log(`${key}: ${value}`);
1414
}
1515
};

docs/snippets/parameters/appConfigProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const configsProvider = new AppConfigProvider({
88
clientConfig,
99
});
1010

11-
export const handler = async (_event, _context): Promise<void> => {
11+
export const handler = async (): Promise<void> => {
1212
// Retrieve a config
1313
const config = await configsProvider.get('my-config');
1414
console.log(config);

docs/snippets/parameters/appConfigProviderCustomClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const appConfigClient = new AppConfigDataClient({ region: 'us-east-1' });
66
// pass the client to the provider
77
const configsProvider = new AppConfigProvider({ awsSdkV3Client: appConfigClient });
88

9-
export const handler = async (_event, _context): Promise<void> => {
9+
export const handler = async (): Promise<void> => {
1010
const config = await configsProvider.get('my-config');
1111
console.log(config);
1212
};

docs/snippets/parameters/clientConfig.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import type { SSMClientConfig } from '@aws-sdk/client-ssm';
44
const clientConfig: SSMClientConfig = { region: 'us-east-1' };
55
const parametersProvider = new SSMProvider({ clientConfig });
66

7-
export const handler = async (_event, _context): Promise<void> => {
7+
export const handler = async (): Promise<void> => {
88
// Retrieve a single parameter
99
const value = await parametersProvider.get('/my/parameter');
1010
console.log(value);

docs/snippets/parameters/dynamoDBProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { DynamoDBProvider } from '@aws-lambda-powertools/parameters/dynamodb';
22

33
const dynamoDBProvider = new DynamoDBProvider({ tableName: 'my-table' });
44

5-
export const handler = async (_event, _context): Promise<void> => {
5+
export const handler = async (): Promise<void> => {
66
// Retrieve a value from DynamoDB
77
const value = await dynamoDBProvider.get('my-parameter');
88
console.log(value);

docs/snippets/parameters/dynamoDBProviderCustomClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const dynamoDBClient = new DynamoDBClient({ region: 'us-east-1' });
66
// pass the client to the provider
77
const valuesProvider = new DynamoDBProvider({ awsSdkV3Client: dynamoDBClient });
88

9-
export const handler = async (_event, _context): Promise<void> => {
9+
export const handler = async (): Promise<void> => {
1010
// Retrieve a single value
1111
const value = await valuesProvider.get('my-value');
1212
console.log(value);

docs/snippets/parameters/dynamoDBProviderCustomizeTable.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const dynamoDBProvider = new DynamoDBProvider({
77
valueAttr:'val'
88
});
99

10-
export const handler = async (_event, _context): Promise<void> => {
10+
export const handler = async (): Promise<void> => {
1111
const value = await dynamoDBProvider.get('my-parameter');
1212
console.log(value);
1313
};

docs/snippets/parameters/dynamoDBProviderLocal.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const dynamoDBProvider = new DynamoDBProvider({
77
},
88
});
99

10-
export const handler = async (_event, _context): Promise<void> => {
10+
export const handler = async (): Promise<void> => {
1111
// Retrieve a value from DynamoDB
1212
const value = await dynamoDBProvider.get('my-parameter');
1313
console.log(value);

docs/snippets/parameters/dynamoDBProviderMultiple.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ import { DynamoDBProvider } from '@aws-lambda-powertools/parameters/dynamodb';
22

33
const dynamoDBProvider = new DynamoDBProvider({ tableName: 'my-table' });
44

5-
export const handler = async (_event, _context): Promise<void> => {
5+
export const handler = async (): Promise<void> => {
66
/**
77
* Retrieve multiple values by performing a Query on the DynamoDB table.
88
* This returns a dict with the sort key attribute as dict key.
99
*/
1010
const values = await dynamoDBProvider.getMultiple('my-hash-key');
11-
for (const [ key, value ] of Object.entries(values)) {
11+
for (const [ key, value ] of Object.entries(values || {})) {
1212
// key: param-a
1313
// value: my-value-a
1414
console.log(`${key}: ${value}`);

docs/snippets/parameters/forceFetch.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { getParameter } from '@aws-lambda-powertools/parameters/ssm';
22

3-
export const handler = async (_event, _context): Promise<void> => {
3+
export const handler = async (): Promise<void> => {
44
// Retrieve a single parameter
55
const parameter = await getParameter('/my/parameter', { forceFetch: true });
66
console.log(parameter);

docs/snippets/parameters/getAppConfig.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { getAppConfig } from '@aws-lambda-powertools/parameters/appconfig';
22

3-
export const handler = async (_event, _context): Promise<void> => {
3+
export const handler = async (): Promise<void> => {
44
// Retrieve a configuration, latest version
55
const config = await getAppConfig('my-configuration', {
66
environment: 'my-env',

docs/snippets/parameters/getParameter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { getParameter } from '@aws-lambda-powertools/parameters/ssm';
22

3-
export const handler = async (_event, _context): Promise<void> => {
3+
export const handler = async (): Promise<void> => {
44
// Retrieve a single parameter
55
const parameter = await getParameter('/my/parameter');
66
console.log(parameter);
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { getParameters } from '@aws-lambda-powertools/parameters/ssm';
22

3-
export const handler = async (_event, _context): Promise<void> => {
3+
export const handler = async (): Promise<void> => {
44
/**
55
* Retrieve multiple parameters from a path prefix recursively.
66
* This returns an object with the parameter name as key
77
*/
88
const parameters = await getParameters('/my/path/prefix');
9-
for (const [ key, value ] of Object.entries(parameters)) {
9+
for (const [ key, value ] of Object.entries(parameters || {})) {
1010
console.log(`${key}: ${value}`);
1111
}
1212
};

docs/snippets/parameters/getParametersByName.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
import { getParametersByName } from '@aws-lambda-powertools/parameters/ssm';
2+
import type {
3+
SSMGetParametersByNameOptionsInterface
4+
} from '@aws-lambda-powertools/parameters/ssm';
25

3-
const props = {
6+
const props: Record<string, SSMGetParametersByNameOptionsInterface> = {
47
'/develop/service/commons/telemetry/config': { maxAge: 300, transform: 'json' },
58
'/no_cache_param': { maxAge: 0 },
69
'/develop/service/payment/api/capture/url': {}, // When empty or undefined, it uses default values
710
};
811

9-
export const handler = async (_event, _context): Promise<void> => {
12+
export const handler = async (): Promise<void> => {
1013
// This returns an object with the parameter name as key
1114
const parameters = await getParametersByName(props, { maxAge: 60 });
1215
for (const [ key, value ] of Object.entries(parameters)) {

docs/snippets/parameters/getParametersByNameGracefulErrorHandling.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
import { getParametersByName } from '@aws-lambda-powertools/parameters/ssm';
2+
import type {
3+
SSMGetParametersByNameOptionsInterface
4+
} from '@aws-lambda-powertools/parameters/ssm';
25

3-
const props = {
6+
const props: Record<string, SSMGetParametersByNameOptionsInterface> = {
47
'/develop/service/commons/telemetry/config': { maxAge: 300, transform: 'json' },
58
'/this/param/does/not/exist': {}, // <- Example of non-existent parameter
69
};
710

8-
export const handler = async (_event, _context): Promise<void> => {
11+
export const handler = async (): Promise<void> => {
912
const {
1013
_errors: errors,
1114
...parameters

docs/snippets/parameters/getSecret.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { getSecret } from '@aws-lambda-powertools/parameters/secrets';
22

3-
export const handler = async (_event, _context): Promise<void> => {
3+
export const handler = async (): Promise<void> => {
44
// Retrieve a single secret
55
const secret = await getSecret('my-secret');
66
console.log(secret);

docs/snippets/parameters/sdkOptions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { GetSecretValueCommandInput } from '@aws-sdk/client-secrets-manager
33

44
const secretsProvider = new SecretsProvider();
55

6-
export const handler = async (_event, _context): Promise<void> => {
6+
export const handler = async (): Promise<void> => {
77
const sdkOptions: Partial<GetSecretValueCommandInput> = {
88
VersionId: 'e62ec170-6b01-48c7-94f3-d7497851a8d2'
99
};

docs/snippets/parameters/secretsProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import type { SecretsManagerClientConfig } from '@aws-sdk/client-secretsmanager'
44
const clientConfig: SecretsManagerClientConfig = { region: 'us-east-1' };
55
const secretsProvider = new SecretsProvider({ clientConfig });
66

7-
export const handler = async (_event, _context): Promise<void> => {
7+
export const handler = async (): Promise<void> => {
88
// Retrieve a single secret
99
const secret = await secretsProvider.get('my-secret');
1010
console.log(secret);

docs/snippets/parameters/secretsProviderCustomClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const secretsManagerClient = new SecretsManagerClient({ region: 'us-east-1' });
66
// pass the client to the provider
77
const secretsProvider = new SecretsProvider({ awsSdkV3Client: secretsManagerClient });
88

9-
export const handler = async (_event, _context): Promise<void> => {
9+
export const handler = async (): Promise<void> => {
1010
// Retrieve a single secret
1111
const secret = await secretsProvider.get('my-secret');
1212
console.log(secret);

docs/snippets/parameters/ssmProvider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ import type { SSMClientConfig } from '@aws-sdk/client-ssm';
44
const clientConfig: SSMClientConfig = { region: 'us-east-1' };
55
const parametersProvider = new SSMProvider({ clientConfig });
66

7-
export const handler = async (_event, _context): Promise<void> => {
7+
export const handler = async (): Promise<void> => {
88
// Retrieve a single parameter
99
const parameter = await parametersProvider.get('/my/parameter');
1010
console.log(parameter);
1111

1212
// Retrieve multiple parameters from a path prefix
1313
const parameters = await parametersProvider.getMultiple('/my/path/prefix');
14-
for (const [ key, value ] of Object.entries(parameters)) {
14+
for (const [ key, value ] of Object.entries(parameters || {})) {
1515
console.log(`${key}: ${value}`);
1616
}
1717
};

docs/snippets/parameters/ssmProviderCustomClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const ssmClient = new SSMClient({ region: 'us-east-1' });
66
// pass the client to the provider
77
const parametersProvider = new SSMProvider({ awsSdkV3Client: ssmClient });
88

9-
export const handler = async (_event, _context): Promise<void> => {
9+
export const handler = async (): Promise<void> => {
1010
// Retrieve a single parameter
1111
const parameter = await parametersProvider.get('/my/parameter');
1212
console.log(parameter);

docs/snippets/parameters/ssmProviderDecryptAndRecursive.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm';
22

33
const parametersProvider = new SSMProvider();
44

5-
export const handler = async (_event, _context): Promise<void> => {
5+
export const handler = async (): Promise<void> => {
66
const decryptedValue = await parametersProvider.get('/my/encrypted/parameter', { decrypt: true });
77
console.log(decryptedValue);
88

99
const noRecursiveValues = await parametersProvider.getMultiple('/my/path/prefix', { recursive: false });
10-
for (const [ key, value ] of Object.entries(noRecursiveValues)) {
10+
for (const [ key, value ] of Object.entries(noRecursiveValues || {})) {
1111
console.log(`${key}: ${value}`);
1212
}
1313
};

docs/snippets/parameters/transform.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { getParameter } from '@aws-lambda-powertools/parameters/ssm';
22

3-
export const handler = async (_event, _context): Promise<void> => {
3+
export const handler = async (): Promise<void> => {
44
const valueFromJson = await getParameter('/my/json/parameter', { transform: 'json' });
55
console.log(valueFromJson);
66
};

docs/snippets/parameters/transformAuto.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm';
22

33
const parametersProvider = new SSMProvider();
44

5-
export const handler = async (_event, _context): Promise<void> => {
5+
export const handler = async (): Promise<void> => {
66
const values = await parametersProvider.getMultiple('/param', { transform: 'auto' });
7-
for (const [ key, value ] of Object.entries(values)) {
7+
for (const [ key, value ] of Object.entries(values || {})) {
88
console.log(`${key}: ${value}`);
99
}
1010
};

docs/snippets/parameters/transformPartialFailures.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm';
22

33
const parametersProvider = new SSMProvider();
44

5-
export const handler = async (_event, _context): Promise<void> => {
5+
export const handler = async (): Promise<void> => {
66
/**
77
* This will display:
88
* /param/a: [some value]
99
* /param/b: [some value]
1010
* /param/c: undefined
1111
*/
1212
const parameters = await parametersProvider.getMultiple('/param', { transform: 'json' });
13-
for (const [ key, value ] of Object.entries(parameters)) {
13+
for (const [ key, value ] of Object.entries(parameters || {})) {
1414
console.log(`${key}: ${value}`);
1515
}
1616

@@ -20,7 +20,7 @@ export const handler = async (_event, _context): Promise<void> => {
2020
transform: 'json',
2121
throwOnTransformError: true
2222
});
23-
for (const [ key, value ] of Object.entries(parameters2)) {
23+
for (const [ key, value ] of Object.entries(parameters2 || {})) {
2424
console.log(`${key}: ${value}`);
2525
}
2626
} catch (err) {

docs/snippets/parameters/transformProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { SecretsProvider } from '@aws-lambda-powertools/parameters/secrets';
22

33
const secretsProvider = new SecretsProvider();
44

5-
export const handler = async (_event, _context): Promise<void> => {
5+
export const handler = async (): Promise<void> => {
66
// Transform a JSON string
77
const json = await secretsProvider.get('my-secret-json', { transform: 'json' });
88
console.log(json);
Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
{
2+
"compilerOptions": {
3+
"experimentalDecorators": true,
4+
"noImplicitAny": true,
5+
"target": "ES2020",
6+
"module": "commonjs",
7+
"declaration": true,
8+
"declarationMap": true,
9+
"outDir": "lib",
10+
"removeComments": false,
11+
"strict": true,
12+
"inlineSourceMap": true,
13+
"moduleResolution": "node",
14+
"resolveJsonModule": true,
15+
"pretty": true,
16+
"esModuleInterop": true,
17+
"allowJs": true,
18+
"baseUrl": ".",
19+
"paths": {
20+
"@aws-lambda-powertools/parameters/ssm": [
21+
"../../../packages/parameters/lib/ssm"
22+
],
23+
"@aws-lambda-powertools/parameters/secrets": [
24+
"../../../packages/parameters/lib/secrets"
25+
],
26+
"@aws-lambda-powertools/parameters/appconfig": [
27+
"../../../packages/parameters/lib/appconfig"
28+
],
29+
"@aws-lambda-powertools/parameters/dynamodb": [
30+
"../../../packages/parameters/lib/dynamodb"
31+
],
32+
},
33+
},
34+
"exclude": [
35+
"./node_modules"
36+
],
37+
"watchOptions": {
38+
"watchFile": "useFsEvents",
39+
"watchDirectory": "useFsEvents",
40+
"fallbackPolling": "dynamicPriority"
41+
},
42+
"lib": [
43+
"ES2020"
44+
],
45+
"types": [
46+
"node"
47+
]
48+
}

0 commit comments

Comments
 (0)