Skip to content

Commit 3d423e5

Browse files
committed
improv(metrics): logMetricsAfterOrError middleware, examples update
1 parent f29fc49 commit 3d423e5

File tree

2 files changed

+15
-9
lines changed

2 files changed

+15
-9
lines changed

packages/metrics/examples/decorator/single-metric.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import * as dummyEvent from '../../../tests/resources/events/custom/hello-world.
33
import { context as dummyContext } from '../../../tests/resources/contexts/hello-world';
44
import { LambdaInterface } from './utils/lambda/LambdaInterface';
55
import { Callback, Context } from 'aws-lambda/handler';
6-
import { Metrics, MetricUnits } from '../src';
6+
import { Metrics, MetricUnits } from '../../src';
77

88
// Populate runtime
99
populateEnvironmentVariables();
@@ -16,11 +16,14 @@ class Lambda implements LambdaInterface {
1616

1717
@metrics.logMetrics()
1818
public handler<TEvent, TResult>(_event: TEvent, _context: Context, _callback: Callback<TResult>): void | Promise<TResult> {
19+
metrics.addDimension('metricUnit', 'milliseconds');
20+
// This metric will have the "metricUnit" dimension, and no "metricType" dimension:
21+
metrics.addMetric('latency', MetricUnits.Milliseconds, 56);
22+
1923
const singleMetric = metrics.singleMetric();
20-
metrics.addDimension('OuterDimension', 'true');
21-
singleMetric.addDimension('InnerDimension', 'true');
22-
metrics.addMetric('test-metric', MetricUnits.Count, 10);
23-
singleMetric.addMetric('single-metric', MetricUnits.Percent, 50);
24+
// This metric will have the "metricType" dimension, and no "metricUnit" dimension:
25+
singleMetric.addDimension('metricType', 'business');
26+
singleMetric.addMetric('videoClicked', MetricUnits.Count, 1);
2427
}
2528

2629
}

packages/metrics/examples/single-metric.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,14 @@ process.env.POWERTOOLS_METRICS_NAMESPACE = 'hello-world';
1313
const metrics = new Metrics();
1414

1515
const lambdaHandler = async (): Promise<void> => {
16+
metrics.addDimension('metricUnit', 'milliseconds');
17+
// This metric will have the "metricUnit" dimension, and no "metricType" dimension:
18+
metrics.addMetric('latency', MetricUnits.Milliseconds, 56);
19+
1620
const singleMetric = metrics.singleMetric();
17-
metrics.addDimension('OuterDimension', 'true');
18-
singleMetric.addDimension('InnerDimension', 'true');
19-
metrics.addMetric('test-metric', MetricUnits.Count, 10);
20-
singleMetric.addMetric('single-metric', MetricUnits.Percent, 50);
21+
// This metric will have the "metricType" dimension, and no "metricUnit" dimension:
22+
singleMetric.addDimension('metricType', 'business');
23+
singleMetric.addMetric('videoClicked', MetricUnits.Count, 1);
2124
};
2225

2326
const handlerWithMiddleware = middy(lambdaHandler)

0 commit comments

Comments
 (0)