From 9ceff53b62ede3ee822387512c5134ec92b2b1b8 Mon Sep 17 00:00:00 2001 From: Michael Brewer Date: Wed, 17 Mar 2021 06:41:04 -0700 Subject: [PATCH 1/3] docs(tracer): Fix typing for Pycharm --- aws_lambda_powertools/tracing/tracer.py | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/aws_lambda_powertools/tracing/tracer.py b/aws_lambda_powertools/tracing/tracer.py index dd136998dfd..698ac6fb8b6 100644 --- a/aws_lambda_powertools/tracing/tracer.py +++ b/aws_lambda_powertools/tracing/tracer.py @@ -55,6 +55,13 @@ class Tracer: `Env POWERTOOLS_TRACE_DISABLED="true"` patch_modules: Tuple[str] Tuple of modules supported by tracing provider to patch, by default all modules are patched + provider: BaseProvider + Tracing provider, by default it is aws_xray_sdk.core.xray_recorder + + Returns + ------- + Tracer + Tracer instance with imported modules patched Example ------- @@ -123,17 +130,12 @@ def handler(event: dict, context: Any) -> Dict: tracer = Tracer() ... - Returns - ------- - Tracer - Tracer instance with imported modules patched - Limitations ----------- * Async handler not supported """ - _default_config = { + _default_config: Dict[str, Any] = { "service": "service_undefined", "disabled": False, "auto_patch": True, @@ -153,7 +155,7 @@ def __init__( self.__build_config( service=service, disabled=disabled, auto_patch=auto_patch, patch_modules=patch_modules, provider=provider ) - self.provider = self._config["provider"] + self.provider: BaseProvider = self._config["provider"] self.disabled = self._config["disabled"] self.service = self._config["service"] self.auto_patch = self._config["auto_patch"] From c2b243e999774365287cc8eb46555d20c2631e1a Mon Sep 17 00:00:00 2001 From: Michael Brewer Date: Wed, 17 Mar 2021 07:28:52 -0700 Subject: [PATCH 2/3] chore: Remove BaseProvider type hint --- aws_lambda_powertools/tracing/tracer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aws_lambda_powertools/tracing/tracer.py b/aws_lambda_powertools/tracing/tracer.py index 698ac6fb8b6..54d61cca065 100644 --- a/aws_lambda_powertools/tracing/tracer.py +++ b/aws_lambda_powertools/tracing/tracer.py @@ -155,7 +155,7 @@ def __init__( self.__build_config( service=service, disabled=disabled, auto_patch=auto_patch, patch_modules=patch_modules, provider=provider ) - self.provider: BaseProvider = self._config["provider"] + self.provider = self._config["provider"] self.disabled = self._config["disabled"] self.service = self._config["service"] self.auto_patch = self._config["auto_patch"] From 2492b76f1a66b2e6c44dc1996c6791f75401cdd7 Mon Sep 17 00:00:00 2001 From: Michael Brewer Date: Wed, 17 Mar 2021 07:30:34 -0700 Subject: [PATCH 3/3] chore: on second thoughts.. --- aws_lambda_powertools/tracing/tracer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aws_lambda_powertools/tracing/tracer.py b/aws_lambda_powertools/tracing/tracer.py index 54d61cca065..698ac6fb8b6 100644 --- a/aws_lambda_powertools/tracing/tracer.py +++ b/aws_lambda_powertools/tracing/tracer.py @@ -155,7 +155,7 @@ def __init__( self.__build_config( service=service, disabled=disabled, auto_patch=auto_patch, patch_modules=patch_modules, provider=provider ) - self.provider = self._config["provider"] + self.provider: BaseProvider = self._config["provider"] self.disabled = self._config["disabled"] self.service = self._config["service"] self.auto_patch = self._config["auto_patch"]