Skip to content

Commit b61cafa

Browse files
committed
docs: remove changes; add in PR description
1 parent f89d572 commit b61cafa

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

docs/utilities/feature_flags.md

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -55,21 +55,3 @@ By default, this utility provides AWS AppConfig as a configuration store. As suc
5555
## Testing your code
5656

5757
> NOTE: Share example on how customers can unit test their feature flags
58-
59-
## Changes
60-
61-
Potential changes to be validated when docs are in a better shape
62-
63-
- [x] ~~`rules_context` to `context`~~
64-
- [x] `ConfigurationStore` to `FeatureFlags`
65-
- [x] `StoreProvider` to `StoreProvider`
66-
- [x] ~~Use `base.py` for interfaces for consistency (e.g. Metrics, Tracer, etc.)~~
67-
- [x] ~~AppConfig construct parameter names for consistency (e.g. `configuration_name` -> `name`, `service` -> `application`)~~
68-
- [x] ~~Rename `value_if_missing` param to `default` to match Python consistency (e.g. `os.getenv("VAR", default=False)`)~~
69-
- [x] ~~Rename `get_feature` to `evaluate`~~
70-
- [x] ~~Rename `get_all_enabled_feature_toggles` to `get_enabled_features`~~
71-
- [x] ~~Review redundant logging~~
72-
- [ ] Some docstrings and logger refer to AWS AppConfig only (outdated given StoreProvider)
73-
- [ ] Review why we're testing a private method(`is_rule_matched`)
74-
- [ ] Review `get_configuration`, `get_json_configuration`
75-
- [ ] Consider fine grained ConfigurationError instead of a single ConfigurationError

0 commit comments

Comments
 (0)