fix: Reanable test

Author: Michael Brewer

aws_lambda_powertools/utilities/idempotency/__init__.py

@@ -5,6 +5,6 @@
 from aws_lambda_powertools.utilities.idempotency.persistence.base import BasePersistenceLayer
 from aws_lambda_powertools.utilities.idempotency.persistence.dynamodb import DynamoDBPersistenceLayer
 
-from .idempotency import idempotent
+from .idempotency import IdempotencyConfig, idempotent
 
-__all__ = ("DynamoDBPersistenceLayer", "BasePersistenceLayer", "idempotent")
+__all__ = ("DynamoDBPersistenceLayer", "BasePersistenceLayer", "idempotent", "IdempotencyConfig")

aws_lambda_powertools/utilities/idempotency/persistence/base.py

@@ -9,19 +9,19 @@
 import warnings
 from abc import ABC, abstractmethod
 from types import MappingProxyType
-from typing import Any, Dict
+from typing import Any, Dict, Optional
 
 import jmespath
 
 from aws_lambda_powertools.shared.cache_dict import LRUDict
 from aws_lambda_powertools.shared.json_encoder import Encoder
+from aws_lambda_powertools.utilities.idempotency.config import IdempotencyConfig
 from aws_lambda_powertools.utilities.idempotency.exceptions import (
     IdempotencyInvalidStatusError,
     IdempotencyItemAlreadyExistsError,
     IdempotencyKeyError,
     IdempotencyValidationError,
 )
-from aws_lambda_powertools.utilities.idempotency.idempotency import IdempotencyConfig
 
 logger = logging.getLogger(__name__)
 
@@ -108,14 +108,16 @@ class BasePersistenceLayer(ABC):
     """
 
     def __init__(self):
-        self.event_key_jmespath = None
+        self.configured = False
+
+        self.event_key_jmespath: Optional[str] = None
         self.event_key_compiled_jmespath = None
-        self.payload_validation_enabled = None
+        self.payload_validation_enabled = False
         self.validation_key_jmespath = None
-        self.raise_on_no_idempotency_key = None
+        self.raise_on_no_idempotency_key = False
         self.expires_after_seconds = None
-        self.use_local_cache = None
-        self._cache = None
+        self.use_local_cache = False
+        self._cache: Optional[LRUDict] = None
         self.hash_function = None
 
     def configure(self, config: IdempotencyConfig,) -> None:
@@ -127,10 +129,13 @@ def configure(self, config: IdempotencyConfig,) -> None:
         config: IdempotencyConfig
             Configuration settings
         """
+        if self.configured:
+            # Temp hack to prevent being reconfigured.
+            return
+        self.configured = True
         self.event_key_jmespath = config.event_key_jmespath
-        if self.event_key_jmespath:
+        if config.event_key_jmespath:
             self.event_key_compiled_jmespath = jmespath.compile(config.event_key_jmespath)
-        self.payload_validation_enabled = False
         if config.payload_validation_jmespath:
             self.validation_key_jmespath = jmespath.compile(config.payload_validation_jmespath)
             self.payload_validation_enabled = True

tests/functional/idempotency/conftest.py

@@ -152,7 +152,7 @@ def hashed_validation_key(lambda_apigw_event):
 
 @pytest.fixture
 def persistence_store(config):
-    return DynamoDBPersistenceLayer(table_name=TABLE_NAME, boto_config=config,)
+    return DynamoDBPersistenceLayer(table_name=TABLE_NAME, boto_config=config)
 
 
 @pytest.fixture

tests/functional/idempotency/test_idempotency.py

@@ -207,6 +207,53 @@ def lambda_handler(event, context):
     stubber.deactivate()
 
 
+@pytest.mark.skipif(sys.version_info < (3, 8), reason="issue with pytest mock lib for < 3.8")
+@pytest.mark.parametrize("idempotency_config", [{"use_local_cache": True}], indirect=True)
+def test_idempotent_lambda_first_execution_cached(
+    idempotency_config,
+    persistence_store,
+    lambda_apigw_event,
+    expected_params_update_item,
+    expected_params_put_item,
+    lambda_response,
+    hashed_idempotency_key,
+    mocker,
+):
+    """
+    Test idempotent decorator when lambda is executed with an event with a previously unknown event key. Ensure
+    result is cached locally on the persistence store instance.
+    """
+    persistence_store.configure(idempotency_config)
+    save_to_cache_spy = mocker.spy(persistence_store, "_save_to_cache")
+    retrieve_from_cache_spy = mocker.spy(persistence_store, "_retrieve_from_cache")
+    stubber = stub.Stubber(persistence_store.table.meta.client)
+    ddb_response = {}
+
+    stubber.add_response("put_item", ddb_response, expected_params_put_item)
+    stubber.add_response("update_item", ddb_response, expected_params_update_item)
+    stubber.activate()
+
+    @idempotent(persistence_store=persistence_store, config=idempotency_config)
+    def lambda_handler(event, context):
+        return lambda_response
+
+    lambda_handler(lambda_apigw_event, {})
+
+    retrieve_from_cache_spy.assert_called_once()
+    save_to_cache_spy.assert_called_once()
+    assert save_to_cache_spy.call_args[0][0].status == "COMPLETED"
+    assert persistence_store._cache.get(hashed_idempotency_key).status == "COMPLETED"
+
+    # This lambda call should not call AWS API
+    lambda_handler(lambda_apigw_event, {})
+    assert retrieve_from_cache_spy.call_count == 3
+    retrieve_from_cache_spy.assert_called_with(idempotency_key=hashed_idempotency_key)
+
+    # This assertion fails if an AWS API operation was called more than once
+    stubber.assert_no_pending_responses()
+    stubber.deactivate()
+
+
 @pytest.mark.parametrize("idempotency_config", [{"use_local_cache": False}, {"use_local_cache": True}], indirect=True)
 def test_idempotent_lambda_expired(
     idempotency_config,