Skip to content

Commit b279a3a

Browse files
committed
fix: set defaults to None
1 parent 880b71a commit b279a3a

File tree

2 files changed

+23
-23
lines changed

2 files changed

+23
-23
lines changed

aws_lambda_powertools/utilities/data_classes/shared_functions.py

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from __future__ import annotations
22

33
import base64
4-
from typing import Any, Dict, List, Optional, overload
4+
from typing import Any, overload
55

66

77
def base64_decode(value: str) -> str:
@@ -26,31 +26,31 @@ def get_header_value(
2626
headers: dict[str, Any],
2727
name: str,
2828
default_value: str,
29-
case_sensitive: bool,
29+
case_sensitive: bool | None = None,
3030
) -> str: ...
3131

3232

3333
@overload
3434
def get_header_value(
3535
headers: dict[str, Any],
3636
name: str,
37-
default_value: Optional[str],
38-
case_sensitive: bool,
39-
) -> Optional[str]: ...
37+
default_value: str | None = None,
38+
case_sensitive: bool | None = None,
39+
) -> str | None: ...
4040

4141

4242
def get_header_value(
4343
headers: dict[str, Any],
4444
name: str,
45-
default_value: Optional[str],
46-
case_sensitive: bool,
47-
) -> Optional[str]:
45+
default_value: str | None = None,
46+
case_sensitive: bool | None = None,
47+
) -> str | None:
4848
"""
4949
Get the value of a header by its name.
5050
5151
Parameters
5252
----------
53-
headers: Dict[str, str]
53+
headers: dict[str, str]
5454
The dictionary of headers.
5555
name: str
5656
The name of the header to retrieve.
@@ -82,25 +82,25 @@ def get_header_value(
8282

8383
@overload
8484
def get_query_string_value(
85-
query_string_parameters: Dict[str, str] | None,
85+
query_string_parameters: dict[str, str] | None,
8686
name: str,
8787
default_value: str,
8888
) -> str: ...
8989

9090

9191
@overload
9292
def get_query_string_value(
93-
query_string_parameters: Dict[str, str] | None,
93+
query_string_parameters: dict[str, str] | None,
9494
name: str,
95-
default_value: Optional[str] = None,
96-
) -> Optional[str]: ...
95+
default_value: str | None = None,
96+
) -> str | None: ...
9797

9898

9999
def get_query_string_value(
100-
query_string_parameters: Dict[str, str] | None,
100+
query_string_parameters: dict[str, str] | None,
101101
name: str,
102-
default_value: Optional[str] = None,
103-
) -> Optional[str]:
102+
default_value: str | None = None,
103+
) -> str | None:
104104
"""
105105
Retrieves the value of a query string parameter specified by the given name.
106106
@@ -121,23 +121,23 @@ def get_query_string_value(
121121

122122

123123
def get_multi_value_query_string_values(
124-
multi_value_query_string_parameters: Dict[str, List[str]] | None,
124+
multi_value_query_string_parameters: dict[str, list[str]] | None,
125125
name: str,
126-
default_values: Optional[List[str]] = None,
127-
) -> List[str]:
126+
default_values: list[str] | None = None,
127+
) -> list[str]:
128128
"""
129129
Retrieves the values of a multi-value string parameters specified by the given name.
130130
131131
Parameters
132132
----------
133133
name: str
134134
The name of the query string parameter to retrieve.
135-
default_value: List[str], optional
135+
default_value: list[str], optional
136136
The default value to return if the parameter is not found. Defaults to None.
137137
138138
Returns
139139
-------
140-
List[str]. optional
140+
list[str]. optional
141141
The values of the query string parameter if found, or the default values if not found.
142142
"""
143143

examples/event_handler_graphql/src/custom_models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ class Location(TypedDict, total=False):
2626
class MyCustomModel(AppSyncResolverEvent):
2727
@property
2828
def country_viewer(self) -> str:
29-
return self.get_header_value(name="cloudfront-viewer-country", default_value="", case_sensitive=False) # type: ignore[return-value] # sentinel typing # noqa: E501
29+
return self.get_header_value(name="cloudfront-viewer-country", default_value="", case_sensitive=False)
3030

3131
@property
3232
def api_key(self) -> str:
33-
return self.get_header_value(name="x-api-key", default_value="", case_sensitive=False) # type: ignore[return-value] # sentinel typing # noqa: E501
33+
return self.get_header_value(name="x-api-key", default_value="", case_sensitive=False)
3434

3535

3636
@app.resolver(type_name="Query", field_name="listLocations")

0 commit comments

Comments
 (0)