Add missing tests

Author: Michal Ploski

tests/functional/idempotency/test_idempotency.py

@@ -648,6 +648,29 @@ def test_data_record_invalid_status_value():
     assert e.value.args[0] == "UNSUPPORTED_STATUS"
 
 
+def test_data_record_json_to_dict_mapping():
+    # GIVEN a data record with status "COMPLETED" and provided response data
+    data_record = DataRecord(
+        "key", status="INPROGRESS", response_data='{"body": "execution finished","statusCode": "200"}'
+    )
+
+    # WHEN translating response data to dictionary
+    response_data = data_record.response_json_as_dict()
+
+    # THEN return dictionary
+    assert isinstance(response_data, dict)
+
+
+def test_data_record_json_to_dict_mapping_when_response_data_none():
+    # GIVEN a data record with status "INPROGRESS" and not set response data
+    data_record = DataRecord("key", status="INPROGRESS", response_data=None)
+    # WHEN translating response data to dictionary
+    response_data = data_record.response_json_as_dict()
+
+    # THEN return null value
+    assert response_data is None
+
+
 @pytest.mark.parametrize("idempotency_config", [{"use_local_cache": True}], indirect=True)
 def test_in_progress_never_saved_to_cache(
     idempotency_config: IdempotencyConfig, persistence_store: DynamoDBPersistenceLayer

tests/functional/test_metrics.py

@@ -493,9 +493,29 @@ def lambda_handler(evt, context):
 
     output = capture_metrics_output(capsys)
 
+    # THEN ColdStart metric and function_name and service dimension should be logged
+    assert output["ColdStart"] == [1.0]
+    assert output["function_name"] == "example_fn"
+    assert output['service'] == service
+
+def test_log_metrics_capture_cold_start_metric_no_service(capsys, namespace):
+    # GIVEN Metrics is initialized without service
+    my_metrics = Metrics(namespace=namespace)
+
+    # WHEN log_metrics is used with capture_cold_start_metric
+    @my_metrics.log_metrics(capture_cold_start_metric=True)
+    def lambda_handler(evt, context):
+        pass
+
+    LambdaContext = namedtuple("LambdaContext", "function_name")
+    lambda_handler({}, LambdaContext("example_fn"))
+
+    output = capture_metrics_output(capsys)
+
     # THEN ColdStart metric and function_name dimension should be logged
     assert output["ColdStart"] == [1.0]
     assert output["function_name"] == "example_fn"
+    assert output.get('service') is None
 
 
 def test_emit_cold_start_metric_only_once(capsys, namespace, service, metric):