Skip to content

Commit 9c7324b

Browse files
committed
fix: include proposed suggestions
1 parent 48a7687 commit 9c7324b

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

aws_lambda_powertools/utilities/batch/base.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@
99

1010

1111
class BaseProcessor(ABC):
12-
13-
# init with lambda's context ?
14-
1512
@abstractmethod
1613
def _prepare(self):
1714
"""

aws_lambda_powertools/utilities/batch/sqs.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from .base import BasePartialProcessor
1414

1515

16-
class BasePartialSQSProcessor(BasePartialProcessor):
16+
class PartialSQSProcessor(BasePartialProcessor):
1717
def __init__(self):
1818
self._client = boto3.client("sqs")
1919
self.success_messages: List = []
@@ -44,7 +44,8 @@ def _prepare(self):
4444
def _clean(self):
4545
"""
4646
"""
47-
if not self.fail_messages:
47+
# skip only failures or only successes
48+
if not (self.fail_messages and self.success_messages):
4849
return
4950

5051
queue_url = self.get_queue_url()
@@ -53,14 +54,12 @@ def _clean(self):
5354
return self._client.delete_message_batch(QueueUrl=queue_url, Entries=entries_to_remove)
5455

5556

56-
class DefaultPartialSQSProcessor(BasePartialSQSProcessor):
57-
pass
58-
59-
6057
@lambda_handler_decorator
6158
def partial_sqs_processor(handler, event, context, record_handler, processor=None):
6259
records = event["Records"]
63-
processor = processor or DefaultPartialSQSProcessor()
60+
processor = processor or PartialSQSProcessor()
6461

6562
with processor(records, record_handler) as ctx:
6663
ctx.process()
64+
65+
return handler(event, context)

0 commit comments

Comments
 (0)