refactor(store): use get_configuration over get_json_configuration

Author: heitorlessa

aws_lambda_powertools/utilities/feature_flags/appconfig.py

@@ -54,7 +54,7 @@ def __init__(
         self.jmespath_options = jmespath_options
         self._conf_store = AppConfigProvider(environment=environment, application=application, config=config)
 
-    def get_json_configuration(self) -> Dict[str, Any]:
+    def get_configuration(self) -> Dict[str, Any]:
         """Get configuration string from AWS AppConfig and return the parsed JSON dictionary
 
         Raises

aws_lambda_powertools/utilities/feature_flags/base.py

@@ -4,7 +4,7 @@
 
 class StoreProvider(ABC):
     @abstractmethod
-    def get_json_configuration(self) -> Dict[str, Any]:
+    def get_configuration(self) -> Dict[str, Any]:
         """Get configuration string from any configuration storing application and return the parsed JSON dictionary
 
         Raises

aws_lambda_powertools/utilities/feature_flags/feature_flags.py

@@ -116,7 +116,7 @@ def get_configuration(self) -> Union[Dict[str, Dict], Dict]:
             }
         """
         # parse result conf as JSON, keep in cache for self.max_age seconds
-        config = self._store.get_json_configuration()
+        config = self._store.get_configuration()
 
         validator = schema.SchemaValidator(schema=config)
         validator.validate()

tests/functional/feature_toggles/test_feature_toggles.py

@@ -415,9 +415,9 @@ def test_app_config_get_parameter_err(mocker, config):
     # GIVEN an appconfig with a missing config
     app_conf_fetcher = init_fetcher_side_effect(mocker, config, GetParameterError())
 
-    # WHEN calling get_json_configuration
+    # WHEN calling get_configuration
     with pytest.raises(ConfigurationError) as err:
-        app_conf_fetcher.get_json_configuration()
+        app_conf_fetcher.get_configuration()
 
     # THEN raise ConfigurationError error
     assert "AWS AppConfig configuration" in str(err.value)