chore(ci): refactor inline gh-script to file

Author: heitorlessa

.github/scripts/label_missing_related_issue.js

@@ -0,0 +1,28 @@
+module.exports = async ({github, context, core}) => {
+    const prBody = process.env.PR_BODY;
+    const prNumber = process.env.PR_NUMBER;
+    const blockLabel = process.env.BLOCK_LABEL;
+    const blockReasonLabel = process.env.BLOCK_REASON_LABEL;
+
+    const RELATED_ISSUE_REGEX = /Issue number:[^\d\r\n]+(?<issue>\d+)/;
+
+    const isMatch = RELATED_ISSUE_REGEX.exec(prBody);
+    if (isMatch == null) {
+        core.info(`No related issue found, maybe the author didn't use the template but there is one.`)
+
+        let msg = "No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.";
+        await github.rest.issues.createComment({
+          owner: context.repo.owner,
+          repo: context.repo.repo,
+          body: msg,
+          issue_number: prNumber,
+        });
+
+        return await github.rest.issues.addLabels({
+          issue_number: prNumber,
+          owner: context.repo.owner,
+          repo: context.repo.repo,
+          labels: [blockLabel, blockReasonLabel]
+        })
+    }
+}

.github/workflows/on_opened_pr.yml

@@ -1,4 +1,4 @@
-name: On PR opened
+name: On PR open
 
 on:
   workflow_run:
@@ -9,8 +9,8 @@ on:
 env:
   BLOCK_LABEL: "do-not-merge"
   BLOCK_REASON_LABEL: "need-issue"
+  IGNORE_AUTHORS: '["dependabot[bot]", "markdownify[bot]"]'
 
-# TODO: include markdownify author too
 jobs:
   get_pr_details:
     if: ${{ github.event.workflow_run.conclusion == 'success' }}
@@ -22,41 +22,19 @@ jobs:
   check_related_issue:
     needs: get_pr_details
     if: >
-      ${{ needs.get_pr_details.outputs.prAuthor != 'dependabot[bot]' &&
-          needs.get_pr_details.outputs.prAction == 'opened'
+      ${{ needs.get_pr_details.outputs.prAction == 'opened' &&
+          contains(fromJson(env.IGNORE_AUTHORS), needs.get_pr_details.outputs.prAuthor) != true
       }}
     runs-on: ubuntu-latest
     steps:
+      - uses: actions/checkout@v3
       - name: "Ensure related issue is present"
         uses: actions/github-script@v6
+        env:
+          PR_BODY: ${{ needs.get_pr_details.outputs.prBody }}
+          PR_NUMBER: ${{ needs.get_pr_details.outputs.prNumber }}
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
-          # Maintenance: convert into a standalone JS like post_release.js
           script: |
-            const prBody = "${{ needs.get_pr_details.outputs.prBody }}";
-            const prNumber = ${{ needs.get_pr_details.outputs.prNumber }};
-            const blockLabel = process.env.BLOCK_LABEL;
-            const blockReasonLabel = process.env.BLOCK_REASON_LABEL;
-
-            const RELATED_ISSUE_REGEX = /Issue number:.+(\d)/
-
-            const matcher = new RegExp(RELATED_ISSUE_REGEX)
-            const isMatch = matcher.exec(prBody)
-            if (isMatch == null) {
-                console.info(`No related issue found, maybe the author didn't use the template but there is one.`)
-
-                let msg = "No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.";
-                await github.rest.issues.createComment({
-                  owner: context.repo.owner,
-                  repo: context.repo.repo,
-                  body: msg,
-                  issue_number: prNumber,
-                });
-
-                await github.rest.issues.addLabels({
-                  issue_number: prNumber,
-                  owner: context.repo.owner,
-                  repo: context.repo.repo,
-                  labels: [blockLabel, blockReasonLabel]
-                })
-            }
+            const script = require('.github/scripts/label_missing_related_issue.js')
+            await script({github, context, core})