Skip to content

Commit 7756d2c

Browse files
committed
fix: failure handler record types
1 parent 4c95d39 commit 7756d2c

File tree

1 file changed

+4
-4
lines changed
  • aws_lambda_powertools/utilities/batch

1 file changed

+4
-4
lines changed

aws_lambda_powertools/utilities/batch/base.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -236,12 +236,12 @@ def _process_record(self, record: dict) -> Union[SuccessCallback, FailureCallbac
236236
record: dict
237237
A batch record to be processed.
238238
"""
239+
data = self._to_batch_type(record=record, event_type=self.event_type, model=self.model)
239240
try:
240-
data = self._to_batch_type(record=record, event_type=self.event_type, model=self.model)
241241
result = self.handler(record=data)
242242
return self.success_handler(record=record, result=result)
243243
except Exception:
244-
return self.failure_handler(record=record, exception=sys.exc_info())
244+
return self.failure_handler(record=data, exception=sys.exc_info())
245245

246246
def _clean(self):
247247
"""
@@ -268,7 +268,7 @@ def _get_messages_to_report(self) -> Dict[str, str]:
268268
return self._COLLECTOR_MAPPING[self.event_type]()
269269

270270
def _collect_sqs_failures(self):
271-
return {"itemIdentifier": msg.messageId for msg in self.fail_messages}
271+
return {"itemIdentifier": msg.message_id for msg in self.fail_messages}
272272

273273
def _collect_kinesis_failures(self):
274274
return {"itemIdentifier": msg.kinesis.sequence_number for msg in self.fail_messages}
@@ -285,7 +285,7 @@ def _to_batch_type(self, record: dict, event_type: EventType) -> EventSourceData
285285
...
286286

287287
def _to_batch_type(self, record: dict, event_type: EventType, model: Optional["BatchTypeModels"] = None):
288-
if model:
288+
if model is not None:
289289
return model.parse_obj(record)
290290
else:
291291
return self._DATA_CLASS_MAPPING[event_type](record)

0 commit comments

Comments
 (0)