Skip to content

Commit 592d9da

Browse files
committed
chore(tests): remove typing isues
1 parent 19eaa73 commit 592d9da

File tree

1 file changed

+19
-20
lines changed

1 file changed

+19
-20
lines changed

tests/functional/event_handler/test_api_middlewares.py

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
APIGatewayHttpResolver,
88
ApiGatewayResolver,
99
APIGatewayRestResolver,
10-
BaseRouter,
1110
ProxyEventType,
1211
Response,
1312
Router,
@@ -35,17 +34,17 @@
3534
(APIGatewayHttpResolver(), API_RESTV2_EVENT),
3635
],
3736
)
38-
def test_route_with_middleware(app: BaseRouter, event):
37+
def test_route_with_middleware(app: ApiGatewayResolver, event):
3938
# define custom middleware to inject new argument - "custom"
40-
def middleware_1(app: BaseRouter, next_middleware: NextMiddleware):
39+
def middleware_1(app: ApiGatewayResolver, next_middleware: NextMiddleware):
4140
# add additional data to Router Context
4241
app.append_context(custom="custom")
4342
response = next_middleware(app)
4443

4544
return response
4645

4746
# define custom middleware to inject new argument - "another_one"
48-
def middleware_2(app: BaseRouter, next_middleware: NextMiddleware):
47+
def middleware_2(app: ApiGatewayResolver, next_middleware: NextMiddleware):
4948
# add additional data to Router Context
5049
app.append_context(another_one=6)
5150
response = next_middleware(app)
@@ -90,17 +89,17 @@ def get_lambda() -> Response:
9089
),
9190
],
9291
)
93-
def test_with_router_middleware(app: BaseRouter, event, other_event):
92+
def test_with_router_middleware(app: ApiGatewayResolver, event, other_event):
9493
# define custom middleware to inject new argument - "custom"
95-
def global_middleware(app: BaseRouter, next_middleware: NextMiddleware):
94+
def global_middleware(app: ApiGatewayResolver, next_middleware: NextMiddleware):
9695
# add custom data to context
9796
app.append_context(custom="custom")
9897
response = next_middleware(app)
9998

10099
return response
101100

102101
# define custom middleware to inject new argument - "another_one"
103-
def middleware_2(app: BaseRouter, next_middleware: NextMiddleware):
102+
def middleware_2(app: ApiGatewayResolver, next_middleware: NextMiddleware):
104103
# add data to resolver context
105104
app.append_context(another_one=6)
106105
response = next_middleware(app)
@@ -150,8 +149,8 @@ def get_other_lambda() -> Response:
150149
(APIGatewayHttpResolver(), API_RESTV2_EVENT),
151150
],
152151
)
153-
def test_dynamic_route_with_middleware(app: BaseRouter, event):
154-
def middleware_one(app: BaseRouter, next_middleware: NextMiddleware):
152+
def test_dynamic_route_with_middleware(app: ApiGatewayResolver, event):
153+
def middleware_one(app: ApiGatewayResolver, next_middleware: NextMiddleware):
155154
# inject data into the resolver context
156155
app.append_context(injected="injected_value")
157156
response = next_middleware(app)
@@ -182,20 +181,20 @@ def get_lambda(my_id: str, name: str) -> Response:
182181
(APIGatewayHttpResolver(), API_RESTV2_EVENT),
183182
],
184183
)
185-
def test_middleware_early_return(app: BaseRouter, event):
186-
def middleware_one(app: BaseRouter, next_middleware):
184+
def test_middleware_early_return(app: ApiGatewayResolver, event):
185+
def middleware_one(app: ApiGatewayResolver, next_middleware):
187186
# inject a variable into resolver context
188187
app.append_context(injected="injected_value")
189188
response = next_middleware(app)
190189

191190
return response
192191

193-
def early_return_middleware(app: BaseRouter, next_middleware: NextMiddleware):
192+
def early_return_middleware(app: ApiGatewayResolver, next_middleware: NextMiddleware):
194193
assert app.context.get("injected") == "injected_value"
195194

196195
return Response(400, content_types.TEXT_HTML, "bad_response")
197196

198-
def not_executed_middleware(app: BaseRouter, next_middleware: NextMiddleware):
197+
def not_executed_middleware(app: ApiGatewayResolver, next_middleware: NextMiddleware):
199198
# This should never be executed - if it is an excpetion will be raised
200199
raise NotImplementedError()
201200

@@ -231,7 +230,7 @@ def get_lambda(my_id: str, name: str) -> Response:
231230
),
232231
],
233232
)
234-
def test_pass_schema_validation(app: BaseRouter, event, validation_schema):
233+
def test_pass_schema_validation(app: ApiGatewayResolver, event, validation_schema):
235234
@app.post("/my/path", middlewares=[SchemaValidationMiddleware(validation_schema)])
236235
def post_lambda() -> Response:
237236
return Response(200, content_types.TEXT_HTML, "path")
@@ -261,7 +260,7 @@ def post_lambda() -> Response:
261260
),
262261
],
263262
)
264-
def test_fail_schema_validation(app: BaseRouter, event, validation_schema):
263+
def test_fail_schema_validation(app: ApiGatewayResolver, event, validation_schema):
265264
@app.post("/my/path", middlewares=[SchemaValidationMiddleware(validation_schema)])
266265
def post_lambda() -> Response:
267266
return Response(200, content_types.TEXT_HTML, "Should not be returned")
@@ -295,7 +294,7 @@ def post_lambda() -> Response:
295294
),
296295
],
297296
)
298-
def test_invalid_schema_validation(app: BaseRouter, event):
297+
def test_invalid_schema_validation(app: ApiGatewayResolver, event):
299298
@app.post("/my/path", middlewares=[SchemaValidationMiddleware(inbound_schema="schema.json")])
300299
def post_lambda() -> Response:
301300
return Response(200, content_types.TEXT_HTML, "Should not be returned")
@@ -317,20 +316,20 @@ def post_lambda() -> Response:
317316
(APIGatewayHttpResolver(), API_RESTV2_EVENT),
318317
],
319318
)
320-
def test_middleware_short_circuit_via_httperrors(app: BaseRouter, event):
321-
def middleware_one(app: BaseRouter, next_middleware: NextMiddleware):
319+
def test_middleware_short_circuit_via_httperrors(app: ApiGatewayResolver, event):
320+
def middleware_one(app: ApiGatewayResolver, next_middleware: NextMiddleware):
322321
# inject a variable into the kwargs of the middleware chain
323322
app.append_context(injected="injected_value")
324323
response = next_middleware(app)
325324

326325
return response
327326

328-
def early_return_middleware(app: BaseRouter, next_middleware: NextMiddleware):
327+
def early_return_middleware(app: ApiGatewayResolver, next_middleware: NextMiddleware):
329328
# ensure "injected" context variable is passed in by middleware_one
330329
assert app.context.get("injected") == "injected_value"
331330
raise BadRequestError("bad_response")
332331

333-
def not_executed_middleware(app: BaseRouter, next_middleware: NextMiddleware):
332+
def not_executed_middleware(app: ApiGatewayResolver, next_middleware: NextMiddleware):
334333
# This should never be executed - if it is an excpetion will be raised
335334
raise NotImplementedError()
336335

0 commit comments

Comments
 (0)