chore: apply suggestions from code review

Co-authored-by: Heitor Lessa <lessa@amazon.com>

Author: rubenfonseca

.github/workflows/publish_v2_layer.yml

@@ -9,7 +9,7 @@ on:
     inputs:
       latest_published_version:
         description: "Latest PyPi published version to rebuild latest docs for, e.g. v1.22.0"
-        default: "v1.22.0"
+        default: "v2.0.0"
         required: true
   # workflow_run:
   #   workflows: ["Publish to PyPi"]

Makefile

@@ -6,12 +6,12 @@ target:
 
 dev:
 	pip install --upgrade pip pre-commit poetry
-	poetry install --extras "extras"
+	poetry install --extras "all"
 	pre-commit install
 
 dev-gitpod:
 	pip install --upgrade pip poetry
-	poetry install --extras "extras"
+	poetry install --extras "all"
 	pre-commit install
 
 format:

layer/app.py

@@ -9,7 +9,7 @@
 
 POWERTOOLS_VERSION: str = app.node.try_get_context("version")
 SSM_PARAM_LAYER_ARN: str = "/layers/powertools-layer-v2-arn"
-SSM_PARAM_ARM64_LAYER_ARN: str = "/layers/powertools-layer-v2-arm64-arn"
+SSM_PARAM_LAYER_ARM64_ARN: str = "/layers/powertools-layer-v2-arm64-arn"
 
 if not POWERTOOLS_VERSION:
     raise ValueError(
@@ -22,15 +22,15 @@
     "LayerStack",
     powertools_version=POWERTOOLS_VERSION,
     ssm_paramter_layer_arn=SSM_PARAM_LAYER_ARN,
-    ssm_parameter_arm64_layer_arn=SSM_PARAM_ARM64_LAYER_ARN,
+    ssm_parameter_layer_arm64_arn=SSM_PARAM_LAYER_ARM64_ARN,
 )
 
 CanaryStack(
     app,
     "CanaryStack",
     powertools_version=POWERTOOLS_VERSION,
     ssm_paramter_layer_arn=SSM_PARAM_LAYER_ARN,
-    ssm_parameter_arm64_layer_arn=SSM_PARAM_ARM64_LAYER_ARN,
+    ssm_parameter_layer_arm64_arn=SSM_PARAM_LAYER_ARM64_ARN,
 )
 
 app.synth()

layer/layer/canary/app.py

@@ -67,7 +67,7 @@ def verify_powertools_version() -> None:
     current_version = version("aws_lambda_powertools")
     if powertools_version != current_version:
         raise ValueError(
-            f'Expected powertools version is "{powertools_version}", but layer contains version "{current_version}"'
+            f'Expected Powertools version is "{powertools_version}", but layer contains version "{current_version}"'
         )
     logger.info(f"Current Powertools version is: {current_version}")
 

layer/layer/canary_stack.py

@@ -20,7 +20,7 @@ def __init__(
         construct_id: str,
         powertools_version: str,
         ssm_paramter_layer_arn: str,
-        ssm_parameter_arm64_layer_arn: str,
+        ssm_parameter_layer_arm64_arn: str,
         **kwargs,
     ) -> None:
         super().__init__(scope, construct_id, **kwargs)
@@ -39,7 +39,7 @@ def __init__(
         layer_arm64_arn = StringParameter.from_string_parameter_attributes(
             self,
             "LayerArm64VersionArnParam",
-            parameter_name=ssm_parameter_arm64_layer_arn,
+            parameter_name=ssm_parameter_layer_arm64_arn,
         ).string_value
         Canary(
             self,
@@ -94,7 +94,7 @@ def __init__(
             layers=[layer],
             memory_size=512,
             timeout=Duration.seconds(10),
-            runtime=Runtime.PYTHON_3_9(),
+            runtime=Runtime.PYTHON_3_9,
             architecture=architecture,
             log_retention=RetentionDays.ONE_MONTH,
             role=execution_role,

layer/layer/layer_stack.py

@@ -12,7 +12,7 @@ def __init__(
         construct_id: str,
         powertools_version: str,
         ssm_paramter_layer_arn: str,
-        ssm_parameter_arm64_layer_arn: str,
+        ssm_parameter_layer_arm64_arn: str,
         **kwargs
     ) -> None:
         super().__init__(scope, construct_id, **kwargs)
@@ -66,9 +66,9 @@ def __init__(
         StringParameter(
             self,
             "Arm64VersionArn",
-            parameter_name=ssm_parameter_arm64_layer_arn,
+            parameter_name=ssm_parameter_layer_arm64_arn,
             string_value=layer_arm64.layer_version_arn,
         )
 
         CfnOutput(self, "LatestLayerArn", value=layer.layer_version_arn)
-        CfnOutput(self, "LatestArm64LayerArn", value=layer_arm64.layer_version_arn)
+        CfnOutput(self, "LatestLayerArm64Arn", value=layer_arm64.layer_version_arn)

pyproject.toml

@@ -76,8 +76,8 @@ filelock = "^3.8.0"
 checksumdir = "^1.2.0"
 
 [tool.poetry.extras]
-parser = ["pydantic", "email-validator"]
-validation = ["fastjsonschema"]
+parser = ["pydantic", "email-validator", "jmespath"]
+validation = ["fastjsonschema", "jmespath"]
 tracer = ["aws-xray-sdk"]
 all = ["pydantic", "email-validator", "aws-xray-sdk", "fastjsonschema"]