Skip to content

Commit 4846b77

Browse files
author
Michael Brewer
committed
test(data_classes): correct some of the unit tests
1 parent 51a9091 commit 4846b77

File tree

3 files changed

+24
-6
lines changed

3 files changed

+24
-6
lines changed

tests/events/cognitoPostAuthenticationEvent.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"request": {
1212
"newDeviceUsed": true,
1313
"userAttributes": {
14-
"email": "test@mail.com"
14+
"email": "post-auth@mail.com"
1515
}
1616
},
1717
"response": {}

tests/events/cognitoPreAuthenticationEvent.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"sub": "4A709A36-7D63-4785-829D-4198EF10EBDA",
1414
"email_verified": "true",
1515
"name": "First Last",
16-
"email": "test@mail.com"
16+
"email": "pre-auth@mail.com"
1717
}
1818
},
1919
"response": {}

tests/functional/test_lambda_trigger_events.py

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ def test_cloud_watch_trigger_event():
7272
def test_cognito_pre_signup_trigger_event():
7373
event = PreSignUpTriggerEvent(load_event("cognitoPreSignUpEvent.json"))
7474

75+
# Verify BaseTriggerEvent properties
7576
assert event.version == "string"
7677
assert event.trigger_source == "PreSignUp_SignUp"
7778
assert event.region == "us-east-1"
@@ -81,12 +82,13 @@ def test_cognito_pre_signup_trigger_event():
8182
assert caller_context.aws_sdk_version == "awsSdkVersion"
8283
assert caller_context.client_id == "clientId"
8384

85+
# Verify properties
8486
user_attributes = event.request.user_attributes
8587
assert user_attributes["email"] == "user@example.com"
86-
8788
assert event.request.validation_data is None
8889
assert event.request.client_metadata is None
8990

91+
# Verify setters
9092
event.response.auto_confirm_user = True
9193
assert event.response.auto_confirm_user is True
9294
event.response.auto_verify_phone = True
@@ -99,6 +101,8 @@ def test_cognito_pre_signup_trigger_event():
99101
def test_cognito_post_confirmation_trigger_event():
100102
event = PostConfirmationTriggerEvent(load_event("cognitoPostConfirmationEvent.json"))
101103

104+
assert event.trigger_source == "PostConfirmation_ConfirmSignUp"
105+
102106
user_attributes = event.request.user_attributes
103107
assert user_attributes["email"] == "user@example.com"
104108
assert event.request.client_metadata is None
@@ -107,6 +111,8 @@ def test_cognito_post_confirmation_trigger_event():
107111
def test_cognito_user_migration_trigger_event():
108112
event = UserMigrationTriggerEvent(load_event("cognitoUserMigrationEvent.json"))
109113

114+
assert event.trigger_source == "UserMigration_Authentication"
115+
110116
assert compare_digest(event.request.password, event["request"]["password"])
111117
assert event.request.validation_data is None
112118
assert event.request.client_metadata is None
@@ -132,6 +138,8 @@ def test_cognito_user_migration_trigger_event():
132138
def test_cognito_custom_message_trigger_event():
133139
event = CustomMessageTriggerEvent(load_event("cognitoCustomMessageEvent.json"))
134140

141+
assert event.trigger_source == "CustomMessage_AdminCreateUser"
142+
135143
assert event.request.code_parameter == "####"
136144
assert event.request.username_parameter == "username"
137145
assert event.request.user_attributes["phone_number_verified"] is False
@@ -148,24 +156,30 @@ def test_cognito_custom_message_trigger_event():
148156
def test_cognito_pre_authentication_trigger_event():
149157
event = PreAuthenticationTriggerEvent(load_event("cognitoPreAuthenticationEvent.json"))
150158

159+
assert event.trigger_source == "PreAuthentication_Authentication"
160+
151161
assert event.request.user_not_found is None
152162
event["request"]["userNotFound"] = True
153163
assert event.request.user_not_found is True
154-
assert event.request.user_attributes["email"] == "test@mail.com"
164+
assert event.request.user_attributes["email"] == "pre-auth@mail.com"
155165
assert event.request.validation_data is None
156166

157167

158168
def test_cognito_post_authentication_trigger_event():
159169
event = PostAuthenticationTriggerEvent(load_event("cognitoPostAuthenticationEvent.json"))
160170

171+
assert event.trigger_source == "PostAuthentication_Authentication"
172+
161173
assert event.request.new_device_used is True
162-
assert event.request.user_attributes["email"] == "test@mail.com"
174+
assert event.request.user_attributes["email"] == "post-auth@mail.com"
163175
assert event.request.client_metadata is None
164176

165177

166178
def test_cognito_pre_token_generation_trigger_event():
167179
event = PreTokenGenerationTriggerEvent(load_event("cognitoPreTokenGenerationEvent.json"))
168180

181+
assert event.trigger_source == "TokenGeneration_Authentication"
182+
169183
group_configuration = event.request.group_configuration
170184
assert group_configuration.groups_to_override == []
171185
assert group_configuration.iam_roles_to_override == []
@@ -215,6 +229,8 @@ def test_cognito_pre_token_generation_trigger_event():
215229
def test_cognito_define_auth_challenge_trigger_event():
216230
event = DefineAuthChallengeTriggerEvent(load_event("cognitoDefineAuthChallengeEvent.json"))
217231

232+
assert event.trigger_source == "DefineAuthChallenge_Authentication"
233+
218234
# Verify properties
219235
assert event.request.user_attributes["email"] == "define-auth@mail.com"
220236
assert event.request.user_not_found is True
@@ -241,6 +257,8 @@ def test_cognito_define_auth_challenge_trigger_event():
241257
def test_create_auth_challenge_trigger_event():
242258
event = CreateAuthChallengeTriggerEvent(load_event("cognitoCreateAuthChallengeEvent.json"))
243259

260+
assert event.trigger_source == "CreateAuthChallenge_Authentication"
261+
244262
# Verify properties
245263
assert event.request.user_attributes["email"] == "create-auth@mail.com"
246264
assert event.request.user_not_found is False
@@ -266,7 +284,7 @@ def test_create_auth_challenge_trigger_event():
266284
def test_verify_auth_challenge_response_trigger_event():
267285
event = VerifyAuthChallengeResponseTriggerEvent(load_event("cognitoVerifyAuthChallengeResponseEvent.json"))
268286

269-
event.trigger_source == ""
287+
assert event.trigger_source == "VerifyAuthChallengeResponse_Authentication"
270288

271289
# Verify properties
272290
assert event.request.user_attributes["email"] == "verify-auth@mail.com"

0 commit comments

Comments
 (0)