Skip to content

Commit 26c50df

Browse files
author
Michael Brewer
authored
chore: use isinstance over type
1 parent 5bddf70 commit 26c50df

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

tests/functional/test_logger_utils.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ def test_copy_config_to_ext_loggers(stdout, logger, log_level):
6767
# THEN all external loggers used Powertools handler, formatter and log level
6868
for index, logger in enumerate([logger_1, logger_2]):
6969
assert len(logger.handlers) == 1
70-
assert type(logger.handlers[0]) is logging.StreamHandler
71-
assert type(logger.handlers[0].formatter) is formatter.LambdaPowertoolsFormatter
70+
assert isinstance(logger.handlers[0], logging.StreamHandler)
71+
assert isinstance(logger.handlers[0].formatter, formatter.LambdaPowertoolsFormatter)
7272
assert logger.level == log_level.INFO.value
7373
assert logs[index]["message"] == msg
7474
assert logs[index]["level"] == log_level.INFO.name
@@ -88,8 +88,8 @@ def test_copy_config_to_ext_loggers_include(stdout, logger, log_level):
8888

8989
# THEN included external loggers used Powertools handler, formatter and log level.
9090
assert len(logger.handlers) == 1
91-
assert type(logger.handlers[0]) is logging.StreamHandler
92-
assert type(logger.handlers[0].formatter) is formatter.LambdaPowertoolsFormatter
91+
assert isinstance(logger.handlers[0], logging.StreamHandler)
92+
assert isinstance(logger.handlers[0].formatter, formatter.LambdaPowertoolsFormatter)
9393
assert logger.level == log_level.INFO.value
9494
assert log["message"] == msg
9595
assert log["level"] == log_level.INFO.name
@@ -138,8 +138,8 @@ def test_copy_config_to_ext_loggers_include_exclude(stdout, logger, log_level):
138138
# THEN logger_1 is not modified and Logger_2 used Powertools handler, formatter and log level
139139
assert not logger_1.handlers
140140
assert len(logger_2.handlers) == 1
141-
assert type(logger_2.handlers[0]) is logging.StreamHandler
142-
assert type(logger_2.handlers[0].formatter) is formatter.LambdaPowertoolsFormatter
141+
assert isinstance(logger_2.handlers[0], logging.StreamHandler)
142+
assert isinstance(logger_2.handlers[0].formatter, formatter.LambdaPowertoolsFormatter)
143143
assert logger_2.level == log_level.INFO.value
144144
assert log["message"] == msg
145145
assert log["level"] == log_level.INFO.name
@@ -157,8 +157,8 @@ def test_copy_config_to_ext_loggers_clean_old_handlers(stdout, logger, log_level
157157

158158
# THEN old logger's handler removed and Powertools configuration used instead
159159
assert len(logger.handlers) == 1
160-
assert type(logger.handlers[0]) is logging.StreamHandler
161-
assert type(logger.handlers[0].formatter) is formatter.LambdaPowertoolsFormatter
160+
assert isinstance(logger.handlers[0], logging.StreamHandler)
161+
assert isinstance(logger.handlers[0].formatter, formatter.LambdaPowertoolsFormatter)
162162

163163

164164
def test_copy_config_to_ext_loggers_custom_log_level(stdout, logger, log_level):
@@ -176,8 +176,8 @@ def test_copy_config_to_ext_loggers_custom_log_level(stdout, logger, log_level):
176176

177177
# THEN external logger used Powertools handler, formatter and CUSTOM log level.
178178
assert len(logger.handlers) == 1
179-
assert type(logger.handlers[0]) is logging.StreamHandler
180-
assert type(logger.handlers[0].formatter) is formatter.LambdaPowertoolsFormatter
179+
assert isinstance(logger.handlers[0], logging.StreamHandler)
180+
assert isinstance(logger.handlers[0].formatter, formatter.LambdaPowertoolsFormatter)
181181
assert powertools_logger.level == log_level.CRITICAL.value
182182
assert logger.level == log_level.WARNING.value
183183
assert log["message"] == msg

0 commit comments

Comments
 (0)