Skip to content

Commit 231f6f3

Browse files
committed
feat: get_logs to accept datetime for consistency
1 parent 338698b commit 231f6f3

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

tests/e2e/logger/test_logger.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def test_basic_lambda_logs_visible(basic_handler_fn, basic_handler_fn_arn):
2929
# WHEN
3030
_, execution_time = data_fetcher.get_lambda_response(lambda_arn=basic_handler_fn_arn)
3131
filtered_logs = data_fetcher.get_logs(
32-
lambda_function_name=basic_handler_fn, start_time=int(execution_time.timestamp()), log_client=cw_client
32+
lambda_function_name=basic_handler_fn, start_time=execution_time, log_client=cw_client
3333
)
3434

3535
# THEN

tests/e2e/utils/data_fetcher/logs.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import json
2+
from datetime import datetime
23
from functools import lru_cache
34
from typing import List, Optional, Union
45

@@ -24,10 +25,13 @@ class Log(BaseModel):
2425

2526
@lru_cache(maxsize=10, typed=False)
2627
@retry(ValueError, delay=1, jitter=1, tries=20)
27-
def get_logs(lambda_function_name: str, log_client: CloudWatchClient, start_time: int, **kwargs: dict) -> List[Log]:
28-
response = log_client.filter_log_events(logGroupName=f"/aws/lambda/{lambda_function_name}", startTime=start_time)
28+
def get_logs(lambda_function_name: str, log_client: CloudWatchClient, start_time: datetime) -> List[Log]:
29+
response = log_client.filter_log_events(
30+
logGroupName=f"/aws/lambda/{lambda_function_name}", startTime=int(start_time.timestamp())
31+
)
2932
if not response["events"]:
3033
raise ValueError("Empty response from Cloudwatch Logs. Repeating...")
34+
3135
filtered_logs = []
3236
for event in response["events"]:
3337
try:

0 commit comments

Comments
 (0)