refactor: Broke logic into multiple lines

Author: Michael Brewer

aws_lambda_powertools/utilities/idempotency/persistence/base.py

@@ -183,7 +183,14 @@ def _get_hashed_idempotency_key(self, lambda_event: Dict[str, Any]) -> str:
 
     @staticmethod
     def is_missing_idempotency_key(data) -> bool:
-        return data is None or not data or (type(data).__name__ in ("tuple", "list") and all(x is None for x in data))
+        if data is None:
+            return True
+        elif not data:
+            return True
+        elif type(data).__name__ in ("tuple", "list", "dict"):
+            return all(x is None for x in data)
+        else:
+            return False
 
     def _get_hashed_payload(self, lambda_event: Dict[str, Any]) -> str:
         """

tests/functional/idempotency/test_idempotency.py

@@ -696,6 +696,8 @@ def test_is_missing_idempotency_key():
     assert BasePersistenceLayer.is_missing_idempotency_key([None, None])
     # GIVEN a tuples of Nones THEN is_missing_idempotency_key is True
     assert BasePersistenceLayer.is_missing_idempotency_key((None, None))
+    # GIVEN a dict of Nones THEN is_missing_idempotency_key is True
+    assert BasePersistenceLayer.is_missing_idempotency_key({None: None})
 
     # GIVEN a str THEN is_missing_idempotency_key is False
     assert BasePersistenceLayer.is_missing_idempotency_key("Value") is False