fix e2e bucket deletion

Author: jeromevdl

powertools-e2e-tests/handlers/largemessage/src/main/java/software/amazon/lambda/powertools/e2e/Function.java

@@ -41,7 +41,7 @@ public SQSBatchResponse handleRequest(SQSEvent event, Context context) {
         return SQSBatchResponse.builder().build();
     }
 
-    @LargeMessage(deleteS3Object = false)
+    @LargeMessage
     private void processRawMessage(SQSMessage sqsMessage, Context context) {
         String bodyMD5 = md5(sqsMessage.getBody());
         if (!sqsMessage.getMd5OfBody().equals(bodyMD5)) {

powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/testutils/Infrastructure.java

@@ -360,11 +360,10 @@ private Stack createStackWithLambda() {
         if (!StringUtils.isEmpty(largeMessagesBucket)) {
             Bucket offloadBucket = Bucket.Builder
                     .create(stack, "LargeMessagesOffloadBucket")
-//                    .removalPolicy(RemovalPolicy.DESTROY)
-//                    .autoDeleteObjects(true)
+                    .removalPolicy(RemovalPolicy.RETAIN) // autodelete does not work without cdk deploy
                     .bucketName(largeMessagesBucket)
                     .build();
-            // just in case ...
+            // instead of autodelete, have a lifecycle rule to delete files after a day
             LifecycleRule.builder().expiration(Duration.days(1)).enabled(true).build();
             offloadBucket.grantReadWrite(function);
         }