Skip to content

Commit c5a71f9

Browse files
authored
refactor: replace Apache Commons Logging with SLF4J (#212)
1 parent ee08068 commit c5a71f9

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/SqsUtils.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,10 @@
2222
import com.amazonaws.services.lambda.runtime.events.SQSEvent;
2323
import com.fasterxml.jackson.core.JsonProcessingException;
2424
import com.fasterxml.jackson.databind.ObjectMapper;
25-
import org.apache.commons.logging.Log;
26-
import org.apache.commons.logging.LogFactory;
25+
26+
import org.slf4j.Logger;
27+
import org.slf4j.LoggerFactory;
28+
2729
import software.amazon.awssdk.services.sqs.SqsClient;
2830
import software.amazon.lambda.powertools.sqs.internal.BatchContext;
2931
import software.amazon.lambda.powertools.sqs.internal.SqsLargeMessageAspect;
@@ -36,7 +38,7 @@
3638
* A class of helper functions to add additional functionality to {@link SQSEvent} processing.
3739
*/
3840
public final class SqsUtils {
39-
private static final Log LOG = LogFactory.getLog(SqsUtils.class);
41+
private static final Logger LOG = LoggerFactory.getLogger(SqsUtils.class);
4042

4143
private static final ObjectMapper objectMapper = new ObjectMapper();
4244
private static SqsClient client = SqsClient.create();

powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/internal/BatchContext.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
package software.amazon.lambda.powertools.sqs.internal;
22

3+
import org.slf4j.Logger;
4+
import org.slf4j.LoggerFactory;
5+
36
import java.util.ArrayList;
47
import java.util.List;
58

6-
import org.apache.commons.logging.Log;
7-
import org.apache.commons.logging.LogFactory;
89
import software.amazon.awssdk.services.sqs.SqsClient;
910
import software.amazon.awssdk.services.sqs.model.DeleteMessageBatchRequest;
1011
import software.amazon.awssdk.services.sqs.model.DeleteMessageBatchRequestEntry;
@@ -17,7 +18,7 @@
1718
import static java.util.stream.Collectors.toList;
1819

1920
public final class BatchContext {
20-
private static final Log LOG = LogFactory.getLog(BatchContext.class);
21+
private static final Logger LOG = LoggerFactory.getLogger(BatchContext.class);
2122

2223
private final List<SQSMessage> success = new ArrayList<>();
2324
private final List<SQSMessage> failures = new ArrayList<>();

powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/internal/SqsLargeMessageAspect.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,14 @@
1414
import com.amazonaws.services.s3.model.S3Object;
1515
import com.amazonaws.services.s3.model.S3ObjectInputStream;
1616
import com.amazonaws.util.IOUtils;
17-
import org.apache.commons.logging.Log;
18-
import org.apache.commons.logging.LogFactory;
17+
1918
import org.aspectj.lang.ProceedingJoinPoint;
2019
import org.aspectj.lang.annotation.Around;
2120
import org.aspectj.lang.annotation.Aspect;
2221
import org.aspectj.lang.annotation.Pointcut;
22+
import org.slf4j.Logger;
23+
import org.slf4j.LoggerFactory;
24+
2325
import software.amazon.lambda.powertools.sqs.SqsLargeMessage;
2426
import software.amazon.payloadoffloading.PayloadS3Pointer;
2527

@@ -30,7 +32,7 @@
3032
@Aspect
3133
public class SqsLargeMessageAspect {
3234

33-
private static final Log LOG = LogFactory.getLog(SqsLargeMessageAspect.class);
35+
private static final Logger LOG = LoggerFactory.getLogger(SqsLargeMessageAspect.class);
3436
private static AmazonS3 amazonS3 = AmazonS3ClientBuilder.defaultClient();
3537

3638
@SuppressWarnings({"EmptyMethod"})

0 commit comments

Comments
 (0)