fix spotbug and sonar most important issues

Author: jeromevdl

powertools-large-messages/src/main/java/software/amazon/lambda/powertools/largemessages/internal/LargeSNSMessageProcessor.java

@@ -8,9 +8,6 @@
 
 public class LargeSNSMessageProcessor extends LargeMessageProcessor<SNSRecord> {
 
-    public LargeSNSMessageProcessor() {
-    }
-
     @Override
     protected String getMessageId(SNSRecord message) {
         return message.getSNS().getMessageId();

powertools-large-messages/src/main/java/software/amazon/lambda/powertools/largemessages/internal/LargeSQSMessageProcessor.java

@@ -27,9 +27,6 @@ public class LargeSQSMessageProcessor extends LargeMessageProcessor<SQSMessage>
     private static final byte STRING_LIST_TYPE_FIELD_INDEX = 3;
     private static final byte BINARY_LIST_TYPE_FIELD_INDEX = 4;
 
-    public LargeSQSMessageProcessor() {
-    }
-
     @Override
     protected String getMessageId(SQSMessage message) {
         return message.getMessageId();
@@ -91,6 +88,7 @@ static Optional<String> calculateMessageBodyMd5(String messageBody) {
      * @param messageAttributes attributes of the SQS Message
      * @return the MD5 digest of the SQS Message attributes (or empty in case of error)
      */
+    @SuppressWarnings("squid:S4790") // MD5 algorithm is used by SQS, we must use MD5
     static Optional<String> calculateMessageAttributesMd5(final Map<String, MessageAttribute> messageAttributes) {
         List<String> sortedAttributeNames = new ArrayList<>(messageAttributes.keySet());
         Collections.sort(sortedAttributeNames);

spotbugs-exclude.xml

@@ -36,6 +36,10 @@
                 <Class name="software.amazon.lambda.powertools.idempotency.Idempotency"/>
                 <Method name="getConfig"/>
             </And>
+            <And>
+                <Class name="software.amazon.lambda.powertools.largemessages.LargeMessageConfig"/>
+                <Method name="getS3Client"/>
+            </And>
         </Or>
     </Match>
     <Match>
@@ -93,6 +97,10 @@
                 <Class name="software.amazon.lambda.powertools.utilities.EventDeserializer$EventPart"/>
                 <Field name="contentList"/>
             </And>
+            <And>
+                <Class name="software.amazon.lambda.powertools.largemessages.LargeMessageConfig"/>
+                <Method name="s3Client"/>
+            </And>
         </Or>
     </Match>
     <!--Functionally needed-->