Skip to content

Commit 3206439

Browse files
committed
fix
1 parent 7d9336b commit 3206439

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

powertools-logging/powertools-logging-log4j/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/PowertoolsResolver.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,6 @@ public void resolve(LogEvent value, JsonWriter jsonWriter) {
259259

260260
@Override
261261
public boolean isResolvable(LogEvent value) {
262-
ReadOnlyStringMap contextData = value.getContextData();
263-
return null != contextData && !contextData.isEmpty() && internalResolver.isResolvable(value);
262+
return value != null && value.getContextData() != null && internalResolver.isResolvable(value);
264263
}
265264
}

powertools-logging/powertools-logging-log4j/src/test/java/org/apache/logging/log4j/layout/template/json/resolver/PowertoolsMessageResolverTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,12 @@ void shouldLogJsonMessageWithoutEscapedStrings() {
8181

8282
// THEN
8383
File logFile = new File("target/logfile.json");
84-
assertThat(contentOf(logFile)).contains("\"message\":{\"messageId\":\"1212abcd\",\"receiptHandle\":null,\"body\":\"plop\",\"md5OfBody\":null,\"md5OfMessageAttributes\":null,\"eventSourceArn\":null,\"eventSource\":\"eb\",\"awsRegion\":\"eu-west-1\",\"attributes\":null,\"messageAttributes\":{\"keyAttribute\":{\"stringValue\":null,\"binaryValue\":null,\"stringListValues\":[\"val1\",\"val2\",\"val3\"],\"binaryListValues\":null,\"dataType\":null}}}");
84+
assertThat(contentOf(logFile))
85+
.contains("\"message\":{\"messageId\":\"1212abcd\",\"receiptHandle\":null,\"body\":\"plop\",\"md5OfBody\":null,\"md5OfMessageAttributes\":null,\"eventSourceArn\":null,\"eventSource\":\"eb\",\"awsRegion\":\"eu-west-1\",\"attributes\":null,\"messageAttributes\":{\"keyAttribute\":{\"stringValue\":null,\"binaryValue\":null,\"stringListValues\":[\"val1\",\"val2\",\"val3\"],\"binaryListValues\":null,\"dataType\":null}}}")
86+
.contains("\"message\":\"1212abcd\"")
87+
.contains("\"message\":\"Message body = plop and id = \\\"1212abcd\\\"\"");
8588
}
8689

87-
8890
@Test
8991
void shouldLogStringMessageWhenNotJson() {
9092
// GIVEN

powertools-logging/powertools-logging-log4j/src/test/java/software/amazon/lambda/powertools/logging/internal/handler/PowertoolsJsonMessage.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ public class PowertoolsJsonMessage implements RequestHandler<SQSEvent.SQSMessage
3131
public String handleRequest(SQSEvent.SQSMessage input, Context context) {
3232
try {
3333
LOG.debug(JsonConfig.get().getObjectMapper().writeValueAsString(input));
34+
LOG.debug("{}", input.getMessageId());
35+
LOG.warn("Message body = {} and id = \"{}\"", input.getBody(), input.getMessageId());
3436
} catch (JsonProcessingException e) {
3537
throw new RuntimeException(e);
3638
}

0 commit comments

Comments
 (0)