Merge pull request #800 from hjgraca/fix/low-hanging-fruit-metrics-v2

chore(metrics): Fix low hanging fruit for v2

Author: hjgraca

apidocs/docfx.json

@@ -9,7 +9,7 @@
       ],
       "dest": "api",
       "properties": {
-        "TargetFramework": "net6.0"
+        "TargetFramework": "net8.0"
       },
       "disableGitFeatures": false,
       "disableDefaultFilter": false

docs/core/metrics-v2.md

@@ -35,7 +35,7 @@ Powertools for AWS Lambda (.NET) are available as NuGet packages. You can instal
 
 * [AWS.Lambda.Powertools.Metrics](https://www.nuget.org/packages?q=AWS.Lambda.Powertools.Metrics):
 
-    `dotnet nuget add AWS.Lambda.Powertools.Metrics`
+    `dotnet add package AWS.Lambda.Powertools.Metrics`
 
 ## Terminologies
 
@@ -608,7 +608,7 @@ CloudWatch EMF uses the same dimensions across all your metrics. Use **`PushSing
       public async Task<APIGatewayProxyResponse> FunctionHandler(APIGatewayProxyRequest apigProxyEvent, ILambdaContext context)
       {
         Metrics.PushSingleMetric(
-                    metricName: "ColdStart",
+                    name: "ColdStart",
                     value: 1,
                     unit: MetricUnit.Count,
                     nameSpace: "ExampleApplication",
@@ -632,7 +632,7 @@ By default it will skip all previously defined dimensions including default dime
       public async Task<APIGatewayProxyResponse> FunctionHandler(APIGatewayProxyRequest apigProxyEvent, ILambdaContext context)
       {
         Metrics.PushSingleMetric(
-                    metricName: "ColdStart",
+                    name: "ColdStart",
                     value: 1,
                     unit: MetricUnit.Count,
                     nameSpace: "ExampleApplication",

docs/core/metrics.md

@@ -28,7 +28,7 @@ Powertools for AWS Lambda (.NET) are available as NuGet packages. You can instal
 
 * [AWS.Lambda.Powertools.Metrics](https://www.nuget.org/packages?q=AWS.Lambda.Powertools.Metrics):
 
-    `dotnet nuget add AWS.Lambda.Powertools.Metrics`
+    `dotnet add package AWS.Lambda.Powertools.Metrics -v 1.7.1`
 
 ## Terminologies
 

libraries/src/AWS.Lambda.Powertools.Common/Core/PowertoolsConfigurations.cs

@@ -27,7 +27,7 @@ public class PowertoolsConfigurations : IPowertoolsConfigurations
     /// <summary>
     ///     The maximum dimensions
     /// </summary>
-    public const int MaxDimensions = 9;
+    public const int MaxDimensions = 29;
 
     /// <summary>
     ///     The maximum metrics

libraries/src/AWS.Lambda.Powertools.Metrics/Model/MetricDirective.cs

@@ -204,7 +204,7 @@ internal void AddDimension(DimensionSet dimension)
         else
         {
             throw new ArgumentOutOfRangeException(nameof(Dimensions),
-                "Cannot add more than 9 dimensions at the same time.");
+                $"Cannot add more than {PowertoolsConfigurations.MaxDimensions} dimensions at the same time.");
         }
     }
 

libraries/tests/AWS.Lambda.Powertools.Metrics.Tests/EMFValidationTests.cs

@@ -113,7 +113,7 @@ public void WhenMaxDataPointsAreAddedToTheSameMetric_FlushAutomatically()
         public void WhenMoreThan9DimensionsAdded_ThrowArgumentOutOfRangeException()
         {
             // Act
-            var act = () => { _handler.MaxDimensions(9); };
+            var act = () => { _handler.MaxDimensions(29); };
 
             // Assert
             Assert.Throws<ArgumentOutOfRangeException>(act);