Add an accept header in JSON request to help 3rd party services like localstack (#1721)

jderusse · web-flow · commit e26cd9d3349c · 2024-06-05T21:12:02.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### Changed
+
+- Add `Accept: application/json` header in request to fix incompatibility with 3rd party providers
+
 ## 2.5.0
 
 ### Added
diff --git a/src/Input/AddLayerVersionPermissionRequest.php b/src/Input/AddLayerVersionPermissionRequest.php
@@ -153,7 +153,10 @@ public function getVersionNumber(): ?int
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];
diff --git a/src/Input/DeleteFunctionRequest.php b/src/Input/DeleteFunctionRequest.php
@@ -76,7 +76,10 @@ public function getQualifier(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];
diff --git a/src/Input/GetFunctionConfigurationRequest.php b/src/Input/GetFunctionConfigurationRequest.php
@@ -76,7 +76,10 @@ public function getQualifier(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];
diff --git a/src/Input/InvocationRequest.php b/src/Input/InvocationRequest.php
@@ -154,7 +154,10 @@ public function getQualifier(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
         if (null !== $this->invocationType) {
             if (!InvocationType::exists($this->invocationType)) {
                 throw new InvalidArgument(sprintf('Invalid parameter "InvocationType" for "%s". The value "%s" is not a valid "InvocationType".', __CLASS__, $this->invocationType));
diff --git a/src/Input/ListFunctionsRequest.php b/src/Input/ListFunctionsRequest.php
@@ -102,7 +102,10 @@ public function getMaxItems(): ?int
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];
diff --git a/src/Input/ListLayerVersionsRequest.php b/src/Input/ListLayerVersionsRequest.php
@@ -126,7 +126,10 @@ public function getMaxItems(): ?int
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];
diff --git a/src/Input/ListVersionsByFunctionRequest.php b/src/Input/ListVersionsByFunctionRequest.php
@@ -92,7 +92,10 @@ public function getMaxItems(): ?int
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];
diff --git a/src/Input/PublishLayerVersionRequest.php b/src/Input/PublishLayerVersionRequest.php
@@ -151,7 +151,10 @@ public function getLicenseInfo(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];
diff --git a/src/Input/UpdateFunctionConfigurationRequest.php b/src/Input/UpdateFunctionConfigurationRequest.php
@@ -393,7 +393,10 @@ public function getVpcConfig(): ?VpcConfig
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];
diff --git a/tests/Unit/Input/AddLayerVersionPermissionRequestTest.php b/tests/Unit/Input/AddLayerVersionPermissionRequestTest.php
@@ -24,7 +24,8 @@ public function testRequest(): void
 
         $expected = '
             POST /2018-10-31/layers/nodejs/versions/2/policy?RevisionId=123456 HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
                "Action": "lambda:GetLayerVersion",
diff --git a/tests/Unit/Input/DeleteFunctionRequestTest.php b/tests/Unit/Input/DeleteFunctionRequestTest.php
@@ -17,7 +17,8 @@ public function testRequest(): void
         // see example-1.json from SDK
         $expected = '
             DELETE /2015-03-31/functions/my-function?Qualifier=4711  HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 ';
 
         self::assertRequestEqualsHttpRequest($expected, $input->request());
diff --git a/tests/Unit/Input/GetFunctionConfigurationRequestTest.php b/tests/Unit/Input/GetFunctionConfigurationRequestTest.php
@@ -17,7 +17,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/lambda/latest/APIReference/API_GetFunctionConfiguration.html
         $expected = '
             GET /2015-03-31/functions/test-func/configuration?Qualifier=change HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
         ';
         self::assertRequestEqualsHttpRequest($expected, $input->request());
     }
diff --git a/tests/Unit/Input/InvocationRequestTest.php b/tests/Unit/Input/InvocationRequestTest.php
@@ -24,7 +24,8 @@ public function testRequest(): void
 
         $expected = '
             POST /2015-03-31/functions/MyFunction/invocations?Qualifier=1 HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
             x-amz-invocation-type: Event
             x-amz-log-type: Tail
             x-amz-client-context: MyApp
diff --git a/tests/Unit/Input/ListFunctionsRequestTest.php b/tests/Unit/Input/ListFunctionsRequestTest.php
@@ -19,7 +19,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/lambda/latest/APIReference/API_ListFunctions.html
         $expected = '
             GET /2015-03-31/functions/?FunctionVersion=ALL&Marker=xxyy&MasterRegion=eu-central-1&MaxItems=1337 HTTP/1.1
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
                 ';
 
         self::assertRequestEqualsHttpRequest($expected, $input->request());
diff --git a/tests/Unit/Input/ListLayerVersionsRequestTest.php b/tests/Unit/Input/ListLayerVersionsRequestTest.php
@@ -20,7 +20,8 @@ public function testRequest(): void
 
         $expected = '
             GET /2018-10-31/layers/demo/versions?CompatibleRuntime=nodejs12.x HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
         ';
 
         self::assertRequestEqualsHttpRequest($expected, $input->request());
diff --git a/tests/Unit/Input/ListVersionsByFunctionRequestTest.php b/tests/Unit/Input/ListVersionsByFunctionRequestTest.php
@@ -18,7 +18,8 @@ public function testRequest(): void
         // see example-1.json from SDK
         $expected = '
             GET /2015-03-31/functions/MyFunction/versions?Marker=xxyy&MaxItems=1337 HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
                 ';
 
diff --git a/tests/Unit/Input/PublishLayerVersionRequestTest.php b/tests/Unit/Input/PublishLayerVersionRequestTest.php
@@ -29,7 +29,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/lambda/latest/dg/API_PublishLayerVersion.html
         $expected = '
             POST /2018-10-31/layers/demo/versions HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
                 "Description": "small description",
diff --git a/tests/Unit/Input/UpdateFunctionConfigurationRequestTest.php b/tests/Unit/Input/UpdateFunctionConfigurationRequestTest.php
@@ -64,7 +64,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/lambda/latest/APIReference/API_UpdateFunctionConfiguration.html
         $expected = '
             PUT /2015-03-31/functions/test-func/configuration HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
                 "DeadLetterConfig": {

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,8 @@ public function testRequest(): void`
`24`	`24`
`25`	`25`	`$expected = '`
`26`	`26`	`POST /2018-10-31/layers/nodejs/versions/2/policy?RevisionId=123456 HTTP/1.0`
`27`		`- Content-Type: application/json`
	`27`	`+ Content-type: application/json`
	`28`	`+ Accept: application/json`
`28`	`29`
`29`	`30`	`{`
`30`	`31`	`"Action": "lambda:GetLayerVersion",`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,8 @@ public function testRequest(): void`
`29`	`29`	`// see https://docs.aws.amazon.com/lambda/latest/dg/API_PublishLayerVersion.html`
`30`	`30`	`$expected = '`
`31`	`31`	`POST /2018-10-31/layers/demo/versions HTTP/1.0`
`32`		`- Content-Type: application/json`
	`32`	`+ Content-type: application/json`
	`33`	`+ Accept: application/json`
`33`	`34`
`34`	`35`	`{`
`35`	`36`	`"Description": "small description",`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,8 @@ public function testRequest(): void`
`64`	`64`	`// see https://docs.aws.amazon.com/lambda/latest/APIReference/API_UpdateFunctionConfiguration.html`
`65`	`65`	`$expected = '`
`66`	`66`	`PUT /2015-03-31/functions/test-func/configuration HTTP/1.0`
`67`		`- Content-Type: application/json`
	`67`	`+ Content-type: application/json`
	`68`	`+ Accept: application/json`
`68`	`69`
`69`	`70`	`{`
`70`	`71`	`"DeadLetterConfig": {`