Use int as the PHP representation of long fields in generated code (#1471)

* Use int as the PHP representation of long fields in generated code

* Add changelog entries for signature changes affecting strict types

* Remove generator hacks needed for endpoint shapes to force the type

Now that long fields are always defined as integer, we don't need such
hacks anymore

Author: stof

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### BC-BREAK
+
+- The return type for the methods `getFailed`, `getInProgress`, `getPending`, `getReady`, `getSkipped` and `getSucceeded` of `\AsyncAws\CodeDeploy\ValueObject\DeploymentOverview` uses `int` instead of `string` to reflect the AWS type.
+
 ## 1.4.0
 
 ### Added

src/Result/GetDeploymentOutput.php

@@ -189,12 +189,12 @@ private function populateResultDeploymentInfo(array $json): DeploymentInfo
     private function populateResultDeploymentOverview(array $json): DeploymentOverview
     {
         return new DeploymentOverview([
-            'Pending' => isset($json['Pending']) ? (string) $json['Pending'] : null,
-            'InProgress' => isset($json['InProgress']) ? (string) $json['InProgress'] : null,
-            'Succeeded' => isset($json['Succeeded']) ? (string) $json['Succeeded'] : null,
-            'Failed' => isset($json['Failed']) ? (string) $json['Failed'] : null,
-            'Skipped' => isset($json['Skipped']) ? (string) $json['Skipped'] : null,
-            'Ready' => isset($json['Ready']) ? (string) $json['Ready'] : null,
+            'Pending' => isset($json['Pending']) ? (int) $json['Pending'] : null,
+            'InProgress' => isset($json['InProgress']) ? (int) $json['InProgress'] : null,
+            'Succeeded' => isset($json['Succeeded']) ? (int) $json['Succeeded'] : null,
+            'Failed' => isset($json['Failed']) ? (int) $json['Failed'] : null,
+            'Skipped' => isset($json['Skipped']) ? (int) $json['Skipped'] : null,
+            'Ready' => isset($json['Ready']) ? (int) $json['Ready'] : null,
         ]);
     }
 

src/ValueObject/DeploymentOverview.php

@@ -39,12 +39,12 @@ final class DeploymentOverview
 
     /**
      * @param array{
-     *   Pending?: null|string,
-     *   InProgress?: null|string,
-     *   Succeeded?: null|string,
-     *   Failed?: null|string,
-     *   Skipped?: null|string,
-     *   Ready?: null|string,
+     *   Pending?: null|int,
+     *   InProgress?: null|int,
+     *   Succeeded?: null|int,
+     *   Failed?: null|int,
+     *   Skipped?: null|int,
+     *   Ready?: null|int,
      * } $input
      */
     public function __construct(array $input)
@@ -59,45 +59,45 @@ public function __construct(array $input)
 
     /**
      * @param array{
-     *   Pending?: null|string,
-     *   InProgress?: null|string,
-     *   Succeeded?: null|string,
-     *   Failed?: null|string,
-     *   Skipped?: null|string,
-     *   Ready?: null|string,
+     *   Pending?: null|int,
+     *   InProgress?: null|int,
+     *   Succeeded?: null|int,
+     *   Failed?: null|int,
+     *   Skipped?: null|int,
+     *   Ready?: null|int,
      * }|DeploymentOverview $input
      */
     public static function create($input): self
     {
         return $input instanceof self ? $input : new self($input);
     }
 
-    public function getFailed(): ?string
+    public function getFailed(): ?int
     {
         return $this->failed;
     }
 
-    public function getInProgress(): ?string
+    public function getInProgress(): ?int
     {
         return $this->inProgress;
     }
 
-    public function getPending(): ?string
+    public function getPending(): ?int
     {
         return $this->pending;
     }
 
-    public function getReady(): ?string
+    public function getReady(): ?int
     {
         return $this->ready;
     }
 
-    public function getSkipped(): ?string
+    public function getSkipped(): ?int
     {
         return $this->skipped;
     }
 
-    public function getSucceeded(): ?string
+    public function getSucceeded(): ?int
     {
         return $this->succeeded;
     }

tests/Unit/Result/GetDeploymentOutputTest.php

@@ -216,12 +216,12 @@ public function testGetDeploymentOutput(): void
         self::assertSame(InstanceAction::TERMINATE, $info->getBlueGreenDeploymentConfiguration()->getTerminateBlueInstancesOnDeploymentSuccess()->getAction());
         self::assertSame(2, $info->getBlueGreenDeploymentConfiguration()->getTerminateBlueInstancesOnDeploymentSuccess()->getTerminationWaitTimeInMinutes());
 
-        self::assertSame('1', $info->getDeploymentOverview()->getFailed());
-        self::assertSame('2', $info->getDeploymentOverview()->getInProgress());
-        self::assertSame('3', $info->getDeploymentOverview()->getPending());
-        self::assertSame('4', $info->getDeploymentOverview()->getReady());
-        self::assertSame('5', $info->getDeploymentOverview()->getSkipped());
-        self::assertSame('6', $info->getDeploymentOverview()->getSucceeded());
+        self::assertSame(1, $info->getDeploymentOverview()->getFailed());
+        self::assertSame(2, $info->getDeploymentOverview()->getInProgress());
+        self::assertSame(3, $info->getDeploymentOverview()->getPending());
+        self::assertSame(4, $info->getDeploymentOverview()->getReady());
+        self::assertSame(5, $info->getDeploymentOverview()->getSkipped());
+        self::assertSame(6, $info->getDeploymentOverview()->getSucceeded());
 
         self::assertSame(DeploymentOption::WITH_TRAFFIC_CONTROL, $info->getDeploymentStyle()->getDeploymentOption());
         self::assertSame(DeploymentType::IN_PLACE, $info->getDeploymentStyle()->getDeploymentType());