React to Newtonsoft.Json changes

- react to `BsonReader`, `BsonWriter` deprecation
- one of our `DateTime` tests now consistently hits `5` errors
- `s/True/true/` also consistent now in another test

Author: dougbu

src/System.Net.Http.Formatting/Formatting/BsonMediaTypeFormatter.cs

@@ -200,7 +200,13 @@ public override JsonReader CreateJsonReader(Type type, Stream readStream, Encodi
                 throw Error.ArgumentNull("effectiveEncoding");
             }
 
+#if !NEWTONSOFTJSON10
+#pragma warning disable CS0618 // Type or member is obsolete
+#endif
             BsonReader reader = new BsonReader(new BinaryReader(readStream, effectiveEncoding));
+#if !NEWTONSOFTJSON10
+#pragma warning restore CS0618 // Type or member is obsolete
+#endif
 
             try
             {
@@ -297,7 +303,13 @@ public override JsonWriter CreateJsonWriter(Type type, Stream writeStream, Encod
                 throw Error.ArgumentNull("effectiveEncoding");
             }
 
+#if !NEWTONSOFTJSON10
+#pragma warning disable CS0618 // Type or member is obsolete
+#endif
             return new BsonWriter(new BinaryWriter(writeStream, effectiveEncoding));
+#if !NEWTONSOFTJSON10
+#pragma warning restore CS0618 // Type or member is obsolete
+#endif
         }
 
         // Return true if Json.Net will likely convert value of given type to a Json primitive, not JsonArray nor

test/System.Net.Http.Formatting.Test/Formatting/BsonMediaTypeFormatterTests.cs

@@ -340,9 +340,9 @@ public async Task FormatterThrowsOnReadWithInvalidContent()
             stream.Seek(0L, SeekOrigin.Begin);
 
             // Act & Assert
-            await Assert.ThrowsAsync<OverflowException>(
+            await Assert.ThrowsAsync<JsonReaderException>(
                 () => formatter.ReadFromStreamAsync(variationType, stream, content, null),
-                "Value was either too large or too small for a Decimal.");
+                "Could not convert to decimal: 7.92281625142643E+28. Path 'Value'.");
         }
 
         [Theory]

test/System.Net.Http.Formatting.Test/Formatting/JsonNetValidationTest.cs

@@ -28,15 +28,7 @@ public static TheoryDataSet<string, Type, int> Theories
                     {"\"foo\"", typeof(DateTime), 1},
 
                     {"[\"a\",\"b\",\"45\",34]", typeof(int[]), 2},
-                    {
-                        "[\"a\",\"b\",\"45\",34]",
-                        typeof(DateTime[]),
-#if NEWTONSOFTJSON10 // Json.NET 10 detects an additional error over earlier versions.
-                        5
-#else
-                        4
-#endif
-                    },
+                    {"[\"a\",\"b\",\"45\",34]", typeof(DateTime[]), 5},
 
                     // Required members
 

test/System.Web.Http.Test/Tracing/Tracers/FormatterParameterBindingTracerTest.cs

@@ -125,7 +125,7 @@ public async Task ExecuteBindingAsync_Traces_And_Invokes_Inner_ReadAsync()
 
             // Assert
             Assert.Equal<TraceRecord>(expectedTraces, traceWriter.Traces, new TraceRecordComparer());
-            Assert.Equal("True", actionContext.ActionArguments["paramName"]);
+            Assert.Equal("true", actionContext.ActionArguments["paramName"]);
         }
 
         [Fact]