Skip to content

Commit 36ab363

Browse files
committed
Using real random noce
1 parent 90e8a2a commit 36ab363

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
* for more information concerning the license and the contributors participating to this project.
55
*/
66

7+
using System.Buffers.Text;
78
using System.Globalization;
89
using System.Net;
910
using System.Net.Http.Headers;
@@ -106,16 +107,15 @@ protected override async Task<AuthenticationTicket> CreateTicketAsync(
106107
[NotNull] ClaimsIdentity identity,
107108
[NotNull] AuthenticationProperties properties,
108109
[NotNull] OAuthTokenResponse tokens)
109-
{
110-
var utcNow = TimeProvider.GetUtcNow();
110+
{
111111
using var request = new HttpRequestMessage(HttpMethod.Get, Options.UserInformationEndpoint);
112112
request.Headers.Add("access-token", tokens.AccessToken);
113113
request.Headers.Add("x-bili-accesskeyid", Options.ClientId);
114114
request.Headers.Add("x-bili-content-md5", "d41d8cd98f00b204e9800998ecf8427e");
115115
request.Headers.Add("x-bili-signature-method", "HMAC-SHA256");
116-
request.Headers.Add("x-bili-signature-nonce", utcNow.ToUnixTimeMilliseconds().ToString(CultureInfo.InvariantCulture));
116+
request.Headers.Add("x-bili-signature-nonce", Base64Url.EncodeToString(RandomNumberGenerator.GetBytes(256 / 8)));
117117
request.Headers.Add("x-bili-signature-version", "2.0");
118-
request.Headers.Add("x-bili-timestamp", utcNow.ToUnixTimeSeconds().ToString(CultureInfo.InvariantCulture));
118+
request.Headers.Add("x-bili-timestamp", TimeProvider.GetUtcNow().ToUnixTimeSeconds().ToString(CultureInfo.InvariantCulture));
119119

120120
var signature = BuildSignatureString(request, Options.ClientSecret);
121121
request.Headers.Add("Authorization", signature);

0 commit comments

Comments
 (0)