From d670fed567f180367edb4c9d57cb9484bfd04bb2 Mon Sep 17 00:00:00 2001
From: Akos Kitta <kittaakos@typefox.io>
Date: Mon, 1 Mar 2021 13:20:39 +0100
Subject: [PATCH 1/2] GH-18: Use promisified `fs` functions.

Closes: #18
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
---
 src/extension.ts | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/extension.ts b/src/extension.ts
index 36ddf20..1ef8bc5 100644
--- a/src/extension.ts
+++ b/src/extension.ts
@@ -1,6 +1,5 @@
-import * as fs from 'fs';
+import { promises as fs } from 'fs';
 import * as path from 'path';
-import { promisify } from 'util';
 import { spawnSync } from 'child_process';
 import deepEqual from 'deep-equal';
 import WebRequest from 'web-request';
@@ -140,7 +139,7 @@ async function startDebug(_: ExtensionContext, config: DebugConfig): Promise<boo
 
     let customDebugConfig = {};
     try {
-        const raw = await promisify(fs.readFile)(path.join(config.sketchPath, 'debug_custom.json'), { encoding: 'utf8' });
+        const raw = await fs.readFile(path.join(config.sketchPath, 'debug_custom.json'), { encoding: 'utf8' });
         customDebugConfig = JSON.parse(raw);
     } catch { }
     const mergedDebugConfig = deepmerge(defaultDebugConfig, customDebugConfig);
@@ -199,7 +198,7 @@ async function buildLanguageClient(config: LanguageServerConfig): Promise<Langua
         let logPath: string | undefined = undefined;
         if (typeof log === 'string') {
             try {
-                const stats = await promisify(fs.stat)(log);
+                const stats = await fs.stat(log);
                 if (stats.isDirectory()) {
                     logPath = log;
                 }

From b97444c1877697bfea716eb136e4470814bbaa87 Mon Sep 17 00:00:00 2001
From: Akos Kitta <kittaakos@typefox.io>
Date: Wed, 3 Mar 2021 13:08:30 +0100
Subject: [PATCH 2/2] Can customize the `launch.json` location.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
---
 src/extension.ts | 25 ++++++++++++++++++++-----
 1 file changed, 20 insertions(+), 5 deletions(-)

diff --git a/src/extension.ts b/src/extension.ts
index 1ef8bc5..68b12fc 100644
--- a/src/extension.ts
+++ b/src/extension.ts
@@ -1,5 +1,5 @@
-import { promises as fs } from 'fs';
 import * as path from 'path';
+import { promises as fs } from 'fs';
 import { spawnSync } from 'child_process';
 import deepEqual from 'deep-equal';
 import WebRequest from 'web-request';
@@ -34,6 +34,11 @@ interface DebugConfig {
         readonly name?: string;
     }
     readonly sketchPath: string;
+    /**
+     * Location where the `launch.config` will be created on the fly before starting every debug session.
+     * If not defined, it falls back to `sketchPath/.vscode/launch.json`.
+     */
+    readonly configPath?: string;
 }
 
 interface DebugInfo {
@@ -143,9 +148,6 @@ async function startDebug(_: ExtensionContext, config: DebugConfig): Promise<boo
         customDebugConfig = JSON.parse(raw);
     } catch { }
     const mergedDebugConfig = deepmerge(defaultDebugConfig, customDebugConfig);
-
-    // Create the `launch.json` if it does not exist. Otherwise, update the existing.
-    const configuration = vscode.workspace.getConfiguration();
     const launchConfig = {
         version: '0.2.0',
         'configurations': [
@@ -154,7 +156,7 @@ async function startDebug(_: ExtensionContext, config: DebugConfig): Promise<boo
             }
         ]
     };
-    await configuration.update('launch', launchConfig, false);
+    await updateLaunchConfig(config, launchConfig);
     return vscode.debug.startDebugging(undefined, mergedDebugConfig);
 }
 
@@ -247,3 +249,16 @@ async function buildLanguageClient(config: LanguageServerConfig): Promise<Langua
         }
     );
 }
+
+/**
+ * Instead of writing the `launch.json` to the workspace, the file is written to the temporary binary output location.
+ */
+async function updateLaunchConfig(debugConfig: DebugConfig, launchConfig: object): Promise<void> {
+    if (debugConfig.configPath) {
+        await fs.mkdir(debugConfig.configPath, { recursive: true });
+        await fs.writeFile(path.join(debugConfig.configPath, 'launch.json'), JSON.stringify(launchConfig, null, 2));
+    } else {
+        const configuration = vscode.workspace.getConfiguration();
+        await configuration.update('launch', launchConfig, false);
+    }
+}