use arduino-cli executils

Author: alessio-perugini

go.mod

@@ -3,6 +3,7 @@ module github.com/arduino/uno-r4-wifi-fwuploader-plugin
 go 1.20
 
 require (
+	github.com/arduino/arduino-cli v0.0.0-20230630155703-fe6d7499eb5e
 	github.com/arduino/fwuploader-plugin-helper v0.0.0-20230626132535-2effbfcc7853
 	github.com/arduino/go-paths-helper v1.9.1
 	github.com/sstallion/go-hid v0.14.0
@@ -11,6 +12,7 @@ require (
 
 require (
 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
+	github.com/leonelquinteros/gotext v1.4.0 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/spf13/cobra v1.7.0 // indirect
 	github.com/spf13/pflag v1.0.5 // indirect

go.sum

@@ -1,3 +1,5 @@
+github.com/arduino/arduino-cli v0.0.0-20230630155703-fe6d7499eb5e h1:gmlrLhRuuIY/hw9EvvLCUvMDXMFZBtIVW29tMYGchkw=
+github.com/arduino/arduino-cli v0.0.0-20230630155703-fe6d7499eb5e/go.mod h1:2E4tNTNWuf4CtG/pF/Y+fRO6JXxVEcbDDStjZYtMK2c=
 github.com/arduino/fwuploader-plugin-helper v0.0.0-20230626132535-2effbfcc7853 h1:SEWDw4xcN+qNReANPPlnlGn/R4uP2QHdZyYI4DEYwNs=
 github.com/arduino/fwuploader-plugin-helper v0.0.0-20230626132535-2effbfcc7853/go.mod h1:y7Vo30dco4xAb39pQ2CRaCvayADjhOBAMrlfji4AYuM=
 github.com/arduino/go-paths-helper v1.9.1 h1:qpK+zMMjsklSBQa09/P5FZ/uf3LyjVmJK3DLeyiGjCc=
@@ -7,6 +9,8 @@ github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSs
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/inconshreveable/mousetrap v1.1.0 h1:wN+x4NVGpMsO7ErUn/mUI3vEoE6Jt13X2s0bqwp9tc8=
 github.com/inconshreveable/mousetrap v1.1.0/go.mod h1:vpF70FUmC8bwa3OWnCshd2FqLfsEA9PFc4w1p2J65bw=
+github.com/leonelquinteros/gotext v1.4.0 h1:2NHPCto5IoMXbrT0bldPrxj0qM5asOCwtb1aUQZ1tys=
+github.com/leonelquinteros/gotext v1.4.0/go.mod h1:yZGXREmoGTtBvZHNcc+Yfug49G/2spuF/i/Qlsvz1Us=
 github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
 github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
@@ -20,7 +24,7 @@ github.com/sstallion/go-hid v0.14.0 h1:bSCzyw5E9lGrdQb1NXgRYfmf/z+B+DfSftDlmjOMb
 github.com/sstallion/go-hid v0.14.0/go.mod h1:UaqSxWjbdX9mId5JiqsMAnVtZymx/GSvQMgnzHMks2M=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
-github.com/stretchr/testify v1.7.1 h1:5TQK59W5E3v0r2duFAb7P95B6hEeOyEnHRa8MjYSMTY=
+github.com/stretchr/testify v1.8.0 h1:pSgiaMZlXftHpm5L7V1+rVB+AZJydKsMxsQBIJw4PKk=
 go.bug.st/relaxed-semver v0.10.2 h1:d/ATAG3MByySZgg7rFj+Wj0fhvP4zfx9Z8Dn/NSCoFg=
 go.bug.st/relaxed-semver v0.10.2/go.mod h1:lPVGdtzbQ9/2fv6iXqIXWHOj6cMTUJ/l/Lu1w+sgdio=
 golang.org/x/sys v0.9.0 h1:KS/R3tvhPqvJvwcKfnBHJwwthS11LRhmM5D59eEXa0s=

main.go

@@ -2,10 +2,9 @@ package main
 
 import (
 	"fmt"
-	"os"
-	"os/exec"
 	"time"
 
+	"github.com/arduino/arduino-cli/executils"
 	helper "github.com/arduino/fwuploader-plugin-helper"
 	"github.com/arduino/go-paths-helper"
 	"github.com/sstallion/go-hid"
@@ -60,10 +59,12 @@ func (p *unoR4WifiPlugin) UploadFirmware(portAddress string, firmwarePath *paths
 	// Wait a bit before flashing the firmware to allow the board to become available again.
 	time.Sleep(3 * time.Second)
 
-	cmd := exec.Command("espflash", "flash", firmwarePath.String(), "-p", portAddress)
-	cmd.Stdout = feedback.Out()
-	cmd.Stderr = feedback.Err()
-	cmd.Env = append(cmd.Env, os.Environ()...)
+	cmd, err := executils.NewProcess([]string{}, "espflash", "flash", firmwarePath.String(), "-p", portAddress)
+	if err != nil {
+		return err
+	}
+	cmd.RedirectStderrTo(feedback.Err())
+	cmd.RedirectStdoutTo(feedback.Out())
 	if err := cmd.Run(); err != nil {
 		return err
 	}
@@ -101,10 +102,12 @@ func (p *unoR4WifiPlugin) UploadCertificate(portAddress string, certificatePath
 	// Wait a bit before flashing the certificate to allow the board to become available again.
 	time.Sleep(3 * time.Second)
 
-	cmd := exec.Command("espflash", "write-bin", "-p", portAddress, "-b", "921600", "0x3C0000", certificatePath.String())
-	cmd.Stdout = feedback.Out()
-	cmd.Stderr = feedback.Err()
-	cmd.Env = append(cmd.Env, os.Environ()...)
+	cmd, err := executils.NewProcess([]string{}, "espflash", "write-bin", "-p", portAddress, "-b", "921600", "0x3C0000", certificatePath.String())
+	if err != nil {
+		return err
+	}
+	cmd.RedirectStderrTo(feedback.Err())
+	cmd.RedirectStdoutTo(feedback.Out())
 	if err := cmd.Run(); err != nil {
 		return err
 	}