Skip to content

Commit 9297547

Browse files
committed
Update comment re: artifact losing exec mode in Go release workflows
GitHub Actions workflow artifacts lose their executable permissions. The previous comment anticipated that this would be resolved by the 2.x release of actions/download-artifact. However, that release came without any change to the situation, leaving the comment outdated and potentially confusing.
1 parent 8296ff0 commit 9297547

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

workflow-templates/dependabot/workflow-template-copies/.github/workflows/publish-go-nightly-task.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ jobs:
8080
# 1. Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
8181
# 2. Recalculate package checksum and replace it in the nnnnnn-checksums.txt file
8282
run: |
83-
# GitHub's upload/download-artifact@v1 actions don't preserve file permissions,
84-
# so we need to add execution permission back until @v2 actions are released.
83+
# GitHub's upload/download-artifact@v2 actions don't preserve file permissions,
84+
# so we need to add execution permission back until the action is made to do this.
8585
chmod +x dist/arduino-cli_osx_darwin_amd64/arduino-cli
8686
PACKAGE_FILENAME="$(basename dist/arduino-cli_nightly-*_macOS_64bit.tar.gz)"
8787
tar -czvf "dist/$PACKAGE_FILENAME" \

workflow-templates/dependabot/workflow-template-copies/.github/workflows/release-go-task.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ jobs:
8383
# 1. Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
8484
# 2. Recalculate package checksum and replace it in the nnnnnn-checksums.txt file
8585
run: |
86-
# GitHub's upload/download-artifact@v1 actions don't preserve file permissions,
87-
# so we need to add execution permission back until @v2 actions are released.
86+
# GitHub's upload/download-artifact@v2 actions don't preserve file permissions,
87+
# so we need to add execution permission back until the action is made to do this.
8888
chmod +x dist/arduino-cli_osx_darwin_amd64/arduino-cli
8989
TAG="${GITHUB_REF/refs\/tags\//}"
9090
tar -czvf "dist/arduino-cli_${TAG}_macOS_64bit.tar.gz" \

workflow-templates/publish-go-nightly-task.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ jobs:
8080
# 1. Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
8181
# 2. Recalculate package checksum and replace it in the nnnnnn-checksums.txt file
8282
run: |
83-
# GitHub's upload/download-artifact@v1 actions don't preserve file permissions,
84-
# so we need to add execution permission back until @v2 actions are released.
83+
# GitHub's upload/download-artifact@v2 actions don't preserve file permissions,
84+
# so we need to add execution permission back until the action is made to do this.
8585
chmod +x dist/arduino-cli_osx_darwin_amd64/arduino-cli
8686
PACKAGE_FILENAME="$(basename dist/arduino-cli_nightly-*_macOS_64bit.tar.gz)"
8787
tar -czvf "dist/$PACKAGE_FILENAME" \

workflow-templates/release-go-task.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ jobs:
8383
# 1. Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
8484
# 2. Recalculate package checksum and replace it in the nnnnnn-checksums.txt file
8585
run: |
86-
# GitHub's upload/download-artifact@v1 actions don't preserve file permissions,
87-
# so we need to add execution permission back until @v2 actions are released.
86+
# GitHub's upload/download-artifact@v2 actions don't preserve file permissions,
87+
# so we need to add execution permission back until the action is made to do this.
8888
chmod +x dist/arduino-cli_osx_darwin_amd64/arduino-cli
8989
TAG="${GITHUB_REF/refs\/tags\//}"
9090
tar -czvf "dist/arduino-cli_${TAG}_macOS_64bit.tar.gz" \

0 commit comments

Comments
 (0)