Skip to content

Commit 1816d8e

Browse files
committed
Use workflow variables for tool versions in all workflows
Placement of this information at the top of the file, where it is easy to find and edit, facilitates updates to the workflows as the tool version used for project development are bumped periodically. This is an established convention in the "template" workflows, but I missed some applications of it. I think it's most effective when done consistently throughout the workflows.
1 parent bc14b21 commit 1816d8e

14 files changed

+70
-14
lines changed

.github/workflows/check-yaml-task.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/check-yaml-task.md
22
name: Check YAML
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
# See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
59
on:
610
push:
@@ -65,7 +69,7 @@ jobs:
6569
- name: Install Python
6670
uses: actions/setup-python@v2
6771
with:
68-
python-version: "3.9"
72+
python-version: ${{ env.PYTHON_VERSION }}
6973

7074
- name: Install Poetry
7175
run: pip install poetry

.github/workflows/spell-check-task.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/spell-check-task.md
22
name: Spell Check
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows
59
on:
610
push:
@@ -22,7 +26,7 @@ jobs:
2226
- name: Install Python
2327
uses: actions/setup-python@v2
2428
with:
25-
python-version: "3.9"
29+
python-version: ${{ env.PYTHON_VERSION }}
2630

2731
- name: Install Poetry
2832
run: pip install poetry

workflow-templates/check-mkdocs-task.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/check-mkdocs-task.md
22
name: Check Website
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
# See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
59
on:
610
push:
@@ -33,7 +37,7 @@ jobs:
3337
- name: Install Python
3438
uses: actions/setup-python@v2
3539
with:
36-
python-version: "3.9"
40+
python-version: ${{ env.PYTHON_VERSION }}
3741

3842
- name: Install Poetry
3943
run: pip install poetry

workflow-templates/check-yaml-task.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/check-yaml-task.md
22
name: Check YAML
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
# See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
59
on:
610
push:
@@ -65,7 +69,7 @@ jobs:
6569
- name: Install Python
6670
uses: actions/setup-python@v2
6771
with:
68-
python-version: "3.9"
72+
python-version: ${{ env.PYTHON_VERSION }}
6973

7074
- name: Install Poetry
7175
run: pip install poetry

workflow-templates/dependabot/workflow-template-copies/.github/workflows/check-mkdocs-task.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/check-mkdocs-task.md
22
name: Check Website
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
# See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
59
on:
610
push:
@@ -33,7 +37,7 @@ jobs:
3337
- name: Install Python
3438
uses: actions/setup-python@v2
3539
with:
36-
python-version: "3.9"
40+
python-version: ${{ env.PYTHON_VERSION }}
3741

3842
- name: Install Poetry
3943
run: pip install poetry

workflow-templates/dependabot/workflow-template-copies/.github/workflows/check-yaml-task.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/check-yaml-task.md
22
name: Check YAML
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
# See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
59
on:
610
push:
@@ -65,7 +69,7 @@ jobs:
6569
- name: Install Python
6670
uses: actions/setup-python@v2
6771
with:
68-
python-version: "3.9"
72+
python-version: ${{ env.PYTHON_VERSION }}
6973

7074
- name: Install Poetry
7175
run: pip install poetry

workflow-templates/dependabot/workflow-template-copies/.github/workflows/deploy-cobra-mkdocs-versioned-poetry.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/deploy-cobra-mkdocs-versioned-poetry.md
22
name: Deploy Website
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
on:
59
push:
610
branches:
@@ -52,7 +56,7 @@ jobs:
5256
- name: Install Python
5357
uses: actions/setup-python@v2
5458
with:
55-
python-version: "3.9"
59+
python-version: ${{ env.PYTHON_VERSION }}
5660

5761
- name: Install Poetry
5862
run: |

workflow-templates/dependabot/workflow-template-copies/.github/workflows/deploy-mkdocs-poetry.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/deploy-mkdocs-poetry.md
22
name: Deploy Website
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
# See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
59
on:
610
push:
@@ -27,7 +31,7 @@ jobs:
2731
- name: Install Python
2832
uses: actions/setup-python@v2
2933
with:
30-
python-version: "3.9"
34+
python-version: ${{ env.PYTHON_VERSION }}
3135

3236
- name: Install Poetry
3337
run: pip install poetry

workflow-templates/dependabot/workflow-template-copies/.github/workflows/deploy-mkdocs-versioned-poetry.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/deploy-mkdocs-versioned-poetry.md
22
name: Deploy Website
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
on:
59
push:
610
branches:
@@ -47,7 +51,7 @@ jobs:
4751
- name: Install Python
4852
uses: actions/setup-python@v2
4953
with:
50-
python-version: "3.9"
54+
python-version: ${{ env.PYTHON_VERSION }}
5155

5256
- name: Install Poetry
5357
run: |

workflow-templates/dependabot/workflow-template-copies/.github/workflows/spell-check-task.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/spell-check-task.md
22
name: Spell Check
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows
59
on:
610
push:
@@ -22,7 +26,7 @@ jobs:
2226
- name: Install Python
2327
uses: actions/setup-python@v2
2428
with:
25-
python-version: "3.9"
29+
python-version: ${{ env.PYTHON_VERSION }}
2630

2731
- name: Install Poetry
2832
run: pip install poetry

workflow-templates/deploy-cobra-mkdocs-versioned-poetry.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/deploy-cobra-mkdocs-versioned-poetry.md
22
name: Deploy Website
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
on:
59
push:
610
branches:
@@ -52,7 +56,7 @@ jobs:
5256
- name: Install Python
5357
uses: actions/setup-python@v2
5458
with:
55-
python-version: "3.9"
59+
python-version: ${{ env.PYTHON_VERSION }}
5660

5761
- name: Install Poetry
5862
run: |

workflow-templates/deploy-mkdocs-poetry.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/deploy-mkdocs-poetry.md
22
name: Deploy Website
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
# See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
59
on:
610
push:
@@ -27,7 +31,7 @@ jobs:
2731
- name: Install Python
2832
uses: actions/setup-python@v2
2933
with:
30-
python-version: "3.9"
34+
python-version: ${{ env.PYTHON_VERSION }}
3135

3236
- name: Install Poetry
3337
run: pip install poetry

workflow-templates/deploy-mkdocs-versioned-poetry.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/deploy-mkdocs-versioned-poetry.md
22
name: Deploy Website
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
on:
59
push:
610
branches:
@@ -47,7 +51,7 @@ jobs:
4751
- name: Install Python
4852
uses: actions/setup-python@v2
4953
with:
50-
python-version: "3.9"
54+
python-version: ${{ env.PYTHON_VERSION }}
5155

5256
- name: Install Poetry
5357
run: |

workflow-templates/spell-check-task.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/spell-check-task.md
22
name: Spell Check
33

4+
env:
5+
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
6+
PYTHON_VERSION: "3.9"
7+
48
# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows
59
on:
610
push:
@@ -22,7 +26,7 @@ jobs:
2226
- name: Install Python
2327
uses: actions/setup-python@v2
2428
with:
25-
python-version: "3.9"
29+
python-version: ${{ env.PYTHON_VERSION }}
2630

2731
- name: Install Poetry
2832
run: pip install poetry

0 commit comments

Comments
 (0)