Skip to content

Commit cb5d813

Browse files
committed
Install referenced schema in "npm:validate" task
The "npm:validate" task validates the repository's `package.json` npm manifest file against its JSON schema to catch any problems with its data format. In order to avoid duplication of content, JSON schemas may reference other schemas via the `$ref` keyword. The `package.json` schema was recently updated to share resources with the npm-badges configuration schema, which caused the validation to start failing: schema /tmp/package-json-schema-WItZVgRyuR.json is invalid error: can't resolve reference https://json.schemastore.org/partial-eslint-plugins.json from id https://json.schemastore.org/eslintrc.json# task: Failed to run task "npm:validate": exit status 1 The solution is to configure the workflow to download that schema as well and also to provide its path to the avj-cli validator via a `-r` flag.
1 parent b7503ca commit cb5d813

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

Taskfile.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,10 @@ tasks:
200200
NPM_BADGES_SCHEMA_URL: https://json.schemastore.org/npm-badges.json
201201
NPM_BADGES_SCHEMA_PATH:
202202
sh: task utility:mktemp-file TEMPLATE="npm-badges-schema-XXXXXXXXXX.json"
203+
# Source: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/partial-eslint-plugins.json
204+
PARTIAL_ESLINT_PLUGINS_SCHEMA_URL: https://json.schemastore.org/partial-eslint-plugins.json
205+
PARTIAL_ESLINT_PLUGINS_PATH:
206+
sh: task utility:mktemp-file TEMPLATE="partial-eslint-plugins-schema-XXXXXXXXXX.json"
203207
# Source: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/prettierrc.json
204208
PRETTIERRC_SCHEMA_URL: https://json.schemastore.org/prettierrc.json
205209
PRETTIERRC_SCHEMA_PATH:
@@ -223,6 +227,7 @@ tasks:
223227
- wget --quiet --output-document="{{.ESLINTRC_SCHEMA_PATH}}" {{.ESLINTRC_SCHEMA_URL}}
224228
- wget --quiet --output-document="{{.JSCPD_SCHEMA_PATH}}" {{.JSCPD_SCHEMA_URL}}
225229
- wget --quiet --output-document="{{.NPM_BADGES_SCHEMA_PATH}}" {{.NPM_BADGES_SCHEMA_URL}}
230+
- wget --quiet --output-document="{{.PARTIAL_ESLINT_PLUGINS_PATH}}" {{.PARTIAL_ESLINT_PLUGINS_SCHEMA_URL}}
226231
- wget --quiet --output-document="{{.PRETTIERRC_SCHEMA_PATH}}" {{.PRETTIERRC_SCHEMA_URL}}
227232
- wget --quiet --output-document="{{.SEMANTIC_RELEASE_SCHEMA_PATH}}" {{.SEMANTIC_RELEASE_SCHEMA_URL}}
228233
- wget --quiet --output-document="{{.STYLELINTRC_SCHEMA_PATH}}" {{.STYLELINTRC_SCHEMA_URL}}
@@ -235,6 +240,7 @@ tasks:
235240
-r "{{.ESLINTRC_SCHEMA_PATH}}" \
236241
-r "{{.JSCPD_SCHEMA_PATH}}" \
237242
-r "{{.NPM_BADGES_SCHEMA_PATH}}" \
243+
-r "{{.PARTIAL_ESLINT_PLUGINS_PATH}}" \
238244
-r "{{.PRETTIERRC_SCHEMA_PATH}}" \
239245
-r "{{.SEMANTIC_RELEASE_SCHEMA_PATH}}" \
240246
-r "{{.STYLELINTRC_SCHEMA_PATH}}" \

0 commit comments

Comments
 (0)