Skip to content

Commit 3227c71

Browse files
committed
apply suggestions from code review
1 parent 6050c1e commit 3227c71

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

main.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,14 +100,13 @@ func (d *SerialMonitor) Configure(parameterName string, value string) error {
100100
values := serialSettings.ConfigurationParameter[parameterName].Values
101101
for _, i := range values {
102102
if i == value {
103-
serialSettings.ConfigurationParameter[parameterName].Selected = value
104103
if openedPort != nil {
105104
err := openedPort.SetMode(getMode())
106105
if err != nil {
107106
return errors.New(err.Error())
108-
109107
}
110108
}
109+
serialSettings.ConfigurationParameter[parameterName].Selected = value
111110
return nil
112111
}
113112
}
@@ -121,9 +120,8 @@ func (d *SerialMonitor) Open(boardPort string) (io.ReadWriter, error) {
121120
}
122121
openedPort, err := serial.Open(boardPort, getMode())
123122
if err != nil {
124-
fmt.Print(boardPort)
125123
openedPort = nil
126-
return nil, errors.New(err.Error())
124+
return nil, err
127125

128126
}
129127
return openedPort, nil

0 commit comments

Comments
 (0)