Fixed PathList.AddAllMissing

Author: cmaglie

list.go

@@ -112,11 +112,11 @@ func (p *PathList) AddIfMissing(path *Path) {
 	(*p).Add(path)
 }
 
-// AddAllMissing adds all paths to the PathList excluding the path already
+// AddAllMissing adds all paths to the PathList excluding the paths already
 // in the list
-func (p *PathList) AddAllMissing(paths PathList) {
-	for _, path := range *p {
-		(*p).AddIfMissing(path)
+func (p *PathList) AddAllMissing(pathsToAdd PathList) {
+	for _, pathToAdd := range pathsToAdd {
+		(*p).AddIfMissing(pathToAdd)
 	}
 }
 

list_test.go

@@ -55,4 +55,13 @@ func TestListConstructors(t *testing.T) {
 	require.False(t, list3.ContainsEquivalentTo(New("d")))
 	require.True(t, list3.ContainsEquivalentTo(New("a")))
 	require.True(t, list3.ContainsEquivalentTo(New("d/../a")))
+
+	list4 := list3.Clone()
+	require.Equal(t, "[a b c]", fmt.Sprintf("%s", list4))
+	list4.AddIfMissing(New("d"))
+	require.Equal(t, "[a b c d]", fmt.Sprintf("%s", list4))
+	list4.AddIfMissing(New("b"))
+	require.Equal(t, "[a b c d]", fmt.Sprintf("%s", list4))
+	list4.AddAllMissing(NewPathList("a", "e", "i", "o", "u"))
+	require.Equal(t, "[a b c d e i o u]", fmt.Sprintf("%s", list4))
 }