Skip to content

Commit 93ff259

Browse files
silvanocerzacmaglie
authored andcommitted
Fixed FilterOutDirs
1 parent 66d69f0 commit 93ff259

File tree

2 files changed

+37
-1
lines changed

2 files changed

+37
-1
lines changed

list.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ func (p *PathList) FilterDirs() {
7878
func (p *PathList) FilterOutDirs() {
7979
res := (*p)[:0]
8080
for _, path := range *p {
81-
if path.IsDir() {
81+
if path.IsNotDir() {
8282
res = append(res, path)
8383
}
8484
}

paths_test.go

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,3 +266,39 @@ func TestReadDirRecursive(t *testing.T) {
266266
require.Equal(t, "_testdata/symlinktofolder/subfolder", list[12].String())
267267
require.Equal(t, "_testdata/symlinktofolder/subfolder/file4", list[13].String())
268268
}
269+
270+
func TestFilterDirs(t *testing.T) {
271+
testPath := New("_testdata")
272+
273+
list, err := testPath.ReadDir()
274+
require.NoError(t, err)
275+
require.Len(t, list, 4)
276+
277+
require.Equal(t, "_testdata/anotherFile", list[0].String())
278+
require.Equal(t, "_testdata/file", list[1].String())
279+
require.Equal(t, "_testdata/folder", list[2].String())
280+
require.Equal(t, "_testdata/symlinktofolder", list[3].String())
281+
282+
list.FilterDirs()
283+
require.Len(t, list, 2)
284+
require.Equal(t, "_testdata/folder", list[0].String())
285+
require.Equal(t, "_testdata/symlinktofolder", list[1].String())
286+
}
287+
288+
func TestFilterOutDirs(t *testing.T) {
289+
testPath := New("_testdata")
290+
291+
list, err := testPath.ReadDir()
292+
require.NoError(t, err)
293+
require.Len(t, list, 4)
294+
295+
require.Equal(t, "_testdata/anotherFile", list[0].String())
296+
require.Equal(t, "_testdata/file", list[1].String())
297+
require.Equal(t, "_testdata/folder", list[2].String())
298+
require.Equal(t, "_testdata/symlinktofolder", list[3].String())
299+
300+
list.FilterOutDirs()
301+
require.Len(t, list, 2)
302+
require.Equal(t, "_testdata/anotherFile", list[0].String())
303+
require.Equal(t, "_testdata/file", list[1].String())
304+
}

0 commit comments

Comments
 (0)