Return boolean variable values directly from functions

Since the variables already contain the value that needs to be returned, the if statement only adds unnecessary
verbosity.

Author: per1234

project/library/library.go

@@ -17,10 +17,7 @@ var headerFileValidExtensions = map[string]struct{}{
 // HasHeaderFileValidExtension returns whether the file at the given path has a valid library header file extension.
 func HasHeaderFileValidExtension(filePath *paths.Path) bool {
 	_, hasHeaderFileValidExtension := headerFileValidExtensions[filePath.Ext()]
-	if hasHeaderFileValidExtension {
-		return true
-	}
-	return false
+	return hasHeaderFileValidExtension
 }
 
 // See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

project/packageindex/packageindex.go

@@ -20,10 +20,7 @@ var validExtensions = map[string]struct{}{
 // HasValidExtension returns whether the file at the given path has a valid package index extension.
 func HasValidExtension(filePath *paths.Path) bool {
 	_, hasValidExtension := validExtensions[filePath.Ext()]
-	if hasValidExtension {
-		return true
-	}
-	return false
+	return hasValidExtension
 }
 
 // Regular expressions for official and non-official package index filenames

project/platform/platform.go

@@ -21,10 +21,7 @@ var configurationFilenames = map[string]struct{}{
 // IsConfigurationFile returns whether the file at the given path has a boards platform configuration file filename.
 func IsConfigurationFile(filePath *paths.Path) bool {
 	_, isConfigurationFile := configurationFilenames[filePath.Base()]
-	if isConfigurationFile {
-		return true
-	}
-	return false
+	return isConfigurationFile
 }
 
 var requiredConfigurationFilenames = map[string]struct{}{
@@ -35,10 +32,7 @@ var requiredConfigurationFilenames = map[string]struct{}{
 // IsRequiredConfigurationFile returns whether the file at the given path has the filename of a required boards platform configuration file.
 func IsRequiredConfigurationFile(filePath *paths.Path) bool {
 	_, isRequiredConfigurationFile := requiredConfigurationFilenames[filePath.Base()]
-	if isRequiredConfigurationFile {
-		return true
-	}
-	return false
+	return isRequiredConfigurationFile
 }
 
 // See: https://arduino.github.io/arduino-cli/latest/platform-specification/#platform-bundled-libraries

project/project.go

@@ -185,10 +185,7 @@ func isSketch(potentialProjectPath *paths.Path) bool {
 }
 
 func isSketchIndicatorFile(filePath *paths.Path) bool {
-	if sketch.HasMainFileValidExtension(filePath) {
-		return true
-	}
-	return false
+	return sketch.HasMainFileValidExtension(filePath)
 }
 
 // isLibrary determines if a path is an Arduino library.
@@ -236,19 +233,11 @@ func isPlatform(potentialProjectPath *paths.Path) bool {
 }
 
 func isPlatformIndicatorFile(filePath *paths.Path) bool {
-	if platform.IsConfigurationFile(filePath) {
-		return true
-	}
-
-	return false
+	return platform.IsConfigurationFile(filePath)
 }
 
 func isStrictPlatformIndicatorFile(filePath *paths.Path) bool {
-	if platform.IsRequiredConfigurationFile(filePath) {
-		return true
-	}
-
-	return false
+	return platform.IsRequiredConfigurationFile(filePath)
 }
 
 // isPackageIndex determines if a path contains an Arduino package index.
@@ -266,17 +255,9 @@ func isPackageIndex(potentialProjectPath *paths.Path) bool {
 }
 
 func isPackageIndexIndicatorFile(filePath *paths.Path) bool {
-	if packageindex.HasValidExtension(filePath) {
-		return true
-	}
-
-	return false
+	return packageindex.HasValidExtension(filePath)
 }
 
 func isStrictPackageIndexIndicatorFile(filePath *paths.Path) bool {
-	if packageindex.HasValidFilename(filePath, true) {
-		return true
-	}
-
-	return false
+	return packageindex.HasValidFilename(filePath, true)
 }

project/sketch/sketch.go

@@ -13,8 +13,5 @@ import (
 // Sketches may contain source files with other extensions (e.g., .h, .cpp), but they are required to have at least one file with a main extension.
 func HasMainFileValidExtension(filePath *paths.Path) bool {
 	_, hasMainFileValidExtension := globals.MainFileValidExtensions[filePath.Ext()]
-	if hasMainFileValidExtension {
-		return true
-	}
-	return false
+	return hasMainFileValidExtension
 }