From 4d109fecf16a4930f1109c6b6e14bd808a18bc21 Mon Sep 17 00:00:00 2001 From: per1234 Date: Mon, 10 Jan 2022 20:08:08 -0800 Subject: [PATCH] Remove inappropriate element from paths filters of "Check Packaging" workflow The `on.*.paths` keys of GitHub workflows can be used to avoid unnecessary or unwanted workflow runs. This is done by defining specific paths containing files relevant to the workflow's purpose. The workflow will only run when the trigger event modifies a file matching the paths. The "Check Packaging" workflow was copied from another project that uses the Task task runner tool. In that project, it is appropriate for the workflow to be triggered on any change to the Task configuration file, and so it was added to the `paths` filter. This project uses npm instead of Task, and does not contain a taskfile, so the presence of that path in the filters is in appropriate and only adds unnecessary complexity to the workflow. --- .github/workflows/check-packaging-ncc-typescript-npm.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/check-packaging-ncc-typescript-npm.yml b/.github/workflows/check-packaging-ncc-typescript-npm.yml index 29a83b6..9a788a2 100644 --- a/.github/workflows/check-packaging-ncc-typescript-npm.yml +++ b/.github/workflows/check-packaging-ncc-typescript-npm.yml @@ -11,7 +11,6 @@ on: - "lerna.json" - "package.json" - "package-lock.json" - - "Taskfile.ya?ml" - "tsconfig.json" - "**.[jt]sx?" pull_request: @@ -20,7 +19,6 @@ on: - "lerna.json" - "package.json" - "package-lock.json" - - "Taskfile.ya?ml" - "tsconfig.json" - "**.[jt]sx?" workflow_dispatch: