From 32f22b1772acbe99d8ab3cbe53a63485035776ed Mon Sep 17 00:00:00 2001 From: Giacomo Cusinato <7659518+giacomocusinato@users.noreply.github.com> Date: Thu, 20 Mar 2025 16:00:11 +0700 Subject: [PATCH 1/3] fix: Add safe dir to local windows runner --- .github/workflows/build.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5bb25811a..003ecb764 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -308,15 +308,19 @@ jobs: timeout-minutes: 90 steps: - - name: Symlink custom working directory + - name: Symlink custom working directory (Window local runner) shell: cmd - if: runner.os == 'Windows' && matrix.config.working-directory + if: runner.name == 'WINDOWS-SIGN-PC' && matrix.config.working-directory run: | if not exist "${{ matrix.config.working-directory }}" mklink /d "${{ matrix.config.working-directory }}" "C:\actions-runner\_work\arduino-ide\arduino-ide" - name: Checkout uses: actions/checkout@v4 + - name: Set Safe Directory (Window local runner) + if: runner.name == 'WINDOWS-SIGN-PC' + run: git config --global --add safe.directory C:/actions-runner/_work/arduino-ide/arduino-ide + - name: Install Node.js if: runner.name != 'WINDOWS-SIGN-PC' From 71eef69d48cda71f50020c0fcd5e8cfcadefacec Mon Sep 17 00:00:00 2001 From: Giacomo Cusinato <7659518+giacomocusinato@users.noreply.github.com> Date: Thu, 20 Mar 2025 16:23:13 +0700 Subject: [PATCH 2/3] Remove step --- .github/workflows/build.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 003ecb764..d0a420445 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -310,18 +310,13 @@ jobs: steps: - name: Symlink custom working directory (Window local runner) shell: cmd - if: runner.name == 'WINDOWS-SIGN-PC' && matrix.config.working-directory + if: runner.os == 'Windows' && matrix.config.working-directory run: | if not exist "${{ matrix.config.working-directory }}" mklink /d "${{ matrix.config.working-directory }}" "C:\actions-runner\_work\arduino-ide\arduino-ide" - name: Checkout uses: actions/checkout@v4 - - name: Set Safe Directory (Window local runner) - if: runner.name == 'WINDOWS-SIGN-PC' - run: git config --global --add safe.directory C:/actions-runner/_work/arduino-ide/arduino-ide - - - name: Install Node.js if: runner.name != 'WINDOWS-SIGN-PC' uses: actions/setup-node@v4 From c00e0fd8c19714bae874ff0100fae756c6601643 Mon Sep 17 00:00:00 2001 From: Giacomo Cusinato <7659518+giacomocusinato@users.noreply.github.com> Date: Thu, 20 Mar 2025 16:24:52 +0700 Subject: [PATCH 3/3] Test --- .github/workflows/build.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d0a420445..e34198ec7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -375,7 +375,6 @@ jobs: export CSC_FOR_PULL_REQUEST=true fi - npx node-gyp install yarn install yarn --cwd arduino-ide-extension build