From 8ebc7e2143477a1b9927ec3e632d3c32081c79d5 Mon Sep 17 00:00:00 2001 From: Alberto Iannaccone Date: Mon, 11 Jul 2022 15:35:58 +0200 Subject: [PATCH 1/2] give an id to the settings dialog to grant higher priority to css rule to fix the max-width --- .../src/browser/dialogs/settings/settings-dialog.tsx | 2 +- arduino-ide-extension/src/browser/style/settings-dialog.css | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arduino-ide-extension/src/browser/dialogs/settings/settings-dialog.tsx b/arduino-ide-extension/src/browser/dialogs/settings/settings-dialog.tsx index 900d02d17..7e27def2a 100644 --- a/arduino-ide-extension/src/browser/dialogs/settings/settings-dialog.tsx +++ b/arduino-ide-extension/src/browser/dialogs/settings/settings-dialog.tsx @@ -63,7 +63,7 @@ export class SettingsDialog extends AbstractDialog> { protected override readonly props: SettingsDialogProps ) { super(props); - this.node.classList.add('arduino-settings-dialog-container'); + this.node.id = 'arduino-settings-dialog-container'; this.contentNode.classList.add('arduino-settings-dialog'); this.appendCloseButton( nls.localize('vscode/issueMainService/cancel', 'Cancel') diff --git a/arduino-ide-extension/src/browser/style/settings-dialog.css b/arduino-ide-extension/src/browser/style/settings-dialog.css index 0c0482c5d..8cdc354af 100644 --- a/arduino-ide-extension/src/browser/style/settings-dialog.css +++ b/arduino-ide-extension/src/browser/style/settings-dialog.css @@ -1,4 +1,4 @@ -.arduino-settings-dialog-container > .dialogBlock { +#arduino-settings-dialog-container > .dialogBlock { width: calc(100% - 96px); max-width: 740px !important; } From c5df3e4fd2b596f613f0ed69d86e2694f0d8a12c Mon Sep 17 00:00:00 2001 From: Alberto Iannaccone Date: Thu, 14 Jul 2022 09:07:56 +0200 Subject: [PATCH 2/2] fix settings dialog height --- .../src/browser/style/settings-dialog.css | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arduino-ide-extension/src/browser/style/settings-dialog.css b/arduino-ide-extension/src/browser/style/settings-dialog.css index 8cdc354af..5d3890166 100644 --- a/arduino-ide-extension/src/browser/style/settings-dialog.css +++ b/arduino-ide-extension/src/browser/style/settings-dialog.css @@ -1,6 +1,11 @@ #arduino-settings-dialog-container > .dialogBlock { - width: calc(100% - 96px); + height: 531px;; max-width: 740px !important; + width: calc(100% - 96px); +} + +#arduino-settings-dialog-container > .dialogBlock > .dialogContent { + justify-content: flex-start; } .arduino-settings-dialog .content {