fall back to new temp sketch URI when no recent WS

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

Author: Akos Kitta

arduino-ide-extension/src/browser/theia/core/frontend-application.ts

@@ -22,17 +22,15 @@ export class FrontendApplication extends TheiaFrontendApplication {
 
   protected override async initializeLayout(): Promise<void> {
     await super.initializeLayout();
-    const roots = await this.workspaceService.roots;
-    for (const root of roots) {
-      const exists = await this.fileService.exists(root.resource);
-      if (exists) {
-        this.sketchesService.markAsRecentlyOpened(root.resource.toString()); // no await, will get the notification later and rebuild the menu
+    this.workspaceService.roots.then(async (roots) => {
+      for (const root of roots) {
         await this.commandService.executeCommand(
           ArduinoCommands.OPEN_SKETCH_FILES.id,
           root.resource
         );
+        this.sketchesService.markAsRecentlyOpened(root.resource.toString()); // no await, will get the notification later and rebuild the menu
       }
-    }
+    });
   }
 
   protected override getStartupIndicator(

arduino-ide-extension/src/browser/theia/workspace/workspace-service.ts

@@ -72,11 +72,12 @@ export class WorkspaceService extends TheiaWorkspaceService {
       // Remove the leading # and decode the URI.
       const wpPath = decodeURI(window.location.hash.substring(1));
       const workspaceUri = new URI().withPath(wpPath).withScheme('file');
-      // Customization! Here, we do no check if the workspace exists.
+      // ### Customization! Here, we do no check if the workspace exists.
       return workspaceUri.toString();
     } else {
       // Else, ask the server for its suggested workspace (usually the one
       // specified on the CLI, or the most recent).
+      // ### Customization! the default workspace server will create a new sketch and will return with its URI if no recent workspaces are available.
       return this.server.getMostRecentlyUsedWorkspace();
     }
   }

arduino-ide-extension/src/node/theia/workspace/default-workspace-server.ts

@@ -1,7 +1,10 @@
+import { promises as fs, constants } from 'fs';
 import { injectable, inject } from '@theia/core/shared/inversify';
 import { ILogger } from '@theia/core/lib/common/logger';
 import { DefaultWorkspaceServer as TheiaDefaultWorkspaceServer } from '@theia/workspace/lib/node/default-workspace-server';
 import { ConfigService } from '../../../common/protocol/config-service';
+import { SketchesService } from '../../../common/protocol';
+import { FileUri } from '@theia/core/lib/node';
 
 @injectable()
 export class DefaultWorkspaceServer extends TheiaDefaultWorkspaceServer {
@@ -11,13 +14,49 @@ export class DefaultWorkspaceServer extends TheiaDefaultWorkspaceServer {
   @inject(ILogger)
   protected readonly logger: ILogger;
 
-  protected override async getWorkspaceURIFromCli(): Promise<string | undefined> {
+  @inject(SketchesService)
+  private readonly sketchesService: SketchesService;
+
+  override async onStart(): Promise<void> {
+    // NOOP
+    // No need to remove untitled workspaces. IDE2 does not use workspaces.
+  }
+
+  override async getMostRecentlyUsedWorkspace(): Promise<string | undefined> {
+    const uri = await super.getMostRecentlyUsedWorkspace();
+    if (!uri) {
+      const { uri } = await this.sketchesService.createNewSketch();
+      return uri;
+    }
+    return uri;
+  }
+
+  /**
+   * This is the async re-implementation of the default Theia behavior.
+   */
+  override async getRecentWorkspaces(): Promise<string[]> {
+    const listUri: string[] = [];
+    const data = await this.readRecentWorkspacePathsFromUserHome();
+    if (data && data.recentRoots) {
+      await Promise.all(
+        data.recentRoots
+          .filter((element) => Boolean(element))
+          .map(async (element) => {
+            if (await this.exists(element)) {
+              listUri.push(element);
+            }
+          })
+      );
+    }
+    return listUri;
+  }
+
+  private async exists(uri: string): Promise<boolean> {
     try {
-      const config = await this.configService.getConfiguration();
-      return config.sketchDirUri;
-    } catch (err) {
-      this.logger.error(`Failed to determine the sketch directory: ${err}`);
-      return super.getWorkspaceURIFromCli();
+      await fs.access(FileUri.fsPath(uri), constants.R_OK | constants.W_OK);
+      return true;
+    } catch {
+      return false;
     }
   }
 }