Skip to content

Commit c8e2240

Browse files
author
Akos Kitta
committed
Use union type of streaming response.
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
1 parent 177a4dc commit c8e2240

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

arduino-ide-extension/src/node/core-service-impl.ts

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,14 @@ import {
99
CoreService,
1010
CoreError,
1111
} from '../common/protocol/core-service';
12-
import { CompileRequest } from './cli-protocol/cc/arduino/cli/commands/v1/compile_pb';
12+
import {
13+
CompileRequest,
14+
CompileResponse,
15+
} from './cli-protocol/cc/arduino/cli/commands/v1/compile_pb';
1316
import { CoreClientAware } from './core-client-provider';
1417
import {
1518
BurnBootloaderRequest,
19+
BurnBootloaderResponse,
1620
UploadRequest,
1721
UploadResponse,
1822
UploadUsingProgrammerRequest,
@@ -300,7 +304,7 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
300304
return {
301305
dispose: () => buffer.dispose(),
302306
stderr,
303-
onData: onData,
307+
onData,
304308
};
305309
}
306310

@@ -356,14 +360,11 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
356360
return grpcPort;
357361
}
358362
}
359-
/**
360-
* Artificial common interface for all gRPC streaming requests.
361-
* Such as `UploadResponse,` `UploadUsingProgrammerResponse`, `BurnBootloaderResponse`, and the `CompileResponse`.
362-
*/
363-
interface StreamingResponse {
364-
getOutStream_asU8(): Uint8Array;
365-
getErrStream_asU8(): Uint8Array;
366-
}
363+
type StreamingResponse =
364+
| CompileResponse
365+
| UploadResponse
366+
| UploadUsingProgrammerResponse
367+
| BurnBootloaderResponse;
367368
namespace StreamingResponse {
368369
// eslint-disable-next-line @typescript-eslint/no-explicit-any
369370
export function createOnDataHandler<R extends StreamingResponse>(

0 commit comments

Comments
 (0)