Skip to content

Commit b84b6c9

Browse files
committed
Make trivial adjustments to comments in "Check Certificates" workflow
No functional difference, and neither is necessarily superior, but this is how it is in the "template", and so it must be here as well.
1 parent 289f07f commit b84b6c9

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

.github/workflows/check-certificates.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ on:
99
paths:
1010
- ".github/workflows/check-certificates.ya?ml"
1111
schedule:
12-
# run every 10 hours
12+
# Run every 10 hours.
1313
- cron: "0 */10 * * *"
1414
workflow_dispatch:
1515
repository_dispatch:
1616

1717
env:
18-
# Begin notifications when there are less than this many days remaining before expiration
18+
# Begin notifications when there are less than this many days remaining before expiration.
1919
EXPIRATION_WARNING_PERIOD: 30
2020

2121
jobs:
@@ -32,17 +32,18 @@ jobs:
3232

3333
matrix:
3434
certificate:
35-
- identifier: macOS signing certificate # Text used to identify the certificate in notifications
36-
certificate-secret: APPLE_SIGNING_CERTIFICATE_P12 # The name of the secret that contains the certificate
37-
password-secret: KEYCHAIN_PASSWORD # The name of the secret that contains the certificate password
35+
# Additional certificate definitions can be added to this list.
36+
- identifier: macOS signing certificate # Text used to identify certificate in notifications.
37+
certificate-secret: APPLE_SIGNING_CERTIFICATE_P12 # Name of the secret that contains the certificate.
38+
password-secret: KEYCHAIN_PASSWORD # Name of the secret that contains the certificate password.
3839
- identifier: Windows signing certificate
3940
certificate-secret: WINDOWS_SIGNING_CERTIFICATE_PFX
4041
password-secret: WINDOWS_SIGNING_CERTIFICATE_PASSWORD
4142

4243
steps:
4344
- name: Set certificate path environment variable
4445
run: |
45-
# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable
46+
# See: https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable
4647
echo "CERTIFICATE_PATH=${{ runner.temp }}/certificate.p12" >> "$GITHUB_ENV"
4748
4849
- name: Decode certificate
@@ -64,7 +65,6 @@ jobs:
6465
exit 1
6566
)
6667
67-
# See: https://github.com/rtCamp/action-slack-notify
6868
- name: Slack notification of certificate verification failure
6969
if: failure()
7070
uses: rtCamp/action-slack-notify@v2.1.0
@@ -104,7 +104,7 @@ jobs:
104104
105105
DAYS_BEFORE_EXPIRATION="$((($(date --utc --date="$EXPIRATION_DATE" +%s) - $(date --utc +%s)) / 60 / 60 / 24))"
106106
107-
# Display the expiration information in the log
107+
# Display the expiration information in the log.
108108
echo "Certificate expiration date: $EXPIRATION_DATE"
109109
echo "Days remaining before expiration: $DAYS_BEFORE_EXPIRATION"
110110
@@ -119,7 +119,7 @@ jobs:
119119
fi
120120
121121
- name: Slack notification of pending certificate expiration
122-
# Don't send spurious expiration notification if verification fails
122+
# Don't send spurious expiration notification if verification fails.
123123
if: failure() && steps.check-expiration.outcome == 'failure'
124124
uses: rtCamp/action-slack-notify@v2.1.0
125125
env:

0 commit comments

Comments
 (0)