Merge pull request #114 from bcmi-labs/gh-actions

Gh actions

Author: kittaakos

.github/workflows/build.yml

@@ -0,0 +1,89 @@
+name: Arduino Pro IDE
+
+on:
+  push:
+    branches:
+      - master
+    tags:
+      - 'v[0-9]+.[0-9]+.[0-9]+*'
+  pull_request:
+    branches:
+      - master
+  schedule:
+    - cron: '0 3 * * *' # run every day at 3AM (https://docs.github.com/en/actions/reference/events-that-trigger-workflows#scheduled-events-schedule)
+
+env:
+  IS_NIGHTLY: ${{ github.event_name == 'schedule' || github.head_ref == 'gh-actions' }} # TODO: remove OR once PR is merged.
+  IS_RELEASE: ${{ startsWith(github.ref, 'refs/tags/v') }}
+
+jobs:
+  build:
+    strategy:
+      matrix:
+        config:
+          - os: windows-2016
+          - os: ubuntu-latest
+          - os: turin-macmini # self-hosted macOS
+
+    runs-on: ${{ matrix.config.os }}
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Install Node.js 10.x
+        uses: actions/setup-node@v1
+        with:
+          node-version: '10.x'
+          registry-url: 'https://registry.npmjs.org'
+
+      - name: Install Python 2.7
+        uses: actions/setup-python@v2
+        with:
+          python-version: '2.7'
+
+      - name: Build
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
+        run: yarn
+
+      - name: Test
+        run: yarn test
+
+      - name: Package
+        shell: bash
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/Microsoft/vscode/issues/28434#issuecomment-346199674
+          PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
+          AC_USERNAME: ${{ secrets.AC_USERNAME }}
+          AC_PASSWORD: ${{ secrets.AC_PASSWORD }}
+          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+        run: |
+          if [ "$RUNNER_OS" == "macOS" ]; then
+            echo ">>> Detected macOS runner. Updating keychain for the app signing..."
+            echo "${{ secrets.KEYCHAIN }}" | base64 --decode > ~/Library/Keychains/apple-developer.keychain-db
+            security list-keychains -s ~/Library/Keychains/apple-developer.keychain-db
+            security unlock-keychain -p "${{ secrets.KEYCHAIN_PASSWORD }}" ~/Library/Keychains/apple-developer.keychain-db
+            echo "<<< The keychain has been successfully updated."
+          fi
+            yarn --cwd ./electron/packager/
+            yarn --cwd ./electron/packager/ package
+
+      - name: Upload [GitHub Actions]
+        uses: actions/upload-artifact@v2
+        with:
+          name: ${{ runner.os }}
+          path: electron/build/dist/build-artifacts/
+
+      - name: Upload [S3]
+        if: env.IS_NIGHTLY == 'true'
+        uses: kittaakos/upload-s3-action@v0.0.1
+        with:
+          aws_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+          aws_bucket: ${{ secrets.DOWNLOADS_BUCKET }}
+          source_dir: electron/build/dist/build-artifacts/
+          destination_dir: arduino-pro-ide/nightly/

.vscode/launch.json

@@ -13,7 +13,7 @@
     {
       "type": "node",
       "request": "launch",
-      "name": "Launch Electron Packager",
+      "name": "Electron Packager",
       "program": "${workspaceRoot}/electron/packager/index.js",
       "cwd": "${workspaceFolder}/electron/packager"
     },

arduino-ide-extension/scripts/download-cli.js

@@ -10,7 +10,7 @@
 
 (() => {
 
-    const DEFAULT_VERSION = '0.9.0'; // require('moment')().format('YYYYMMDD');
+    const DEFAULT_VERSION = '0.11.0'; // require('moment')().format('YYYYMMDD');
 
     const path = require('path');
     const shell = require('shelljs');

arduino-ide-extension/scripts/generate-protocol.js

@@ -35,13 +35,10 @@
         }
     }
 
-    shell.echo('Generating TS/JS API from:');
+    shell.echo('>>> Generating TS/JS API from:');
     if (shell.exec(`git -C ${repository} rev-parse --abbrev-ref HEAD`).code !== 0) {
         shell.exit(1);
     }
-    if (shell.exec(`git -C ${repository} rev-parse --short HEAD`).code !== 0) {
-        shell.exit(1);
-    }
 
     const pluginExec = shell.which('grpc_tools_node_protoc_plugin');
     if (!pluginExec || pluginExec.code !== 0) {
@@ -86,6 +83,6 @@ ${protos.join(' ')}`).code !== 0) {
         shell.exit(1);
     }
 
-    shell.echo('Done.');
+    shell.echo('<<< Generation was successful.');
 
 })();

arduino-ide-extension/src/browser/arduino-commands.ts

@@ -38,6 +38,13 @@ export namespace ArduinoCommands {
         id: 'arduino-open-file'
     }
 
+    /**
+     * Unlike `OPEN_SKETCH`, it opens all files from a sketch folder. (ino, cpp, etc...)
+     */
+    export const OPEN_SKETCH_FILES: Command = {
+        id: 'arduino-open-sketch-files'
+    }
+
     export const SAVE_SKETCH: Command = {
         id: 'arduino-save-file'
     }

arduino-ide-extension/src/browser/arduino-frontend-contribution.tsx

@@ -322,6 +322,12 @@ export class ArduinoFrontendContribution implements FrontendApplicationContribut
             }
         });
 
+        registry.registerCommand(ArduinoCommands.OPEN_SKETCH_FILES, {
+            execute: async (uri: string) => {
+                this.openSketchFiles(uri);
+            }
+        });
+
         registry.registerCommand(ArduinoCommands.SAVE_SKETCH, {
             isVisible: widget => ArduinoToolbar.is(widget) && widget.side === 'left',
             execute: (sketch: Sketch) => {
@@ -548,7 +554,7 @@ export class ArduinoFrontendContribution implements FrontendApplicationContribut
         });
     }
 
-    async openSketchFiles(uri: string): Promise<void> {
+    protected async openSketchFiles(uri: string): Promise<void> {
         const uris = await this.sketchService.getSketchFiles(uri);
         for (const uri of uris) {
             await this.editorManager.open(new URI(uri));

arduino-ide-extension/src/browser/customization/arduino-frontend-application.ts

@@ -1,9 +1,10 @@
 import { injectable, inject } from 'inversify';
 import { FileSystem } from '@theia/filesystem/lib/common/filesystem';
+import { CommandService } from '@theia/core/lib/common/command';
 import { WorkspaceService } from '@theia/workspace/lib/browser/workspace-service';
 import { FrontendApplication } from '@theia/core/lib/browser/frontend-application';
 import { EditorMode } from '../editor-mode';
-import { ArduinoFrontendContribution } from '../arduino-frontend-contribution';
+import { ArduinoCommands } from '../arduino-commands';
 
 @injectable()
 export class ArduinoFrontendApplication extends FrontendApplication {
@@ -14,8 +15,8 @@ export class ArduinoFrontendApplication extends FrontendApplication {
     @inject(WorkspaceService)
     protected readonly workspaceService: WorkspaceService;
 
-    @inject(ArduinoFrontendContribution)
-    protected readonly frontendContribution: ArduinoFrontendContribution;
+    @inject(CommandService)
+    protected readonly commandService: CommandService;
 
     @inject(EditorMode)
     protected readonly editorMode: EditorMode;
@@ -30,7 +31,7 @@ export class ArduinoFrontendApplication extends FrontendApplication {
             for (const root of roots) {
                 const exists = await this.fileSystem.exists(root.uri);
                 if (exists) {
-                    await this.frontendContribution.openSketchFiles(root.uri);
+                    await this.commandService.executeCommand(ArduinoCommands.OPEN_SKETCH_FILES.id, root.uri);
                 }
             }
         }

arduino-ide-extension/src/node/arduino-env-variables-server.ts

@@ -1,12 +1,13 @@
 import { join } from 'path';
 import { homedir } from 'os';
 import { injectable } from 'inversify';
-import { EnvVariablesServerImpl } from '@theia/core/lib/node/env-variables/env-variables-server';
 import { FileUri } from '@theia/core/lib/node/file-uri';
+import { EnvVariablesServerImpl } from '@theia/core/lib/node/env-variables/env-variables-server';
+import { BackendApplicationConfigProvider } from '@theia/core/lib/node/backend-application-config-provider';
 
 @injectable()
 export class ArduinoEnvVariablesServer extends EnvVariablesServerImpl {
 
-    protected readonly configDirUri = FileUri.create(join(homedir(), '.arduinoProIDE')).toString();
+    protected readonly configDirUri = FileUri.create(join(homedir(), BackendApplicationConfigProvider.get().configDirName)).toString();
 
 }

arduino-ide-extension/src/node/boards-service-impl.ts

@@ -220,7 +220,7 @@ export class BoardsServiceImpl implements BoardsService {
             resolve(resp);
         }));
 
-        const requiredTools = resp.getRequiredToolsList().map(t => <Tool>{
+        const requiredTools = resp.getToolsdependenciesList().map(t => <Tool>{
             name: t.getName(),
             packager: t.getPackager(),
             version: t.getVersion()

arduino-ide-extension/src/test/node/arduino-daemon-impl.test.ts

@@ -36,7 +36,7 @@ class SilentArduinoDaemonImpl extends ArduinoDaemonImpl {
         const destDir = track.mkdirSync();
         await spawnCommand(`"${cliPath}"`, ['config', 'init', '--dest-dir', destDir]);
         const content = fs.readFileSync(path.join(destDir, CLI_CONFIG), { encoding: 'utf8' });
-        const cliConfig = safeLoad(content);
+        const cliConfig = safeLoad(content) as any;
         cliConfig.daemon.port = String(this.port);
         const modifiedContent = safeDump(cliConfig);
         fs.writeFileSync(path.join(destDir, CLI_CONFIG), modifiedContent, { encoding: 'utf8' });

azure-pipelines.yml

@@ -44,6 +44,11 @@
         }
       }
     },
+    "backend": {
+      "config": {
+        "configDirName": ".arduinoProIDE"
+      }
+    },
     "generator": {
       "config": {
         "preloadTemplate": "<div class='theia-preload' style='background-color: rgb(237, 241, 242);'></div>"

electron-app/package.json

@@ -48,3 +48,4 @@ One has to manually publish the GitHub release.
 
  - Select `Publish release`.
  - ✨
+

electron/README.md

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+    <key>com.apple.security.cs.allow-jit</key>
+    <true/>
+    <key>com.apple.security.cs.allow-unsigned-executable-memory</key>
+    <true/>
+    <key>com.apple.security.cs.disable-library-validation</key>
+    <true/>
+    <key>com.apple.security.cs.allow-dyld-environment-variables</key>
+    <true/>
+</dict>
+</plist>

electron/build/resources/entitlements.mac.plist

@@ -0,0 +1,24 @@
+const isCI = require('is-ci');
+const { notarize } = require('electron-notarize');
+
+exports.default = async function notarizing(context) {
+    if (!isCI) {
+        console.log('Skipping notarization: not on CI.');
+        return;
+    }
+    const { electronPlatformName, appOutDir } = context;
+    if (electronPlatformName !== 'darwin') {
+        return;
+    }
+
+    const appName = context.packager.appInfo.productFilename;
+    const appBundleId = context.packager.config.appId;
+    console.log(`>>> Notarizing ${appBundleId} at ${appOutDir}/${appName}.app...`);
+
+    return await notarize({
+        appBundleId,
+        appPath: `${appOutDir}/${appName}.app`,
+        appleId: process.env.AC_USERNAME,
+        appleIdPassword: process.env.AC_PASSWORD,
+    });
+};