Skip to content

Commit 3ae7aed

Browse files
author
Akos Kitta
committed
fix: CLI API generator. remove obsolete services
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
1 parent 9e6178d commit 3ae7aed

File tree

5 files changed

+5
-2359
lines changed

5 files changed

+5
-2359
lines changed

arduino-ide-extension/scripts/generate-protocol.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
(async () => {
44
const os = require('node:os');
55
const path = require('node:path');
6-
const { mkdirSync, promises: fs } = require('node:fs');
6+
const { mkdirSync, promises: fs, rmSync } = require('node:fs');
77
const { exec } = require('./utils');
88
const glob = require('glob');
99
const { SemVer, gte, valid: validSemVer } = require('semver');
@@ -140,6 +140,10 @@
140140

141141
const rpc = path.join(repository, 'rpc');
142142
const out = path.join(__dirname, '..', 'src', 'node', 'cli-protocol');
143+
// Must wipe the gen output folder. Otherwise, dangling service implementation remain in IDE2 code,
144+
// although it has been removed from the proto file.
145+
// For example, https://github.com/arduino/arduino-cli/commit/50a8bf5c3e61d5b661ccfcd6a055e82eeb510859.
146+
rmSync(out, { recursive: true, maxRetries: 5, force: true });
143147
mkdirSync(out, { recursive: true });
144148

145149
const protos = await new Promise((resolve) =>

arduino-ide-extension/src/node/cli-protocol/cc/arduino/cli/settings/v1/settings_grpc_pb.d.ts

Lines changed: 0 additions & 126 deletions
This file was deleted.

0 commit comments

Comments
 (0)