Merge pull request #159 from arduino/serialOpenError

Serial open error

Author: AlbyIanna

demo/app.jsx

@@ -121,6 +121,9 @@ class App extends React.Component {
     });
 
     daemon.error.subscribe(this.showError);
+    daemon.serialMonitorError.subscribe(this.showError);
+    daemon.uploadingError.subscribe(this.showError);
+    daemon.downloadingError.subscribe(this.showError);
 
     daemon.devicesList.subscribe(({ serial, network }) => this.setState({
       serialDevices: serial,
@@ -155,6 +158,7 @@ class App extends React.Component {
 
   showError(err) {
     this.setState({ error: err });
+    scrollToBottom(document.body);
   }
 
   clearError() {

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "arduino-create-agent-js-client",
-  "version": "2.2.6",
+  "version": "2.3.0",
   "description": "JS module providing discovery of the Arduino Create Plugin and communication with it",
   "main": "lib/index.js",
   "module": "es/index.js",

package.json

@@ -158,7 +158,7 @@ export default class ChromeOsDaemon extends Daemon {
     }
     const serialPort = this.devicesList.getValue().serial.find(p => p.Name === port);
     if (!serialPort) {
-      return this.serialMonitorOpened.error(new Error(`Can't find port ${port}`));
+      return this.serialMonitorError.next(`Can't find port ${port}`);
     }
     this.appMessages
       .pipe(takeUntil(this.serialMonitorOpened.pipe(filter(open => open))))
@@ -167,7 +167,7 @@ export default class ChromeOsDaemon extends Daemon {
           this.serialMonitorOpened.next(true);
         }
         if (message.portOpenStatus === 'error') {
-          this.serialMonitorOpened.error(new Error(`Failed to open serial ${port}`));
+          this.serialMonitorError.next(`Failed to open serial ${port}`);
         }
       });
     this.channel.postMessage({
@@ -189,7 +189,7 @@ export default class ChromeOsDaemon extends Daemon {
     }
     const serialPort = this.devicesList.getValue().serial.find(p => p.Name === port);
     if (!serialPort) {
-      return this.serialMonitorOpened.error(new Error(`Can't find port ${port}`));
+      return this.serialMonitorError.next(`Can't find port ${port}`);
     }
     this.appMessages
       .pipe(takeUntil(this.serialMonitorOpened.pipe(filter(open => !open))))
@@ -198,7 +198,7 @@ export default class ChromeOsDaemon extends Daemon {
           this.serialMonitorOpened.next(false);
         }
         if (message.portCloseStatus === 'error') {
-          this.serialMonitorOpened.error(new Error(`Failed to close serial ${port}`));
+          this.serialMonitorError.next(`Failed to close serial ${port}`);
         }
       });
     this.channel.postMessage({

src/chrome-app-daemon.js

@@ -45,6 +45,7 @@ export default class Daemon {
     this.channelOpen = new BehaviorSubject(null);
     this.channelOpenStatus = this.channelOpen.pipe(distinctUntilChanged());
     this.error = new BehaviorSubject(null).pipe(distinctUntilChanged());
+    this.serialMonitorError = new BehaviorSubject(null);
 
     this.appMessages = new Subject();
     this.serialMonitorOpened = new BehaviorSubject(false);

src/daemon.js

@@ -336,7 +336,7 @@ export default class SocketDaemon extends Daemon {
   openSerialMonitor(port, baudrate = 9600) {
     const serialPort = this.devicesList.getValue().serial.find(p => p.Name === port);
     if (!serialPort) {
-      return this.serialMonitorOpened.error(new Error(`Can't find board at ${port}`));
+      return this.serialMonitorError.next(`Can't find board at ${port}`);
     }
     if (this.uploading.getValue().status === this.UPLOAD_IN_PROGRESS || serialPort.IsOpen) {
       return;
@@ -349,7 +349,7 @@ export default class SocketDaemon extends Daemon {
           this.serialMonitorOpened.next(true);
         }
         if (message.Cmd === 'OpenFail') {
-          this.serialMonitorOpened.error(new Error(`Failed to open serial monitor at ${port}`));
+          this.serialMonitorError.next(`Failed to open serial monitor at ${port}`);
         }
       });
 
@@ -373,7 +373,7 @@ export default class SocketDaemon extends Daemon {
           this.serialMonitorOpened.next(false);
         }
         if (message.Cmd === 'CloseFail') {
-          this.serialMonitorOpened.error(new Error(`Failed to close serial monitor at ${port}`));
+          this.serialMonitorError.next(`Failed to close serial monitor at ${port}`);
         }
       });
     this.socket.emit('command', `close ${port}`);