From 294bdff958ff41c2d156d4e14895376280e8cac4 Mon Sep 17 00:00:00 2001 From: per1234 Date: Tue, 10 Aug 2021 17:22:39 -0700 Subject: [PATCH] Remove duplicate task for protobuf docs generation The "gRPC reference" section of the documentation website is automatically generated from the repository's protocol buffer files. In order to make this generation process easy for developers to run, the necessary commands are defined in a task. For some reason, there were two tasks for this purpose, with different names and descriptions, but identical commands. This makes the taskfile more difficult to understand and more difficult to maintain. One of the tasks, `protoc:docs` is called by the `docs:generate` task. The other, `docs:gen:protobuf`, is not used or referenced anywhere in the repository. So I have removed `docs:gen:protobuf` from the taskfile. --- Taskfile.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Taskfile.yml b/Taskfile.yml index b6cf48ab7b3..076a504a33b 100755 --- a/Taskfile.yml +++ b/Taskfile.yml @@ -4,14 +4,6 @@ includes: dist: ./DistTasks.yml tasks: - docs:gen:protobuf: - desc: Generate markdown contents for protobuffers - cmds: - - '{{ default "protoc" .PROTOC_BINARY }} --doc_out=./docs/rpc --doc_opt=markdown,commands.md --proto_path=rpc ./rpc/cc/arduino/cli/commands/v1/*.proto' - - '{{ default "protoc" .PROTOC_BINARY }} --doc_out=./docs/rpc --doc_opt=markdown,monitor.md --proto_path=rpc ./rpc/cc/arduino/cli/monitor/v1/*.proto' - - '{{ default "protoc" .PROTOC_BINARY }} --doc_out=./docs/rpc --doc_opt=markdown,settings.md --proto_path=rpc ./rpc/cc/arduino/cli/settings/v1/*.proto' - - '{{ default "protoc" .PROTOC_BINARY }} --doc_out=./docs/rpc --doc_opt=markdown,debug.md --proto_path=rpc ./rpc/cc/arduino/cli/debug/v1/*.proto' - docs:generate: desc: Create all generated documentation content deps: