From ae7178451a82f72f3625e5f028bb573f45d64773 Mon Sep 17 00:00:00 2001 From: rsora Date: Mon, 16 Nov 2020 22:36:01 +0100 Subject: [PATCH 1/9] Bump actions/cache to v2 --- .github/workflows/link-validation.yaml | 2 +- .github/workflows/publish-docs.yaml | 2 +- .github/workflows/validate-docs.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/link-validation.yaml b/.github/workflows/link-validation.yaml index 679f2072236..d12e9957f99 100644 --- a/.github/workflows/link-validation.yaml +++ b/.github/workflows/link-validation.yaml @@ -42,7 +42,7 @@ jobs: architecture: "x64" - name: Cache dependencies - uses: actions/cache@v1 + uses: actions/cache@v2 with: path: ~/.cache/pip key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }} diff --git a/.github/workflows/publish-docs.yaml b/.github/workflows/publish-docs.yaml index ed4f8c672c2..36b76327d01 100644 --- a/.github/workflows/publish-docs.yaml +++ b/.github/workflows/publish-docs.yaml @@ -70,7 +70,7 @@ jobs: architecture: "x64" - name: Cache dependencies - uses: actions/cache@v1 + uses: actions/cache@v2 with: path: ~/.cache/pip key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }} diff --git a/.github/workflows/validate-docs.yaml b/.github/workflows/validate-docs.yaml index 7dd759004dc..b49132ab7c9 100644 --- a/.github/workflows/validate-docs.yaml +++ b/.github/workflows/validate-docs.yaml @@ -57,7 +57,7 @@ jobs: architecture: "x64" - name: Cache dependencies - uses: actions/cache@v1 + uses: actions/cache@v2 with: path: ~/.cache/pip key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }} From 13447547ac574913d5f6cd366a00e02522b1ab69 Mon Sep 17 00:00:00 2001 From: rsora Date: Mon, 16 Nov 2020 22:42:13 +0100 Subject: [PATCH 2/9] Bump actions/checkout to v2 --- .github/workflows/arduino-stats.yaml | 2 +- .github/workflows/i18n-nightly-push.yaml | 2 +- .github/workflows/i18n-weekly-pull.yaml | 2 +- .github/workflows/nightly.yaml | 4 ++-- .github/workflows/python-lint.yaml | 2 +- .github/workflows/release.yaml | 6 +++--- .github/workflows/test.yaml | 4 ++-- .github/workflows/verify-formatting.yaml | 2 +- 8 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/arduino-stats.yaml b/.github/workflows/arduino-stats.yaml index 37c837e5335..2405b4a71a6 100644 --- a/.github/workflows/arduino-stats.yaml +++ b/.github/workflows/arduino-stats.yaml @@ -14,7 +14,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: Fetch downloads count form Arduino CDN using AWS Athena id: fetch diff --git a/.github/workflows/i18n-nightly-push.yaml b/.github/workflows/i18n-nightly-push.yaml index 8ee5fe0ea0e..7241150d483 100644 --- a/.github/workflows/i18n-nightly-push.yaml +++ b/.github/workflows/i18n-nightly-push.yaml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@master + uses: actions/checkout@v2 - name: Install Go uses: actions/setup-go@v2 diff --git a/.github/workflows/i18n-weekly-pull.yaml b/.github/workflows/i18n-weekly-pull.yaml index 6749db625fc..1e6aef65e28 100644 --- a/.github/workflows/i18n-weekly-pull.yaml +++ b/.github/workflows/i18n-weekly-pull.yaml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@master + uses: actions/checkout@v2 - name: Install Go uses: actions/setup-go@v2 diff --git a/.github/workflows/nightly.yaml b/.github/workflows/nightly.yaml index 5711cef1c72..a509f1354c3 100644 --- a/.github/workflows/nightly.yaml +++ b/.github/workflows/nightly.yaml @@ -20,7 +20,7 @@ jobs: steps: - name: checkout - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: build env: @@ -39,7 +39,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: Download artifacts uses: actions/download-artifact@v1 diff --git a/.github/workflows/python-lint.yaml b/.github/workflows/python-lint.yaml index c736d875cd6..85b7ff6978f 100644 --- a/.github/workflows/python-lint.yaml +++ b/.github/workflows/python-lint.yaml @@ -17,7 +17,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@master + uses: actions/checkout@v2 - name: Install Taskfile uses: Arduino/actions/setup-taskfile@master diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index c634f8a5731..38833fc82a8 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -17,7 +17,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: Build run: goreleaser @@ -34,7 +34,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: Download artifacts uses: actions/download-artifact@v1 @@ -92,7 +92,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: Download artifact uses: actions/download-artifact@v1 diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 6b9cbf50eec..a3b4de4eee0 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -17,7 +17,7 @@ jobs: run: git config --global core.autocrlf false - name: Checkout - uses: actions/checkout@master + uses: actions/checkout@v2 - name: Install Go uses: actions/setup-go@v2 @@ -113,7 +113,7 @@ jobs: steps: - name: checkout - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: build shell: bash diff --git a/.github/workflows/verify-formatting.yaml b/.github/workflows/verify-formatting.yaml index b27658dff26..1d6a9932acf 100644 --- a/.github/workflows/verify-formatting.yaml +++ b/.github/workflows/verify-formatting.yaml @@ -22,7 +22,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@master + uses: actions/checkout@v2 - name: Install Taskfile uses: Arduino/actions/setup-taskfile@master From 59307dc5f7390764524bd0586cc27d782b0e67d9 Mon Sep 17 00:00:00 2001 From: rsora Date: Mon, 16 Nov 2020 22:45:34 +0100 Subject: [PATCH 3/9] Pin actions/create-release to v1 --- .github/workflows/release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 38833fc82a8..0c02273121c 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -120,7 +120,7 @@ jobs: - name: Create Github Release id: create_release - uses: actions/create-release@master + uses: actions/create-release@v1 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: From d689c4c08747b7c3b7be2654754b423b245849e1 Mon Sep 17 00:00:00 2001 From: rsora Date: Mon, 16 Nov 2020 22:51:11 +0100 Subject: [PATCH 4/9] Bump actions/download-artifact to v2 and maitain compatibility --- .github/workflows/nightly.yaml | 8 ++++++-- .github/workflows/release.yaml | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/workflows/nightly.yaml b/.github/workflows/nightly.yaml index a509f1354c3..2997b901aa1 100644 --- a/.github/workflows/nightly.yaml +++ b/.github/workflows/nightly.yaml @@ -42,9 +42,11 @@ jobs: uses: actions/checkout@v2 - name: Download artifacts - uses: actions/download-artifact@v1 + uses: actions/download-artifact@v2 with: name: dist + # to ensure compatibility with v1 + path: dist - name: Import Code-Signing Certificates env: @@ -97,9 +99,11 @@ jobs: steps: - name: Download artifact - uses: actions/download-artifact@v1 + uses: actions/download-artifact@v2 with: name: dist + # to ensure compatibility with v1 + path: dist - name: upload uses: docker://plugins/s3 diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 0c02273121c..b0d91da9a4b 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -37,9 +37,11 @@ jobs: uses: actions/checkout@v2 - name: Download artifacts - uses: actions/download-artifact@v1 + uses: actions/download-artifact@v2 with: name: dist + # to ensure compatibility with v1 + path: dist - name: Import Code-Signing Certificates env: @@ -95,9 +97,11 @@ jobs: uses: actions/checkout@v2 - name: Download artifact - uses: actions/download-artifact@v1 + uses: actions/download-artifact@v2 with: name: dist + # to ensure compatibility with v1 + path: dist - name: Read CHANGELOG id: changelog From 2e559abafe97398da7e49fcb3adb2b1b124de7d5 Mon Sep 17 00:00:00 2001 From: rsora Date: Mon, 16 Nov 2020 22:54:33 +0100 Subject: [PATCH 5/9] Bump actions/github-scripts to v3 --- .github/workflows/github-stats.yaml | 2 +- .github/workflows/stale.yaml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/github-stats.yaml b/.github/workflows/github-stats.yaml index 83ca534ce34..2dfabb4412b 100644 --- a/.github/workflows/github-stats.yaml +++ b/.github/workflows/github-stats.yaml @@ -15,7 +15,7 @@ jobs: steps: - name: Fetch downloads count id: fetch - uses: actions/github-script@0.2.0 + uses: actions/github-script@v3 with: github-token: ${{github.token}} script: | diff --git a/.github/workflows/stale.yaml b/.github/workflows/stale.yaml index 3b83f33b944..b61b2c688eb 100644 --- a/.github/workflows/stale.yaml +++ b/.github/workflows/stale.yaml @@ -13,7 +13,7 @@ jobs: steps: - name: Mark stale if: github.event_name == 'schedule' - uses: actions/github-script@0.2.0 + uses: actions/github-script@v3 with: github-token: ${{github.token}} script: | @@ -47,7 +47,7 @@ jobs: - name: Mark active if: github.event_name == 'issue_comment' - uses: actions/github-script@0.2.0 + uses: actions/github-script@v3 with: github-token: ${{github.token}} script: | @@ -75,7 +75,7 @@ jobs: - name: Close stale if: github.event_name == 'schedule' - uses: actions/github-script@0.2.0 + uses: actions/github-script@v3 with: github-token: ${{github.token}} script: | From bb5e5ad33d0929746963732fa3e31cabb398efc6 Mon Sep 17 00:00:00 2001 From: rsora Date: Mon, 16 Nov 2020 22:59:07 +0100 Subject: [PATCH 6/9] Bump actions/upload-artifact to v2 --- .github/workflows/nightly.yaml | 4 ++-- .github/workflows/release.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/nightly.yaml b/.github/workflows/nightly.yaml index 2997b901aa1..d2951d1a99a 100644 --- a/.github/workflows/nightly.yaml +++ b/.github/workflows/nightly.yaml @@ -28,7 +28,7 @@ jobs: run: goreleaser --snapshot - name: Upload artifacts - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v2 with: name: dist path: dist @@ -88,7 +88,7 @@ jobs: perl -pi -w -e "s/.*${PACKAGE_FILENAME}/${CLI_CHECKSUM} ${PACKAGE_FILENAME}/g;" dist/*-checksums.txt - name: Upload artifacts - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v2 with: name: dist path: dist diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index b0d91da9a4b..1ff00e91eb8 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -23,7 +23,7 @@ jobs: run: goreleaser - name: Upload artifacts - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v2 with: name: dist path: dist @@ -83,7 +83,7 @@ jobs: perl -pi -w -e "s/.*arduino-cli_${TAG}_macOS_64bit.tar.gz/${CLI_CHECKSUM} arduino-cli_${TAG}_macOS_64bit.tar.gz/g;" dist/*-checksums.txt - name: Upload artifacts - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v2 with: name: dist path: dist From 3c91e878c3ede8affa03db03dbd72d96dabd35c5 Mon Sep 17 00:00:00 2001 From: rsora Date: Mon, 16 Nov 2020 23:06:13 +0100 Subject: [PATCH 7/9] Bump peter-evans/create-pull-request to v3 --- .github/workflows/i18n-weekly-pull.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/i18n-weekly-pull.yaml b/.github/workflows/i18n-weekly-pull.yaml index 1e6aef65e28..1909f555c63 100644 --- a/.github/workflows/i18n-weekly-pull.yaml +++ b/.github/workflows/i18n-weekly-pull.yaml @@ -37,8 +37,9 @@ jobs: TRANSIFEX_API_KEY: ${{ secrets.TRANSIFEX_API_KEY }} - name: Create Pull Request - uses: peter-evans/create-pull-request@v2 + uses: peter-evans/create-pull-request@v3 with: commit-message: Updated translation files title: Updated translation files branch: i18n/translations-update + author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> From c0802f7cb8a85d7cf86a87514940cf7a023bfe1e Mon Sep 17 00:00:00 2001 From: rsora Date: Mon, 16 Nov 2020 23:08:18 +0100 Subject: [PATCH 8/9] Bump svenstaro/upload-release-action to v2 --- .github/workflows/release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 1ff00e91eb8..505cb753a03 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -135,7 +135,7 @@ jobs: prerelease: ${{ steps.prerelease.outputs.IS_PRE }} - name: Upload release files on Github - uses: svenstaro/upload-release-action@v1-release + uses: svenstaro/upload-release-action@v2 with: repo_token: ${{ secrets.GITHUB_TOKEN }} file: dist/* From ae5db83d8b72b5f9e1d5e88d1dff575758f433b7 Mon Sep 17 00:00:00 2001 From: Silvano Cerza Date: Mon, 23 Nov 2020 15:52:35 +0100 Subject: [PATCH 9/9] Fix issue with actions/checkout@v2 In certain workflows we use a custom Docker image for cross-compilation, this image is old and unmaintained so it has an old version of git and the latest version actions/checkout doesn't support it. This causes the action to fallback to the Github API to download the files but that doesn't create a git repository, thus the history is lost but goreleaser needs it to generate the changelog so it fails. So we use the older version of the action in certain cases to avoid this failures. --- .github/workflows/nightly.yaml | 4 +++- .github/workflows/release.yaml | 4 +++- .github/workflows/test.yaml | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nightly.yaml b/.github/workflows/nightly.yaml index d2951d1a99a..7eb8f1081de 100644 --- a/.github/workflows/nightly.yaml +++ b/.github/workflows/nightly.yaml @@ -20,7 +20,9 @@ jobs: steps: - name: checkout - uses: actions/checkout@v2 + uses: actions/checkout@v1 + with: + fetch-depth: 0 - name: build env: diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 505cb753a03..99da49f91d2 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -17,7 +17,9 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v1 + with: + fetch-depth: 0 - name: Build run: goreleaser diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index a3b4de4eee0..a2280e32153 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -113,7 +113,9 @@ jobs: steps: - name: checkout - uses: actions/checkout@v2 + uses: actions/checkout@v1 + with: + fetch-depth: 0 - name: build shell: bash