Migrated TestBoardListallWithManuallyInstalledPlatform from test_board.py to board_test.go

Author: MatteoPologruto

internal/integrationtest/board/board_test.go

@@ -22,6 +22,8 @@ import (
 	"github.com/arduino/arduino-cli/internal/integrationtest"
 	"github.com/stretchr/testify/require"
 	"go.bug.st/testifyjson/requirejson"
+	"gopkg.in/src-d/go-git.v4"
+	"gopkg.in/src-d/go-git.v4/plumbing"
 )
 
 func TestBoardList(t *testing.T) {
@@ -108,3 +110,50 @@ func TestBoardListall(t *testing.T) {
 	// Check if the boards' "latest" value is not empty
 	requirejson.Query(t, stdout, ".boards | .[] | .platform | .latest != \"\"", "true")
 }
+
+func TestBoardListallWithManuallyInstalledPlatform(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// Manually installs a core in sketchbooks hardware folder
+	gitUrl := "https://github.com/arduino/ArduinoCore-samd.git"
+	repoDir := cli.SketchbookDir().Join("hardware", "arduino-beta-development", "samd")
+	_, err = git.PlainClone(repoDir.String(), false, &git.CloneOptions{
+		URL:           gitUrl,
+		ReferenceName: plumbing.NewTagReferenceName("1.8.11"),
+	})
+	require.NoError(t, err)
+
+	stdout, _, err := cli.Run("board", "listall", "--format", "json")
+	require.NoError(t, err)
+
+	requirejson.Query(t, stdout, ".boards | length", "17")
+
+	requirejson.Contains(t, stdout, `{
+		"boards": [
+			{
+				"name": "Arduino MKR1000",
+				"fqbn": "arduino-beta-development:samd:mkr1000",
+				"platform": {
+				  "id": "arduino-beta-development:samd",
+				  "installed": "1.8.11",
+				  "latest": "1.8.11",
+				  "name": "Arduino SAMD (32-bits ARM Cortex-M0+) Boards",
+				}
+			},
+			{
+				"name": "Arduino NANO 33 IoT",
+      			"fqbn": "arduino-beta-development:samd:nano_33_iot",
+      			"platform": {
+        			"id": "arduino-beta-development:samd",
+        			"installed": "1.8.11",
+        			"latest": "1.8.11",
+        			"name": "Arduino SAMD (32-bits ARM Cortex-M0+) Boards"
+				}
+			}
+		]
+	}`)
+}

test/test_board.py

@@ -394,36 +394,6 @@
 """  # noqa: E501
 
 
-def test_board_listall_with_manually_installed_platform(run_command, data_dir):
-    assert run_command(["update"])
-
-    # Manually installs a core in sketchbooks hardware folder
-    git_url = "https://github.com/arduino/ArduinoCore-samd.git"
-    repo_dir = Path(data_dir, "hardware", "arduino-beta-development", "samd")
-    assert Repo.clone_from(git_url, repo_dir, multi_options=["-b 1.8.11"])
-
-    res = run_command(["board", "listall", "--format", "json"])
-    assert res.ok
-    data = json.loads(res.stdout)
-    boards = {b["fqbn"]: b for b in data["boards"]}
-    assert len(boards) == 17
-    assert "arduino-beta-development:samd:nano_33_iot" in boards
-    assert "Arduino NANO 33 IoT" == boards["arduino-beta-development:samd:nano_33_iot"]["name"]
-    platform = boards["arduino-beta-development:samd:nano_33_iot"]["platform"]
-    assert "arduino-beta-development:samd" == platform["id"]
-    assert "1.8.11" == platform["installed"]
-    assert "1.8.11" == platform["latest"]
-    assert "Arduino SAMD (32-bits ARM Cortex-M0+) Boards" == platform["name"]
-
-    assert "arduino-beta-development:samd:mkr1000" in boards
-    assert "Arduino MKR1000" == boards["arduino-beta-development:samd:mkr1000"]["name"]
-    platform = boards["arduino-beta-development:samd:mkr1000"]["platform"]
-    assert "arduino-beta-development:samd" == platform["id"]
-    assert "1.8.11" == platform["installed"]
-    assert "1.8.11" == platform["latest"]
-    assert "Arduino SAMD (32-bits ARM Cortex-M0+) Boards" == platform["name"]
-
-
 def test_board_details(run_command):
     run_command(["core", "update-index"])
     # Download samd core pinned to 1.8.6